20 Commits

• Fix various inconsistencies and document better
  Dean Herbert · 2024-01-29 02:10:33 +09:00
  f4dd84fa77
• Fix song progress value may go beyond 1
  Andrei Zavatski · 2024-01-27 03:11:12 +03:00
  3387565ba9
• Centralise beatmap playable duration and bounds lookups
  Dean Herbert · 2023-05-25 17:32:48 +09:00
  058edb5d5f
• Rename ISkinnableDrawable to ISerialisableDrawable
  Dean Herbert · 2023-02-15 18:37:41 +09:00
  d159d6b970
• Tidy up clock logic in all SongProgress classes
  Dean Herbert · 2023-01-18 16:29:42 +09:00
  42e9b2b48c
• Move "show difficulty graph" settings back to respective implementations to avoid legacy version showing it
  Dean Herbert · 2023-01-18 15:31:55 +09:00
  7266d8e10d
• Combine common code into SongProgress base class
  Dean Herbert · 2023-01-18 15:23:55 +09:00
  5429979049
• Partial everything
  Dan Balasescu · 2022-11-27 00:00:27 +09:00
  7bc8908ca9
• Fix `GameplayClockContainer potentially resetting external seeks
  Dean Herbert · 2022-08-18 18:54:10 +09:00
  2c6fd1ec6e
• Move all usage of GameplayClock to IGameplayClock
  Dean Herbert · 2022-08-15 18:30:53 +09:00
  c8764cb333
• Fix div-by-zero in SongProgress when no object duration could be calculated
  Dean Herbert · 2022-08-15 15:05:35 +09:00
  623e90a7b2
• Fix LegacySongProgress incorrectly blocking mouse input from gameplay

  Closes #19555.

  Dean Herbert · 2022-08-03 17:42:29 +09:00
  6ad6561e1c
• Remove caching of GameplayClockContainer in favour of GameplayClock

  Also fixes `SongProgress` being displayed in skin editor on non-gameplay
  screens, due to `GameplayClock` not marked as a required dependency.

  Salman Ahmed · 2022-07-29 16:45:29 +03:00
  905bbdc8ee
• Apply nullability to DefaultSongProgress and clean up more stuff
  Dean Herbert · 2022-07-28 18:37:17 +09:00
  86c2b7e449
• Move initial show to base implementation and add transition for legacy version
  Dean Herbert · 2022-07-28 18:29:49 +09:00
  ea027eda46
• apply code quality fixes
  Nitrous · 2022-07-28 15:30:45 +08:00
  0d36907cad
• set FirstHitTime and LastHitTime once
  Nitrous · 2022-07-28 15:25:12 +08:00
  bca3994d91
• apply suggestions

  - refactor `SongProgress`
  - make`UpdateProgress` more readable
  - enable NRT on new classes
  - refactor `TestSceneSongProgress` to use `GameplayClockContainer`

  Nitrous · 2022-07-28 15:15:41 +08:00
  db62d4be3a
• account for gameplay start time
  Nitrous · 2022-07-28 08:01:38 +08:00
  45c11f2b7b
• make SongProgress abstract

  - move unrelated logic to `DefaultSongProgress`
  - make `LegacySongProgress` inherit `SongProgress`

  Nitrous · 2022-07-27 15:19:21 +08:00
  37e642b0bd