1040 Commits

• Adjust fail handling in multiplayer spectator player to match multiplayer player

  Closes https://github.com/ppy/osu/issues/34884.

  Bartłomiej Dach · 2025-09-02 12:38:34 +02:00
  5c6bbfcc6a
• Add basic spacing between participants in list
  Dean Herbert · 2025-09-01 19:52:29 +09:00
  cf471066bf
• Adjust sizing of room panels and other elements to make things fit better on mobile layouts
  Dean Herbert · 2025-09-01 19:52:29 +09:00
  659480fa3f
• Always use audio from maximised player if there is one in multiplayer spectator
  Bartłomiej Dach · 2025-08-19 12:03:35 +02:00
  083365f332
• Refactor fail management to be more centralised

  Before this commit, there was `AllowFailAnimation` (used by multiplayer)
  and `OnFail()` (used by score submitting implementations of player to
  ensure a failed play submits).
  
  The former is replaced by `PerformFail()` which allows for arbitrary
  operations on failure, which replay player shall leverage in subsequent
  commits. The latter would ideally be replaced by nothing, but it's
  placed in a very awkward place behind a schedule, so by force of
  necessity to avoid code duplication it's replaced by
  `ConcludeFailedScore()` which is overridden to submit the score in all
  submitting players --- except for multiplayer, which is never supposed
  to be calling it, so in that case it just throws an exception.

  Bartłomiej Dach · 2025-08-12 14:18:48 +02:00
  85d48f5df6
• Merge pull request #34206 from smoogipoo/improve-user-style-selection

  Improve user style selection UX based on local beatmap state

  Bartłomiej Dach · 2025-07-14 15:02:23 +02:00
  cb3cfd828c
• Refactor order of operations
  Dan Balasescu · 2025-07-14 21:16:15 +09:00
  bd922e2888
• Exit user style selection when beatmap set changes
  Dan Balasescu · 2025-07-14 18:02:18 +09:00
  3401706e7e
• Hide user style edit button when not downloaded
  Dan Balasescu · 2025-07-14 18:02:18 +09:00
  9d2ba06287
• Add failing tests
  Dan Balasescu · 2025-07-14 17:57:41 +09:00
  e36c590315
• Fix multiplayer spectator leaderboard respecting "show leaderboard" config setting

  Closes https://github.com/ppy/osu/issues/34128
  
  Simplest is best? 🤷

  Bartłomiej Dach · 2025-07-14 09:01:28 +02:00
  0f272ea0f9
• Move cancellation below new equality check
  Dean Herbert · 2025-06-24 17:51:39 +09:00
  4fbffc4d66
• Fix download requests firing too often in multiplayer spectator

  Closes https://github.com/ppy/osu/issues/33785.
  
  Tested on production with debugger attached.

  Dean Herbert · 2025-06-24 15:57:53 +09:00
  0aec52a64e
• Combine two similar flags into one
  Dean Herbert · 2025-06-12 17:27:23 +09:00
  ebfc3c9ccf
• Fix user country flags no longer showing on multiplayer participants list
  Bartłomiej Dach · 2025-06-06 07:42:10 +02:00
  51a758d3f6
• Apply review suggestions
  Bartłomiej Dach · 2025-05-26 09:57:37 +02:00
  ea8ad6b637
• Fix nasty bug associated with reusing a single panel wrong
  Bartłomiej Dach · 2025-05-23 11:45:25 +02:00
  9742f48437
• Refactor team display to fit with pooling better
  Bartłomiej Dach · 2025-05-23 10:47:36 +02:00
  17cf5df668
• Implement pooling in multiplayer participants list
  Bartłomiej Dach · 2025-05-23 10:47:07 +02:00
  61e8c25a92
• Fix case where there's only one player causing NaN

  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dean Herbert · 2025-05-19 18:25:41 +09:00
  962ec3dca0
• Fix multiplayer position display looking wrong when player count is low

  Spotted when watching video in #33173's opening post.

  Dean Herbert · 2025-05-19 16:58:01 +09:00
  beb77176b6
• Fix multiplayer position display not hiding on user change
  Bartłomiej Dach · 2025-05-13 11:47:01 +02:00
  1d3f4ac02b
• Fix code inspection
  Bartłomiej Dach · 2025-05-13 11:37:52 +02:00
  79f88528ae
• Roll the rank counter instead of immediate updates
  Dean Herbert · 2025-05-13 17:04:47 +09:00
  eaa7af58d5
• Improve transition fade in/out
  Dean Herbert · 2025-05-13 16:45:12 +09:00
  e7d26669c0
• Add bar display
  Dean Herbert · 2025-05-13 16:30:38 +09:00
  91b9b41d58
• Merge branch 'master' into multiplayer-position-indicator
  Bartłomiej Dach · 2025-05-09 10:02:18 +02:00
  4d4f469fac
• Fix gameplay leaderboard not always being expanded in gameplay leaderboard

  I'd have preferred a `get; init;` property but tests were also attached
  at the hip to the public bindable. Without some extra composition this
  is the best that I can do.

  Bartłomiej Dach · 2025-05-07 12:09:26 +02:00
  8cc2af4060
• Add local user position display to multiplayer
  Bartłomiej Dach · 2025-04-28 13:40:01 +02:00
  4e49763787
• Implement local user position display for multiplayer
  Bartłomiej Dach · 2025-04-28 13:40:00 +02:00
  52fbd9e796
• Merge branch 'master' into gameplay-leaderboard-skinnable
  Bartłomiej Dach · 2025-04-28 13:11:22 +02:00
  4ad86685e0
• Yet another forgotten initialiser
  Bartłomiej Dach · 2025-04-25 10:44:52 +02:00
  ea759f0c77
• Fix some weirdness around forced multiplayer elements

  - Naming wasn't adjusted
  - When the chat collapsed, the team score display broke due to zero
    width
  
  Partial revert of
  https://github.com/ppy/osu/commit/da1fc1013e07b8dafb0c409354f9d1cef971e449.

  Bartłomiej Dach · 2025-04-25 10:42:04 +02:00
  6d65b68100
• Fix one more test failure
  Bartłomiej Dach · 2025-04-25 08:14:12 +02:00
  ae8fb2ce08
• Fix code quality
  Bartłomiej Dach · 2025-04-24 13:18:35 +02:00
  330f213460
• Convert gameplay leaderboard to skinnable component

  This PR converts the leaderboard into a full-fledged skinnable component
  that can be manipulated by users at will.
  
  Notably, this finally allows https://github.com/ppy/osu/issues/20422 to
  be fixed - although it's a very mixed bag, for several reasons:
  
  - Because of taiko players' refusal to see reason^W^W^W^Winsistence on
    keeping stable behaviours related to aspect ratio treatment, I have to
    assume the worst case scenario, which means than on typical
    resolutions like 16:9 (or even worse, 4:3), the leaderboard will
    likely not occupy as much vertical space as it probably could.
  
  - Additionally, there's the problem of where to put the spectator list.
    I settled on putting it to the right of the leaderboard, but that's
    kind of janky, because the leaderboard sometimes collapses and
    sometimes fully hides, leading to a very awkward space left behind. If
    we had the capability to anchor elements to other elements, maybe this
    could be resolved, but for now, I'm not sure what to do. I think if
    some users are bothered by it they can move it where they want it. Or
    delete it.

  Bartłomiej Dach · 2025-04-24 13:10:30 +02:00
  59b826c321
• Merge branch 'master' into freestyle-mods
  Bartłomiej Dach · 2025-04-23 13:49:32 +02:00
  6da4e09717
• Keep multiplayer settings open during room updates
  Dan Balasescu · 2025-04-23 16:05:35 +09:00
  5ea408f3a1
• Bring back reading from config value
  Bartłomiej Dach · 2025-04-21 09:15:44 +02:00
  da1fc1013e
• Merge branch 'master' into leaderboards/gameplay-provider
  Bartłomiej Dach · 2025-04-21 09:03:24 +02:00
  6b0567e882
• Fix multiplayer background changing in results screen
  Dan Balasescu · 2025-04-17 03:30:55 +09:00
  6052fbb4f9
• Adjust method name
  Dan Balasescu · 2025-04-17 02:36:55 +09:00
  2a09572d09
• Separate gameplay leaderboard data management from display

  This is a prerequisite for supporting skinning of leaderboards.
  
  - New `IGameplayLeaderboardProvider` and `IGameplayLeaderboardScore`
    interfaces are introduced. They are strictly concerned with supplying
    leaderboard data.
  
  - Logic of managing display, which was previously jammed into the
    inheritance hierarchy of `GameplayLeaderboard`, is now moved into
    `IGameplayLeaderboardProvider` implementations. Solo play,
    multiplayer, and multiplayer spectator get their own implementation of
    the interface.
  
  - The inheritance hierarchy of `GameplayLeaderboard` and per-player
    overriding of the implementation of the gameplay leaderboard is gone.
    Only one drawable class (renamed to `DrawableGameplayLeaderboard`) is
    allowed to display the leaderboards, across all modes of play.

  Bartłomiej Dach · 2025-04-16 14:46:55 +02:00
  c231571f06
• Adjust logic to properly list selectable mods
  Dan Balasescu · 2025-04-14 20:23:00 +09:00
  3dcd1a9e74
• Restore freemods/freestyle button exclusivity
  Dan Balasescu · 2025-04-14 20:20:35 +09:00
  276e923843
• Merge pull request #32680 from smoogipoo/mp-history-results

  Allow viewing results of historical multiplayer items

  Bartłomiej Dach · 2025-04-09 10:42:39 +02:00
  8672435afa
• Merge pull request #32723 from sineplusx/fix-multi-chat-hint

  Use actual keybind in multiplayer chat hint

  Bartłomiej Dach · 2025-04-09 09:29:12 +02:00
  c5eda87ac3
• Move key binding string retrieval to RealmKeyBindingStore
  Dean Herbert · 2025-04-09 15:23:55 +09:00
  9e90f80ab5
• Merge branch 'master' into mp-history-results
  Dan Balasescu · 2025-04-08 19:58:44 +09:00
  0b51cec77c
• Merge branch 'master' into freestyle-mods
  Dan Balasescu · 2025-04-08 19:57:28 +09:00
  1c060f986c