osu-lazer

Use another property when reading artist as fallback

I was testing with mp3s ripped via Apple Music and for whatever reason
the artist was in `JoinedPerformers` rather than `JoinedAlbumArtist`.
I'm not about to go down and do research on id3 so I'm just going to try
this and see if anyone complains.

Bartłomiej Dach · 2025-04-28 09:40:34 +02:00

16b658b322

Fix missing disposal of TagLib.File in ChangeAudioTrack

Dean Herbert · 2025-04-28 15:52:55 +09:00

aab2df1704

Simplify taglib interactions further

Dean Herbert · 2025-04-28 15:52:31 +09:00

40faa3fc99

Add manual MIME type resolution for TagLib file creation

Stedoss · 2025-04-28 13:38:38 +09:00

c2efda20d7

Fix osu!mania beatmap objects getting corrupted when updating beatmap background

Closes https://github.com/ppy/osu/issues/32825.

Tested manually to fix the issue. Setting up test coverage for this is
going to likely take over an hour compared to the 30 second fix, so
please advise if required. I couldn't find any existing tests which
perform this flow.

Dean Herbert · 2025-04-17 16:11:03 +09:00

b71281bec8

Fix infinite loop when switching audio tracks fails on an existing beatmap

Bit ugly, but appears to work in practice...

Bartłomiej Dach · 2025-01-27 10:27:06 +01:00

be9c96c041

Catch and display user-friendly errors regarding corrupted audio files

Addresses lack of user feedback as indicated by
https://github.com/ppy/osu/issues/31693.

Bartłomiej Dach · 2025-01-27 10:25:22 +01:00

01ae1a58f1

Display storyboard in editor background

Fixes the main part of https://github.com/ppy/osu/issues/31144.
Support for selecting a video will come later.

Making this work was an absolutely awful time full of dealing with
delightfully kooky issues, and yielded in a very weird-shaped
contraption. There is at least one issue remaining wherein storyboard
videos do not actually display until the track is started in editor, but
that is 99% a framework issue and I do not currently have the mental
fortitude to diagnose further.

Bartłomiej Dach · 2024-12-31 13:57:50 +01:00

21dba621f0

Populate metadata from ID3 tags when changing beatmap audio track in editor

- Closes https://github.com/ppy/osu/issues/21189
- Supersedes / closes https://github.com/ppy/osu-framework/pull/5627
- Supersedes / closes https://github.com/ppy/osu/pull/22235

The reason why I opted for a complete rewrite rather than a revival of
that aforementioned pull series is that it always felt quite gross to me
to be pulling framework's audio subsystem into the task of reading ID3
tags, and I also partially don't believe that BASS is *good* at reading
ID3 tags. Meanwhile, we already have another library pulled in that is
*explicitly* intended for reading multimedia metadata, and using it
does not require framework changes. (And it was pulled in explicitly for
use in the editor verify tab as well.)

The hard and dumb part of this diff is hacking the gibson such that
the metadata section on setup screen actually *updates itself*
after the resources section is done doing its thing. After significant
gnashing of teeth I just did the bare minimum to make work by caching
a common parent and exposing an `Action?` on it. If anyone has better
ideas, I'm all ears.

Bartłomiej Dach · 2024-12-27 15:16:03 +01:00

6a6db5a22b

Add note about expensive operation

Dean Herbert · 2024-12-10 16:45:26 +09:00

bbaa542d4a

Rewrite resource changing code to be more legible (to my eye)

Dean Herbert · 2024-12-10 16:45:26 +09:00

3cac583754

Re-encode difficulties on resource change

Salman Alshamrani · 2024-12-04 04:36:00 -05:00

8e0f6fc12d

Merge branch 'master' into editor-multiple-background-audio-files

Salman Alshamrani · 2024-12-04 04:31:15 -05:00

60d91bada8

Use helper in one more place

Bartłomiej Dach · 2024-11-29 09:22:29 +01:00

5f092811cb

Accidentally a word

Bartłomiej Dach · 2024-11-29 08:46:08 +01:00

5a9127dfc6

Centralise supported file extensions to one helper class

As proposed in
https://github.com/ppy/osu-server-beatmap-submission/pull/5#discussion_r1861680837.

Bartłomiej Dach · 2024-11-29 08:42:45 +01:00

110e4fbb30

Perform a single Save call rather than doing it in each difficulty

Salman Alshamrani · 2024-11-28 18:37:13 -05:00

489d7a30ec

Abstractify resource change logic and share between background and audio

Salman Alshamrani · 2024-11-28 17:57:47 -05:00

311f0947e4

Rename parameter to be more clear

Dean Herbert · 2024-11-28 15:13:59 +09:00

4d9d5adbf4

Refactor ResourcesSection to support new form of selection

Salman Alshamrani · 2024-11-27 05:53:22 -05:00

efb68e4232

Reset new file states after syncing

Salman Alshamrani · 2024-11-24 22:38:48 -05:00

1468385559

Remove no-op SaveState call

Salman Alshamrani · 2024-11-24 01:13:39 -05:00

3480da22d2

Only enable button if there are different filenames

Salman Alshamrani · 2024-11-24 01:11:36 -05:00

95a6226413

Make sync button only affect changed resource type

Salman Alshamrani · 2024-11-24 01:02:34 -05:00

a872f74974

Add localisation support

Salman Alshamrani · 2024-11-24 00:45:17 -05:00

c8b13b726d

Only enable button if there are multiple difficulties

Salman Alshamrani · 2024-11-24 00:34:03 -05:00

e348b3a7aa

Add option to update all difficulties with new background/audio file

Salman Alshamrani · 2024-11-24 00:32:50 -05:00

8e20dc7e9d

Preserve existing beatmap background/audio files if used elsewhere

Salman Alshamrani · 2024-11-24 00:32:27 -05:00

871c365fd8

Move setup screen background preview to appropriate form control

See
https://discord.com/channels/188630481301012481/188630652340404224/1291361342971707463.

Bartłomiej Dach · 2024-10-04 11:09:14 +02:00

7cd724f342

Redo the layout of sections based on discord feedback

See
https://discord.com/channels/188630481301012481/188630652340404224/1291358770064130140
and everything after.

Bartłomiej Dach · 2024-10-03 13:53:21 +02:00

99eb26b7d5

Replace setup screen controls with new "form" controls

Bartłomiej Dach · 2024-10-03 11:49:03 +02:00

b15608343b

Changed file chooser in resource selection to show file name when file is selected

Guido · 2023-12-04 22:51:56 +01:00

8756dd25c6

Return older file if new one is null

ansel · 2023-01-07 18:15:57 +03:00

aaeb43fbb2

Nullability

ansel · 2023-01-07 03:08:02 +03:00

b47cef838c

Fix editor object being requered

ansel · 2023-01-07 03:03:52 +03:00

167ac8b5dd

Refresh background on file change in editor

ansel · 2023-01-06 19:26:30 +03:00

9364c7775d

Partial everything

Dan Balasescu · 2022-11-27 00:00:27 +09:00

7bc8908ca9

Merge pull request #19693 from its5Q/editor-localisation

Add localisation support for beatmap editor setup

Dean Herbert · 2022-08-20 11:51:57 +09:00

cbdd870ecf

Replace osu-web strings with new strings and merge to single file

its5Q · 2022-08-16 01:14:16 +10:00

797a8da996

Add localisation support for beatmap editor setup

its5Q · 2022-08-11 03:53:20 +10:00

2499b7f0cd

Migrate the majority of existing file lookups to use new extension methods

Dean Herbert · 2022-08-10 16:01:16 +09:00

ac99c1ad69

Fix changes to audio / background not triggering an editor state change

Dean Herbert · 2022-08-01 16:53:49 +09:00

6e7c298aaf

Fix editor potentially using a track post-disposal

This changes the editor to track the current track as it is *loaded* by
`MusicController`, rather than haphazardly following the current global
`WorkingBeatmap` (with a potentially unloaded track) or relying on local
immediate-load behaviour (as implemented in `ResourcesSection`).

Dean Herbert · 2022-08-01 16:53:49 +09:00

2f60f91a0e

Merge branch 'master' into editor-metadata-name-unification

Bartłomiej Dach · 2022-06-18 10:22:52 +02:00

f6a3047596

Automated #nullable processing

Dan Balasescu · 2022-06-17 16:37:17 +09:00

f8830c6850

Fix previous file lookup not using metadata properties

Salman Ahmed · 2022-06-16 18:50:38 +03:00

6aee689586

Fix background/track implicitly renamed on initial load