17682 Commits

• Matchmaking stage display / screen layout design improvements (#35118)
  Dean Herbert · 2025-09-25 15:16:22 +09:00
  ff54908687
• Fix match-found not playing due to incorrect case in path
  Dean Herbert · 2025-09-24 18:55:02 +09:00
  67291c1a42
• Improve FailRetryDisplay performance (#35101)
  Andrei Zavatski · 2025-09-24 15:53:16 +09:00
  57e5fe7265
• Fix players positioning on next matchmaking round
  Dan Balasescu · 2025-09-24 14:44:27 +09:00
  13cb5deca3
• Merge pull request #35053 from smoogipoo/matchmaking-player-list-modes

  Add display styles to matchmaking player list

  Dean Herbert · 2025-09-24 02:59:57 +09:00
  8660578d2c
• Play gameplay start sample in matchmaking
  Dan Balasescu · 2025-09-23 17:52:33 +09:00
  aba0d2c1d3
• Adjust namespaces
  Dan Balasescu · 2025-09-18 16:28:25 +09:00
  c08d88eb7f
• Decrease scale of panels
  Dan Balasescu · 2025-09-18 16:28:25 +09:00
  5eaf376a60
• Add display style to PlayerPanelList
  Dan Balasescu · 2025-09-18 16:28:25 +09:00
  b26a1b6330
• Fix errors in gameplay stage of matchmaking
  Dan Balasescu · 2025-09-15 12:49:42 +09:00
  9577472c9e
• Merge pull request #34985 from nekodex/matchmaking-sfx

  More matchmaking SFX work

  Dean Herbert · 2025-09-14 14:38:10 +09:00
  55fe927af0
• Fix argon judgement counter looking misaligned with wireframe off

  Closes https://github.com/ppy/osu/issues/34959.
  
  `ArgonCounterTextComponent` is pretty terrible and prevents being able
  to fix the issue easily. The core issue is that this is the first
  instance of the component's usage where the label text can be longer
  than the counter in the X dimension, so the total width of any counter
  is equal to max(label width, counter width), and the label will be
  aligned to the left of that width, while the counter will be aligned to
  the right of that width.
  
  The fix sort of relies on the fact that I don't expect *any* consumer of
  `ArgonCounterTextComponent` that meaningfully uses the wireframe digits
  to want the non-wireframe digits to be aligned to the *left* rather than
  the right. It's not what I'd expect any segmented display to work.
  (There are usages that specify `TopLeft` anchor, but they usually
  display the same number of wireframe and non-wireframe digits, so for
  them it doesn't really matter if the digits are left-aligned to the
  wireframes or not.)

  Bartłomiej Dach · 2025-09-13 11:11:45 +09:00
  e73e9275ba
• Add SFX for stage progression feedback
  Jamie Taylor · 2025-09-12 18:27:16 +09:00
  9a2513230c
• Rework matchmaking cloud SFX
  Jamie Taylor · 2025-09-12 18:25:08 +09:00
  ccc5ca5d80
• Refactor selection roulette SFX logic
  Jamie Taylor · 2025-09-12 18:23:02 +09:00
  9b9e7a8f75
• Fix main menu key tests
  Dean Herbert · 2025-09-11 16:09:17 +09:00
  0c68a91b4c
• Merge branch 'master' into matchmaking
  Dean Herbert · 2025-09-11 15:11:01 +09:00
  619a6e7321
• Adjust debounce again to handle key down state
  Dean Herbert · 2025-09-11 13:25:24 +09:00
  1ea17129cc
• Merge pull request #34966 from peppy/fix-carousel-thing

  Fix beatmap carousel not holding selection after refilter in some cases

  Bartłomiej Dach · 2025-09-10 10:31:22 +02:00
  1f4f6ce4fe
• Merge pull request #34910 from CloneWith/update/drawable-date

  Make DrawableDate formatting localizable

  Bartłomiej Dach · 2025-09-10 09:54:50 +02:00
  4d76c467f8
• Fix beatmap carousel not holding selection after refilter in some cases

  Closes https://github.com/ppy/osu/issues/34923.

  Dean Herbert · 2025-09-10 16:37:49 +09:00
  699892c6a2
• Use LocalisableString interpolation to make strings update properly
  CloneWith · 2025-09-10 07:49:14 +08:00
  c8c87089e5
• Adjust song select debounce to be high than repeat_initial_delay

  I'm doing this silently to see if any users complain without being told
  about the change. Without this, when holding left arrow for short
  bursts, precisely *one* beatmap change happens before actual key repeat
  kicks in, which feels really weird (updates the leaderboard / background
  unexpectedly).
  
  This is the simplest way to resolve the issue, so if users aren't
  offended by it I think we should commit to it.
  
  Personally it's still fast enough to not annoy me at all.

  Dean Herbert · 2025-09-09 19:11:50 +09:00
  2bd734918a
• Allow exit during matchmaking intro (#137)
  Dan Balasescu · 2025-09-09 18:09:43 +09:00
  a436372b05
• Merge pull request #34956 from peppy/bpm-filtering-less-precise

  Adjust BPM filtering at song select to be less precise

  Dean Herbert · 2025-09-09 17:33:49 +09:00
  68e7af0c02
• Merge pull request #34920 from cl8n/retro-skin

  Add "retro" default skin

  Dean Herbert · 2025-09-09 15:48:12 +09:00
  caad065433
• Adjust BPM filtering at song select to be less precise

  Closes https://github.com/ppy/osu/issues/34942.

  Dean Herbert · 2025-09-09 15:02:57 +09:00
  f94d5004ea
• Change debounce method in rank display to allow more immediate updates
  Dean Herbert · 2025-09-08 15:12:49 +09:00
  06c1b81c1b
• Split main menu buttons into multiplayer section (#136)

  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Dan Balasescu · 2025-09-08 13:54:06 +09:00
  449038d070
• Transmit availability with ready state

  Regressed with https://github.com/ppy/osu-server-spectator/pull/311.
  
  As it turns out, the method not just resets ready states but also the
  beatmap availabilities. So we have to send it again here.
  
  I have a feeling this is also broken in standard multiplayer in some way
  or another.

  Dan Balasescu · 2025-09-07 16:17:28 +09:00
  31188127ef
• Pessimistically set the beatmap in all stages (#135)
  Dan Balasescu · 2025-09-07 16:17:28 +09:00
  48bad31255
• Fix matchmaking being permanently sound-ducked (#134)
  Dan Balasescu · 2025-09-07 16:17:28 +09:00
  1a49c81bab
• Fix results screen crash from missing users (#133)
  Dan Balasescu · 2025-09-07 16:17:28 +09:00
  27db49bad3
• Add some audio feedback to the matchmaking flow (#132)
  Jamie Taylor · 2025-09-07 16:17:28 +09:00
  e6dbb1020c
• Query for available pools for selection (#131)
  Dan Balasescu · 2025-09-07 16:17:27 +09:00
  e0c11504a2
• Add ruleset selector (#130)
  Dan Balasescu · 2025-09-07 16:17:27 +09:00
  330b61f4c0
• Join matchmaking rooms with password
  Dan Balasescu · 2025-09-07 16:17:27 +09:00
  3985596602
• Fix event handler leak
  Dan Balasescu · 2025-09-07 16:17:27 +09:00
  0225c1a867
• Add matchmaking
  Dan Balasescu · 2025-09-07 16:17:27 +09:00
  111b98ef8e
• Add "retro" default skin
  clayton · 2025-09-05 21:21:52 +09:00
  6af48975b0
• Improve initial state handling
  Dean Herbert · 2025-09-05 16:19:55 +09:00
  ab7985f31e
• Change DefaultRankDisplay to start with no value
  Dean Herbert · 2025-09-05 16:10:27 +09:00
  52c10a42be
• Change debounce to be delayed since last actual change to avoid state flickering
  Dean Herbert · 2025-09-05 16:10:12 +09:00
  912c0a39cf
• Simplify implementation
  Dean Herbert · 2025-09-05 16:01:22 +09:00
  45ef97c92c
• Fix rank-up and rank-down sounds playing too often in some scenarios
  NiyazBiyaz · 2025-09-05 15:41:04 +09:00
  54d4b16a01
• Merge pull request #34914 from bdach/error-on-exiting-editor

  Fix errors on exiting from editor if there are no more beatmaps remaining for the ruleset active in song select

  Dean Herbert · 2025-09-05 15:24:07 +09:00
  891b717b3d
• Merge pull request #34903 from peppy/song-select-better-debounce

  Fix song select debounce not handling long (stutter) frames well

  Dean Herbert · 2025-09-05 15:02:53 +09:00
  11e1c2d73f
• Fix broken reselection logic

  d4b357dfa0 contains a sneaky regression.
  The previous code read:
  
      if (CurrentSelection != null && CheckModelEquality(beatmap, CurrentSelection))
  	RequestSelection(matchingNewBeatmap);
  
  and the new one reads:
  
      if (CurrentSelection is GroupedBeatmap currentBeatmapUnderGrouping)
      {
  	var candidateSelection = currentBeatmapUnderGrouping with { Beatmap = beatmap };
  	if (CheckModelEquality(candidateSelection, CurrentSelection))
  	    RequestSelection(candidateSelection);
      }
  
  The point is that we want to reselect `matchingNewBeatmap` here, not the
  old selection. The `CheckModelEquality()` check's purpose is to check
  whether *the current selection needs updating*.
  
  I'm not sure why tests just wonderfully passed despite this, but my
  suspicion is that it was because of accidental copying of realm guids
  that obscured this problem.

  Bartłomiej Dach · 2025-09-04 13:11:31 +02:00
  134f854d7b
• Ensure that matching beatmap still exists when performing replace operation in the carousel
  Bartłomiej Dach · 2025-09-04 12:44:18 +02:00
  6e5bf57fe7
• Fix multiple concerns with new debounce logic

  Tried many approaches but this seems simplest to guarantee no test (or
  other) regressions..

  Dean Herbert · 2025-09-04 18:13:16 +09:00
  b0c7b6c700