843 Commits

• Fix obviously incorrect conditional

  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dean Herbert · 2025-08-29 16:01:49 +09:00
  9e77a5b050
• Fix some mods showing tooltips when settings are default
  Dean Herbert · 2025-08-29 14:08:18 +09:00
  e83f3d5e77
• Return early to avoid creating mod description strings unnecessarily
  Dean Herbert · 2025-08-29 14:08:06 +09:00
  f2f5cf19a2
• Merge pull request #34761 from frenzibyte/fix-flashlight

  Fix flashlight not always matching gameplay scaling

  Bartłomiej Dach · 2025-08-25 12:03:58 +02:00
  6e8246b539
• Fix xmldoc error and reword
  Salman Alshamrani · 2025-08-24 18:55:45 +03:00
  3cca458c21
• Fix flashlight not handling internal playfield sizing changes

  Note that this does not handle sizing/scaling changes applied directly
  to `Playfield`, but it handles any changes within the layers inside
  `PlayfieldAdjustmentContainer`.

  Salman Alshamrani · 2025-08-24 17:51:05 +03:00
  bc59270f3e
• Fix flashlight not correctly scaled to match playfield
  Salman Alshamrani · 2025-08-21 19:03:43 +03:00
  a049f5065d
• Add and use new mod icon assets
  Bartłomiej Dach · 2025-08-21 09:00:44 +02:00
  92016a7d9b
• Merge pull request #33982 from bdach/mania-hit-windows

  Support mania-specific hit window quirks

  Dan Balasescu · 2025-07-07 18:03:02 +09:00
  321707590a
• Disallow Classic mod from being valid in freestyle as required mod

  Because it's not implemented for all rulesets.
  
  Closes https://github.com/ppy/osu/issues/34004.

  Bartłomiej Dach · 2025-07-03 14:29:35 +02:00
  6013d4c0de
• Fix mania Hard Rock & Easy mods not matching stable

  The implementation in `master` was presuming that Hard Rock and Easy
  worked the same way across all rulesets, but actually, in stable mania,
  the two mods have special treatment as per
  
  	https://github.com/peppy/osu-stable-reference/blob/996648fba06baf4e7d2e0b248959399444017895/osu!/GameplayElements/HitObjectManagerMania.cs#L147-L150
  
  The open question here would be what this means for existing scores set
  on lazer using this mod.

  Bartłomiej Dach · 2025-07-02 12:26:50 +02:00
  8e53f47e78
• Support mania-specific hit window quirks

  The quirks in question being that lazer's hit windows in mania preceding
  this change are used in stable *if and only if* Score V2 is active. If
  Score V2 is *not* active, stable has two disparate other sets of hit
  window ranges, dependent on whether the beatmap is a convert or not.
  
  With this commit, those hit windows are used in lazer when the Classic
  mod is active.
  
  Open points for discussion would be:
  
  - What does this mean for plays already set on lazer using the Classic
    mod? Are there even enough of them to care about? Also, on `master`
    the Classic mod does precisely nothing, so maybe such scores should
    just have Classic mod stripped from them?
  
  - What does this mean for the mod multiplier of Classic in mania? (I don't
    expect an answer to this one.)

  Bartłomiej Dach · 2025-07-02 12:26:50 +02:00
  6afdf99df8
• Merge pull request #33910 from bdach/dont-do-a-barrel-roll-actually

  Fix Flashlight having increased radius when Barrel Roll is active

  Dean Herbert · 2025-07-02 18:25:45 +09:00
  0e39e05d19
• Fix Difficulty Adjust extended mod icon information not showing with extended limits active

  - Closes https://github.com/ppy/osu/issues/33522.
  - Alternative to / closes https://github.com/ppy/osu/pull/33561.

  Bartłomiej Dach · 2025-06-30 12:20:05 +02:00
  28caa03d21
• Fix Flashlight having increased radius when Barrel Roll is active

  Closes https://github.com/ppy/osu/issues/33893.
  
  Regressed in https://github.com/ppy/osu/pull/29841.
  
  This sucks but I don't have better ideas.

  Bartłomiej Dach · 2025-06-27 13:48:44 +02:00
  96569e7829
• Remove no longer used method
  Dan Balasescu · 2025-06-25 18:31:35 +09:00
  d42fcabcf4
• Disallow selected mods from being valid for freestyle as required mods due to them not being consistently compatible with other mods across rulesets

  Closes https://github.com/ppy/osu/issues/33444.
  
  The issue here is that for a set of required mods to make sense in the
  context of a freestyle playlist item, it must be consistently either
  valid or invalid *as a combination* across all four default rulesets,
  because freestyle also permits changing ruleset. There are two
  pertinent cases here:
  
  - Flashlight and Hidden are compatible in osu!, taiko, and catch, but
    not compatible in mania. In this case I've disallowed both mods
    because of symmetry, basically - I don't see one "better mod" to
    disallow here.
  
  - Accuracy Challenge and Easy are incompatible in osu!, catch, and mania
    (because the mod gives extra lives) there, but *compatible* in taiko,
    where it does not. In this case I've disallowed Accuracy Challenge
    only, because I find its value in being forced on a freestyle room
    to be much smaller than Easy's.
  
  In the large scale of things I don't see this being very important
  because my view is that 99% of the use case of required mods in
  freestyle is going to be changing the track speed. So I don't think
  anyone is going to care about this going away - but we can reassess if
  I'm proven wrong.

  Bartłomiej Dach · 2025-06-05 15:00:54 +02:00
  05496111d6
• Change implementation to match other implementations

  The previous version was confusing to read.

  Dean Herbert · 2025-05-13 15:10:59 +09:00
  7918685c4e
• Fix rate adjust / time ramp mods not showing "Adjust pitch" in tooltip
  Salman Alshamrani · 2025-05-12 15:14:26 +03:00
  9c77a3e74f
• Move UserAdjustedSettingsCount local to ModDifficultyAdjust in absence of other usages
  Dean Herbert · 2025-04-30 16:04:26 +09:00
  a397737476
• Don't bother with localised implementation of AdjustedSettingsCount

  I was avoiding using reflection to save on overheads, but it's probably
  not worth it.

  Dean Herbert · 2025-04-30 12:58:40 +09:00
  babccca2bb
• Add xmldoc note explaining new flag is instantaneous state
  Dean Herbert · 2025-04-30 12:49:39 +09:00
  14d0565194
• Show marker when settings are adjusted
  Dean Herbert · 2025-04-28 18:14:14 +09:00
  1e8d9b3482
• Show singular difficulty adjust modifications inline in mod icons
  Dean Herbert · 2025-04-28 16:58:16 +09:00
  c16514274d
• Merge branch 'master' into freestyle-mods
  Bartłomiej Dach · 2025-04-23 13:49:32 +02:00
  6da4e09717
• Fix rate adjust no longer showing the rate if custom

  "Accidentally" removed in 6e635f124a
  apparently.

  Bartłomiej Dach · 2025-04-18 14:03:32 +02:00
  5791375b38
• Improve IMod documentation
  Dan Balasescu · 2025-04-17 18:32:35 +09:00
  92267c8bb3
• Use IMod documentation where present
  Dan Balasescu · 2025-04-17 18:32:26 +09:00
  95cf4887e1
• Apply changes from reviews
  Dan Balasescu · 2025-04-17 02:19:31 +09:00
  64aafa4e4c
• Adjust property name
  Dan Balasescu · 2025-04-14 19:34:33 +09:00
  35ee4b6f24
• Only apply freestyle validation to required mods
  Dan Balasescu · 2025-04-14 19:34:21 +09:00
  b4c7d7f498
• Allow classic mod in freestyle
  Dan Balasescu · 2025-04-10 13:05:17 +09:00
  c6e368d3ea
• Allow more mods in freestyle
  Dan Balasescu · 2025-04-04 16:49:23 +09:00
  3a56f59749
• Allow specifying mod compatibility with freestyle
  Dan Balasescu · 2025-04-04 16:49:23 +09:00
  ef0cf5143d
• Change SettingDescription to differentiate between settings and values
  Salman Alshamrani · 2025-03-23 13:43:26 -04:00
  6e635f124a
• Fix double-clicking difficulty adjust sliders not resetting the value to default correctly

  - Closes https://github.com/ppy/osu/issues/31888
  - Supersedes / closes https://github.com/ppy/osu/pull/32060

  Bartłomiej Dach · 2025-02-25 07:40:55 +01:00
  1f562ab47d
• Update for suggestions
  Huo Yaoyuan · 2024-12-03 00:03:59 +08:00
  7ece8ec1dc
• Apply minor performance rules
  Huo Yaoyuan · 2024-11-28 20:41:44 +08:00
  f5a7716509
• Make empty hitwindows readonly static and slightly improve comparison performance
  Dean Herbert · 2024-11-25 19:17:32 +09:00
  605fe71f46
• Fixes cursor rotating along with playfield when using Barrel Roll in standard
  jhk2601 · 2024-10-17 14:38:13 -04:00
  7416106321
• Fix similar Bindable-related crashes
  Dan Balasescu · 2024-09-25 20:59:35 +09:00
  fd4891cf31
• Fix replay analysis overlay not rotating with Barrel Roll enabled

  Closes https://github.com/ppy/osu/issues/29839.

  Bartłomiej Dach · 2024-09-11 15:54:30 +02:00
  4a39873e2a
• Fix Flashlight not appearing on top of bubbles from Bubbles mod

  Inadvertently regressed in 44d0dc6113.

  Bartłomiej Dach · 2024-09-11 15:54:07 +02:00
  b78ef81bf1
• Fix incorrect DifficultyBindable logic
  Bartłomiej Dach · 2024-07-30 08:39:20 +02:00
  6813f5ee0a
• Annotate ControlPoint and Mod for AOT trimming support
  Dan Balasescu · 2024-06-17 16:19:33 +09:00
  41446a08b6
• Fix cinema mod not hiding playfield skin layer
  Dean Herbert · 2024-05-27 14:52:28 +09:00
  11c3d11db9
• Revert "Temporary rollback of framework / SDL3"

  This reverts commit d7d569cf4e.

  Dean Herbert · 2024-05-22 16:29:39 +08:00
  d0b1ebff5a
• Temporary rollback of framework / SDL3
  Dean Herbert · 2024-05-21 14:36:16 +08:00
  d7d569cf4e
• Fix DifficultyBindable bound desync between maxValue and CurrentNumber.MaxValue
  Bartłomiej Dach · 2024-04-23 18:58:40 +02:00
  cbbf2dd158
• Fix 1px flashlight gaps when gameplay scaling mode is active

  Closes https://github.com/ppy/osu/issues/27522.
  
  Concerns mostly taiko and catch.
  
  Not much of a proper fix rather than a workaround but it is what it is.
  I tried a few other things, including setting `MaskingSmoothness = 0` on
  the scaling container itself, to no avail.

  Bartłomiej Dach · 2024-03-08 11:07:30 +01:00
  44d0dc6113