21 Commits

• Clean up ctors

  There were too many of them, and they were a bit twisty for my liking.

  Bartłomiej Dach · 2025-08-13 12:32:17 +02:00
  19f28813a0
• Expand xmldoc
  Bartłomiej Dach · 2025-08-13 12:24:40 +02:00
  076d6df78e
• use Prepend to resolve dotnet code style test
  Hivie · 2025-08-11 17:07:03 +01:00
  db1465ffdd
• fix missing param
  Hivie · 2025-08-11 16:48:52 +01:00
  c1a7285b8c
• one more constructor for tests that don't need a specified InterpretedDifficulty
  Hivie · 2025-08-11 16:48:25 +01:00
  c8cb167dbc
• add backwards-compatible ctor that allows creating context from a given working and playable single beatmap

  more productive than adjusting every single test

  Hivie · 2025-08-11 15:40:25 +01:00
  f0ca3304b8
• rework and improve BeatmapVerifierContext strtucture

  - uses ` VerifiedBeatmap` record for combining working and playable beatmaps
  - much better data access with all beatmapset diffs

  Hivie · 2025-08-11 14:56:35 +01:00
  cfb9649993
• handle single difficulty case more efficiently
  Hivie · 2025-08-09 14:14:51 +01:00
  eba31ab203
• add working beatmapset difficulties to verifier context
  Hivie · 2025-08-09 13:13:47 +01:00
  2559c7ac8b
• pass on BeatmapManager directly
  Hivie · 2025-08-09 11:59:20 +01:00
  172a48f1ac
• refactor verifier context to use a static factory method for creating instances with beatmap resolution
  Hivie · 2025-08-07 01:52:50 +01:00
  c5f4feb725
• address review

  - add TODO for refactoring verifier context ctor
  - call `GetPlayableBeatmap()` in verifier context ctor
  - filter diffs with relevant ruleset in check logic
  - fix tests

  Hivie · 2025-07-16 01:53:22 +01:00
  747bff1df9
• unlazy BeatmapsetDifficulties
  Hivie · 2025-07-14 13:53:01 +01:00
  806995e951
• include all of a beatmapset's diffs in the verifier context
  Hivie · 2025-07-13 01:53:07 +01:00
  f1eb7d367b
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Fix formatting of #nullable enable
  Naxess · 2021-05-14 03:38:35 +02:00
  a447f20095
• Add #nullable enable

  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Naxess · 2021-05-14 03:34:50 +02:00
  90e0b3374e
• Move IBeatmap arg into context
  Naxess · 2021-05-13 11:24:22 +02:00
  19800f5f7f
• Change interpreted difficulty from bindable to regular value

  There's no reason for why checks would need this to be bindable. A 1-directional binding is more appropriate.

  Naxess · 2021-05-13 09:00:30 +02:00
  b37cb3bdbe
• Add interpreted difficulty info to BeatmapVerifierContext

  Enables checks to make use of the difficulty level as shown in the settings UI.

  Naxess · 2021-05-12 02:30:21 +02:00
  64d96b06a6
• Replace IWorkingBeatmap arg with BeatmapVerifierContext in checks

  This simplifies passing of contextual information by enabling addition without needing to refactor lots of classes.
  
  See next commit for example.

  Naxess · 2021-05-12 02:29:18 +02:00
  c13b93e6f1