osu-lazer

Fix leak from polling chat client being initialised too early

This one is quite dumb.

`OsuGame` uses
[`loadComponentSingleFile`](https://github.com/ppy/osu/blob/15878f7f9fc7088494d3b66e98a7bc1004a1a06d/osu.Game/OsuGame.cs#L1228)
to load the `ChannelManager`. Importantly, this process does _not_ add
the component to any place in the hierarchy where it would normally be
disposed - this includes `InternalChildren`, but _also_ a lesser known
list of [currently-loading
components](https://github.com/ppy/osu-framework/blob/cfb0d7b4b673583f0cf56273e94352769aa5bc9a/osu.Framework/Graphics/Containers/CompositeDrawable.cs#L316-L323)
(those which have been sent through a `LoadComponentAsync` call).

The end result of this is that, `ChannelManager` creates the
`IChatClient` in its constructor, expecting to be able to dispose it,
but `Dispose` is never called!

And the failure case here is that `PollingChatClient` creates a
background task to continuously poll the API, unfortunately keeping a
reference to the rest of the world in the process.

Dan Balasescu · 2025-07-09 03:37:02 +09:00

02cb93d854

Fix typo in xmldoc

Dean Herbert · 2025-03-04 16:15:40 +09:00

4a16b4bd98

xmldoc everything

Bartłomiej Dach · 2024-01-25 14:47:29 +01:00

c463aa5ba1

Decouple notifications websocket handling from chat operations

This is a prerequisite for https://github.com/ppy/osu/pull/25480.

The `WebSocketNotificationsClient` was tightly coupled to chat specifics
making it difficult to use in the second factor verification flow.
This commit's goal is to separate the websocket connection and message
handling concerns from specific chat logic concerns.

Bartłomiej Dach · 2024-01-25 14:47:29 +01:00

de52f0a80c

Make chat commands case-insensitive

Would be nice if I accidentally have caps lock enabled and write "/HELP" it still works.

wooster0 · 2024-01-04 15:06:10 +09:00

cf5f0a2bdc

Actually apply new parameter

Dean Herbert · 2023-02-10 18:29:39 +09:00

4f7d26b776

Attempt to fix channel join / leave loop

I don't have a solid way to repro the issue, but this should hopefully
help in resolving it. Either way, I think this change brings more
correct behaviour (if a websocket message comes through that we have
left the channel, I don't believe we should be sending a request to
leave that channel again).

Dean Herbert · 2023-02-08 11:31:30 +09:00

ee65c65893

Fix channel manager test scene not waiting for notifications client connection

Salman Ahmed · 2023-01-12 23:14:23 +03:00

115cb0d297

Fix condition flipped

Salman Ahmed · 2023-01-09 21:33:08 +03:00

98390ea2a8

Remove flag causing intiialisation to only run once ever

Dean Herbert · 2023-01-09 16:38:37 +09:00

22d0b34623

Fix retry loop for channel initialisation resulting in request pile-up

Closes #22060.

Dean Herbert · 2023-01-09 16:15:31 +09:00

13c3d2c254

Use new ArgumentNullException.ThrowIfNull throw-helper API

Berkan Diler · 2022-12-22 21:27:59 +01:00

08d2fbeb8e

Immediately send ack request when joining new channels

Dan Balasescu · 2022-12-07 14:24:20 +09:00

8709b1f2ea

Partial everything

Dan Balasescu · 2022-11-27 00:00:27 +09:00

7bc8908ca9

Fix last silence ID being updated too often, causing most silences to be missed

Dean Herbert · 2022-11-13 00:10:06 +09:00

22d8a1160e

Simplify ack re-perform flow

Dean Herbert · 2022-11-12 23:02:37 +09:00

143c946128

Expand on why call needs to be made every 10 minutes

Dean Herbert · 2022-11-12 22:24:27 +09:00

bfb939cbd0

Update ack code after incorrect merge

Dean Herbert · 2022-11-12 21:41:10 +09:00

ace4099079

Merge branch 'master' into chat-silences

Dean Herbert · 2022-11-12 21:00:56 +09:00

dde09d409b

Lookup channels before calling HandleJoinedChannel()

Dan Balasescu · 2022-11-07 14:34:55 +09:00

67e99b5344

Fix channel lookup not considering missing ids

Dan Balasescu · 2022-11-07 12:25:23 +09:00

f931bdc5ff

Better handling for joining channels with only ID

Dan Balasescu · 2022-11-07 11:52:07 +09:00

cf03001c83

Handle channel parts

Dan Balasescu · 2022-11-07 11:36:55 +09:00

e3adf5a985

Fix chat connecting too early

Dan Balasescu · 2022-11-04 19:36:24 +09:00

f12ada9d92

Reschedule ack request on completion

Dan Balasescu · 2022-11-04 19:02:26 +09:00

1d2818dc70

Construct notifications client inside ChannelManager

Dan Balasescu · 2022-11-04 18:51:00 +09:00

fa18b5f701

Remove StartChat()/chat enablement

Dan Balasescu · 2022-11-04 18:48:34 +09:00

72745656e7

Fix handling of local echo deduplication

Dan Balasescu · 2022-11-04 18:44:22 +09:00

58396d49dc

Remove messages from silenced users

Dan Balasescu · 2022-11-02 17:13:14 +09:00

063a8bdf9e

Fix crossthread mutations

Dan Balasescu · 2022-10-28 18:37:43 +09:00

ab78cde2d4

Use polling connector in tests

Dan Balasescu · 2022-10-28 18:08:08 +09:00

169bcc2654

Adjust ChannelManager to use notifications client

Dan Balasescu · 2022-10-28 16:28:58 +09:00

2f731f86ba

Add logging around current channel changes and join requests

Tracking down a flaky test
(https://teamcity.ppy.sh/buildConfiguration/Osu_Build/553?hideProblemsFromDependencies=false&expandBuildTestsSection=true&hideTestsFromDependencies=false):

```csharp
TearDown : System.TimeoutException : "PM Channel 1 displayed" timed out
--TearDown
   at osu.Framework.Testing.Drawables.Steps.UntilStepButton.<>c__DisplayClass11_0.<.ctor>b__0()
   at osu.Framework.Testing.Drawables.Steps.StepButton.PerformStep(Boolean userTriggered)
   at osu.Framework.Testing.TestScene.runNextStep(Action onCompletion, Action`1 onError, Func`2 stopCondition)
--- End of stack trace from previous location ---
   at osu.Framework.Testing.TestSceneTestRunner.TestRunner.RunTestBlocking(TestScene test)
   at osu.Game.Tests.Visual.OsuTestScene.OsuTestSceneTestRunner.RunTestBlocking(TestScene test) in /opt/buildagent/work/ecd860037212ac52/osu.Game/Tests/Visual/OsuTestScene.cs:line 503
   at osu.Framework.Testing.TestScene.RunTestsFromNUnit()
------- Stdout: -------
[runtime] 2022-06-27 23:18:55 [verbose]: 💨 Class: TestSceneChatOverlay
[runtime] 2022-06-27 23:18:55 [verbose]: 🔶 Test:  TestKeyboardNextChannel
[runtime] 2022-06-27 23:18:55 [verbose]: Chat is now polling every 60000 ms
[runtime] 2022-06-27 23:18:55 [verbose]: 🔸 Step #1 Setup request handler
[runtime] 2022-06-27 23:18:55 [verbose]: 🔸 Step #2 Add test channels
[runtime] 2022-06-27 23:18:55 [verbose]: 🔸 Step #3 Show overlay with channels
[runtime] 2022-06-27 23:18:55 [verbose]: Unhandled Request Type: osu.Game.Online.API.Requests.CreateChannelRequest
[network] 2022-06-27 23:18:55 [verbose]: Failing request osu.Game.Online.API.Requests.CreateChannelRequest (System.InvalidOperationException: DummyAPIAccess cannot process this request.)
[runtime] 2022-06-27 23:18:55 [verbose]: Unhandled Request Type: osu.Game.Online.API.Requests.CreateChannelRequest
[network] 2022-06-27 23:18:55 [verbose]: Failing request osu.Game.Online.API.Requests.CreateChannelRequest (System.InvalidOperationException: DummyAPIAccess cannot process this request.)
[runtime] 2022-06-27 23:18:55 [verbose]: 🔸 Step #4 Select channel 1
[runtime] 2022-06-27 23:18:55 [verbose]: 🔸 Step #5 Channel 1 is visible
[runtime] 2022-06-27 23:18:55 [verbose]: 🔸 Step #6 Press document next keys
[runtime] 2022-06-27 23:18:55 [verbose]: 🔸 Step #7 Channel 2 is visible
[runtime] 2022-06-27 23:18:55 [verbose]: 🔸 Step #8 Press document next keys
[runtime] 2022-06-27 23:18:55 [verbose]: 🔸 Step #9 PM Channel 1 displayed
[network] 2022-06-27 23:18:55 [verbose]: Request to https://a.ppy.sh/587 failed with System.Net.WebException: NotFound.
[network] 2022-06-27 23:18:55 [verbose]: Request to https://a.ppy.sh/503 failed with System.Net.WebException: NotFound.
[runtime] 2022-06-27 23:19:05 [verbose]: 💥 Failed (on attempt 5,550)
[runtime] 2022-06-27 23:19:05 [verbose]: ⏳ Currently loading components (0)
[runtime] 2022-06-27 23:19:05 [verbose]: 🧵 Task schedulers
[runtime] 2022-06-27 23:19:05 [verbose]: LoadComponentsAsync (standard) concurrency:4 running:0 pending:0
[runtime] 2022-06-27 23:19:05 [verbose]: LoadComponentsAsync (long load) concurrency:4 running:0 pending:0
[runtime] 2022-06-27 23:19:05 [verbose]: 🎱 Thread pool
[runtime] 2022-06-27 23:19:05 [verbose]: worker:          min 1      max 32,767 available 32,766
[runtime] 2022-06-27 23:19:05 [verbose]: completion:      min 1      max 1,000  available 1,000
[runtime] 2022-06-27 23:19:05 [debug]: Focus on "ChatTextBox" no longer valid as a result of unfocusIfNoLongerValid.
[runtime] 2022-06-27 23:19:05 [debug]: Focus changed from ChatTextBox to nothing.
```

This kind of logging should be helpful:

```csharp
[runtime] 2022-06-28 04:59:57 [verbose]: 🔸 Step #5 Channel 1 is visible
[runtime] 2022-06-28 04:59:57 [verbose]: 🔸 Step #6 Press document next keys
[runtime] 2022-06-28 04:59:57 [verbose]: Current channel changed to #channel-2
[runtime] 2022-06-28 04:59:57 [debug]: Pressed (DocumentNext) handled by TestSceneChatOverlay+TestChatOverlay.
[runtime] 2022-06-28 04:59:57 [debug]: KeyDownEvent(PageDown, False) handled by ManualInputManager+LocalPlatformActionContainer.
[runtime] 2022-06-28 04:59:57 [verbose]: 🔸 Step #7 Channel 2 is visible
[runtime] 2022-06-28 04:59:57 [verbose]: 🔸 Step #8 Press document next keys
[runtime] 2022-06-28 04:59:57 [verbose]: Current channel changed to test user 685
[runtime] 2022-06-28 04:59:57 [debug]: Pressed (DocumentNext) handled by TestSceneChatOverlay+TestChatOverlay.
[runtime] 2022-06-28 04:59:57 [debug]: KeyDownEvent(PageDown, False) handled by ManualInputManager+LocalPlatformActionContainer.
[runtime] 2022-06-28 04:59:57 [verbose]: 🔸 Step #9 PM Channel 1 displayed
[runtime] 2022-06-28 04:59:57 [verbose]: 🔸 Step #10 Press document next keys
[runtime] 2022-06-28 04:59:57 [verbose]: Current channel changed to test user 218
```

Dean Herbert · 2022-06-28 14:00:30 +09:00

c1075d113f

Update parameter discards

Dean Herbert · 2022-06-24 21:26:19 +09:00

31a447fda0

Automated #nullable processing

Dan Balasescu · 2022-06-17 16:37:17 +09:00

f8830c6850

Ensure ChannelManager has access to API from point of construction

Closes https://github.com/ppy/osu/issues/18451.

Dean Herbert · 2022-06-08 19:15:23 +09:00

c661f2b059

Remove old chat overlay components

Jai Sharma · 2022-05-29 20:08:43 +01:00

8f596520f3

Rename dummy channel and move to a nested class inside the ChannelListing itself

Dean Herbert · 2022-05-19 19:26:14 +09:00

136ecb45e2

Re-add exception handling on PM message request failure

Jai Sharma · 2022-05-18 01:47:23 +01:00

dd4b11c593

Use dummy channel to show selector and remove ChannelListSelector

Add dummy channel `DummySelectorChannel` which should be set as the
current channel in the channel manager when the selector in the chat
overlay should be shown.

Refactors the `ChannelListItem` to not show mention pill and close
button when the channel is the dummy selector channel.

Ensure that the `ChannelList` selects the dummy channel on clicking the
selector item.

Removes `ChannelListSelector` as it is no longer needed.

Removes the `setCurrent` parameter from `ChannelManager.JoinChannel`
method as it is no longer needed.

Jai Sharma · 2022-05-15 20:24:49 +01:00

ae5b6c3e10

Add setCurrent param to ChannelManager.JoinChannel

Jai Sharma · 2022-05-11 22:51:15 +01:00

cced8609f6

Remove redundant parameter specification

Dean Herbert · 2022-02-24 16:02:16 +09:00

b4a54b38e7

Don't expose "mark as read" errors to the user via notifications

This can happen if the user leaves the channel before the request is
fired. You can't mark a channel as read when you're not in the channel.

Addresses https://github.com/ppy/osu/discussions/16973.

Dean Herbert · 2022-02-24 15:40:07 +09:00

3f6bdc5585

Reduce polling rate when idle even if HighPollRate is requested

Dean Herbert · 2022-01-13 17:33:55 +09:00

4012ef7e7b

Log chat polling rate changes

Dean Herbert · 2022-01-13 17:31:59 +09:00

46d2f305b5

Update usages to new naming

Dean Herbert · 2022-01-06 22:54:43 +09:00

00177a3ae1

Update continuation usages to use GetCompletedResult