20 Commits

• Do not add checkbox padding to the left of menu items if no item actually needs it

  RFC. As per
  https://discord.com/channels/188630481301012481/188630652340404224/1291346164976980009.
  
  The diff is extremely dumb but I tried a few smarter methods and they're
  either not fully correct or don't work. Primary problem is that menu
  items are mutable externally and there's no hook provided by the
  framework to know that items changed. One could probably be made but I'd
  prefer that this change be examined visually first before I engage in
  too much ceremony and start changing framework around.

  Bartłomiej Dach · 2024-10-03 15:36:53 +02:00
  29418226c0
• Decouple editor main menu items from DrawableOsuMenuItem

  It didn't ever really make sense for it to be sharing the implementation
  details of that (e.g. colouring of primary/dangerous actions), and with
  the hotkey display things got outright hacky, so I'm decoupling it
  entirely.

  Bartłomiej Dach · 2024-09-04 12:16:52 +02:00
  0c4f5bcdaa
• Integrate hotkey display into drawable menu items
  Bartłomiej Dach · 2024-09-04 11:58:10 +02:00
  3acc5fe5a0
• Refactor DrawableOsuMenuItem to remove a hack
  Bartłomiej Dach · 2024-09-04 11:55:43 +02:00
  3531f646f2
• Add chevron to distinguish all menus with submenus
  Joseph Madamba · 2024-04-24 00:19:10 -07:00
  f97c519451
• Fix potential crash when loading menu items due to cross-thread ops
  Dean Herbert · 2023-08-21 19:05:20 +09:00
  5f040a991b
• Remove usage of HasSubmenu

  Property has been removed in the appropriate framework-side PR and
  instead folded into `IsActionable`.
  
  See: https://github.com/ppy/osu-framework/pull/5658#discussion_r1114834647

  Bartłomiej Dach · 2023-05-20 18:02:12 +02:00
  8e0a97ca49
• Update in line with framework menu handling changes
  Dean Herbert · 2023-02-22 17:13:55 +09:00
  6e48860c79
• Partial everything
  Dan Balasescu · 2022-11-27 00:00:27 +09:00
  7bc8908ca9
• Add support for 'disabled' sample variation to HoverClickSounds
  Jamie Taylor · 2022-11-03 17:47:49 +09:00
  f1c17129eb
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Fix menu item width changing when hovered
  Bartłomiej Dach · 2022-02-02 21:23:35 +01:00
  b613aedeb8
• Remove unused params from BDL methods
  Susko3 · 2022-01-15 01:06:39 +01:00
  19467e58c1
• Update stand-alone usage of hover/select sounds in DrawableOsuMenuItem
  Dean Herbert · 2021-06-11 23:46:42 +09:00
  5887b4a27c
• Apply changes to UI components overriding functions with changing signatures
  Dean Herbert · 2021-02-22 19:01:42 +09:00
  1fd76ea3fb
• Initial sample + samplechannel rework
  smoogipoo · 2021-01-19 17:11:40 +09:00
  de9d075f94
• Add disabled state to menu items
  smoogipoo · 2020-04-15 16:17:17 +09:00
  102c1d9095
• Use framework extension method for FromHex
  Dean Herbert · 2020-03-11 10:18:41 +09:00
  ed837d3115
• Add basic implementation of a toggleable menu item
  smoogipoo · 2019-11-07 22:26:35 +09:00
  c3a3b4091b
• Move DrawableOsuMenuItem out of OsuMenu
  smoogipoo · 2019-11-07 16:03:35 +09:00
  20d6eceecf