3395 Commits

• Partial everything
  Dan Balasescu · 2022-11-27 00:00:27 +09:00
  7bc8908ca9
• Merge pull request #21356 from peppy/standardise-broken-storyboard-paths

  Add support for storyboards with incorrect path specifications (`\\` instead of `\`)

  Dan Balasescu · 2022-11-22 14:33:51 +09:00
  985781bc3b
• Merge pull request #21215 from jai-x/triangles-bundled-beatmap

  Add winner of Triangles mapping competition as a bundled beatmap

  Dean Herbert · 2022-11-21 16:22:23 +09:00
  2774c1ea49
• Add support for storyboards with incorrect path specifications (\\ instead of \)

  Closes https://github.com/ppy/osu/issues/21204.

  Dean Herbert · 2022-11-21 16:12:01 +09:00
  3da21e596a
• Fix beatmap card expanded content not blocking clicks from behind
  Joseph Madamba · 2022-11-13 08:18:44 -08:00
  4578a96813
• Add winner of Triangles mapping competition as a bundled beatmap

  https://osu.ppy.sh/home/news/2022-10-06-results-triangles

  Jai Sharma · 2022-11-12 17:48:40 +00:00
  c5cb4e4e7d
• Don't trim whitespace from variable keys / values
  Dean Herbert · 2022-11-08 13:30:11 +09:00
  064a245c50
• Decode variables earlier in flow in case they include indent logic

  Without this change, the `depth` calculation could be incorrect.

  Dean Herbert · 2022-11-08 13:29:42 +09:00
  b764d1bd04
• Remove equality comparison implementation from BeatmapCard

  This turned out to be a hurdle instead as it disallows adding two
  beatmap cards of equal beatmap, which, while being a good behaviour in
  client, makes tests more complicated to work.

  Salman Ahmed · 2022-11-04 19:27:20 +03:00
  bd512c4937
• Adjust padding to avoid overlap with card border when expanded
  Dean Herbert · 2022-11-03 14:03:28 +09:00
  07bfac40fa
• Scale in the background fill alongside the icon
  Dean Herbert · 2022-11-03 14:03:19 +09:00
  66a6084d3f
• Move hover layer behind icon

  Looked bad on the "already downloaded" state where the icon becomes
  black.

  Dean Herbert · 2022-11-03 13:56:07 +09:00
  df9f49eef2
• Merge branch 'master' into improve-beatmap-card-buttons
  Dean Herbert · 2022-11-03 13:53:29 +09:00
  fb0bc597a0
• Fix control points not being cloned when running beatmap conversion

  Closes #20994.
  
  I haven't considered how this affects performance of difficulty
  calculation or otherwise. Seems like a sane initial fix which we can
  iterate on going forward.
  
  I've tested using the scenario in the linked issue.
  
  I'm not going to add test coverage because
  [BeatmapConversionTest](https://github.com/ppy/osu/blob/master/osu.Game/Tests/Beatmaps/BeatmapConversionTest.cs)
  should correctly cover this scenario once we are serialising control
  points as well.

  Dean Herbert · 2022-11-01 17:42:09 +09:00
  978d15955c
• Merge branch 'master' into fix-filename-char-filtering
  Bartłomiej Dach · 2022-10-29 12:42:10 +02:00
  f775741d65
• Rename and add documentation to function
  Dean Herbert · 2022-10-28 18:04:28 +09:00
  66ed77ac91
• Remove various simple obsoletions
  Dean Herbert · 2022-10-28 13:20:58 +09:00
  42eafe318c
• Merge branch 'master' into fix-17143
  Dan Balasescu · 2022-10-25 13:44:58 +09:00
  6177df2a24
• Merge pull request #20809 from peppy/fix-taiko-broken-drum-roll-ticks

  Fix taiko drum roll ticks sometimes overflowing outside the drum roll itself

  Dan Balasescu · 2022-10-21 12:56:14 +09:00
  703a8afb11
• Fix incorrect fallback logic

  Regressed when attempting to share implementation of binary search.

  Dean Herbert · 2022-10-20 23:08:44 +09:00
  5c13c443ff
• Expose binary search methods publicly

  Co-authored-by: Dan Balasescu <smoogipoo@smgi.me>

  Dean Herbert · 2022-10-20 14:34:07 +09:00
  a754dc6d3b
• Update osu.Game/Beatmaps/ControlPoints/IControlPoint.cs

  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dean Herbert · 2022-10-20 08:06:05 +09:00
  78943a21d8
• Fix huge oversight causing test failures
  Dean Herbert · 2022-10-19 23:54:12 +09:00
  677b8d09f8
• Add and consume sample bank constants
  Dean Herbert · 2022-10-19 20:47:58 +09:00
  579d5b51eb
• Fix some older beatmaps having missing backgrounds

  Closes https://github.com/ppy/osu/issues/20824.
  
  Note that this will require a reimport of beatmaps as it is baked into the database. Probably not worth making a migration for at this point in time.

  Dean Herbert · 2022-10-19 16:01:10 +09:00
  59e2478b0e
• Standardise control point search logic in OverlappingScrollAlgorithm

  Was using a very local algorithm which I cannot guarantee is correct.
  I'd rather it just use the one used everywhere else.

  Dean Herbert · 2022-10-18 16:01:05 +09:00
  ec3761ced9
• Remove beatmap card background workaround to fix broken corners
  Salman Ahmed · 2022-10-13 16:09:54 +03:00
  ef72b66dad
• Make beatmap card icon buttons fill up to the area
  Salman Ahmed · 2022-10-13 16:09:54 +03:00
  6c316bcc9e
• Add hover box to beatmap card icon button
  Salman Ahmed · 2022-10-13 16:09:54 +03:00
  aa8040d696
• Move check to LegacyDifficultyControlPoint
  Dan Balasescu · 2022-10-13 15:05:15 +09:00
  338115ff6a
• Merge pull request #20641 from pfgithub/patch-fix-save-collections

  Preserve collections when saving a beatmap

  Dean Herbert · 2022-10-12 18:36:45 +09:00
  3da54814f8
• Introduce BpmMultiplierMania, remove after the fact clamps
  sw1tchbl4d3 · 2022-10-12 11:14:01 +02:00
  df0501235d
• Fix incorrect offset logic for beatmaps without a preview point specified
  Dean Herbert · 2022-10-12 14:47:37 +09:00
  db148d145b
• Rename parameter to read better
  Dean Herbert · 2022-10-12 14:46:35 +09:00
  721bfb5369
• Remove unused using statement
  Dean Herbert · 2022-10-11 16:23:05 +09:00
  9bab02fab4
• Add xmldoc and simplify calling
  Dean Herbert · 2022-10-11 15:50:02 +09:00
  eba3d37a11
• fix style
  pfg · 2022-10-10 21:48:41 -04:00
  e619c9c1e6
• Move 'transferCollections' to a shared location
  pfg · 2022-10-10 21:45:33 -04:00
  de8d485305
• Update WorkingBeatmap.cs
  NotGumballer91 · 2022-10-11 01:48:55 +08:00
  3cd6ce8e3f
• Update WorkingBeatmap.cs
  NotGumballer91 · 2022-10-10 21:03:11 +08:00
  749dc40062
• Update IWorkingBeatmap.cs
  NotGumballer91 · 2022-10-10 21:02:23 +08:00
  e3b405cc23
• Move clamps directly to the usages in the conversion algorithm
  sw1tchbl4d3 · 2022-10-10 09:36:18 +02:00
  f8036658c7
• Fix legacy BpmMultiplier clamp value
  sw1tchbl4d3 · 2022-10-09 11:25:47 +02:00
  e0904e263f
• Remove unnecessary '?'
  pfg · 2022-10-08 13:58:42 -04:00
  edec613724
• Preserve collections when saving a beatmap
  pfg · 2022-10-08 12:42:29 -04:00
  ff14453c2b
• Cleanup all other leftover binding instantiation
  o-dasher · 2022-09-25 16:02:40 -04:00
  feadac1f79
• Disable alpha component parsing in beatmap / skin colour sections
  Dean Herbert · 2022-09-21 16:11:41 +09:00
  992441b9de
• Catch against sqlite initialisation failures
  Dean Herbert · 2022-09-16 01:02:38 +09:00
  5ce67345ae
• Remove all EF models
  Dean Herbert · 2022-09-15 16:59:36 +09:00
  28b15e232d
• Add local sqlite initialisation to BeatmapUpdaterMetadataLookup for now
  Dean Herbert · 2022-09-15 16:58:58 +09:00
  0aa92c78ec