43 Commits

• Fix realm not being cached in beatmap carousel tests
  Dean Herbert · 2025-09-10 16:37:12 +09:00
  278b232318
• Hide object-typed CurrentSelection and expose strongly-typed alternatives instead
  Bartłomiej Dach · 2025-09-03 10:24:25 +02:00
  4a7ee6fafc
• Fix obvious test failures from using GroupedBeatmap in BeatmapCarousel.CurrentSelection
  Bartłomiej Dach · 2025-08-29 13:25:08 +02:00
  3f637db391
• Fix carousel selection not working

  Basically, `BeatmapCarousel.CurrentSelection`, which is
  magic-object-typed, can no longer use `BeatmapInfo` directly, it now
  must also use `GroupedBeatmap`.
  
  This spills out all the way into song select because of beatmap
  selection flows that require hookup from song select.

  Bartłomiej Dach · 2025-08-29 13:25:01 +02:00
  d4b357dfa0
• Apply most trivial adjustments to tests after beatmap model replacement
  Bartłomiej Dach · 2025-08-29 13:22:37 +02:00
  e98579d3af
• Make grouping by collections and rank achieved testable without involving realm
  Bartłomiej Dach · 2025-08-29 13:12:12 +02:00
  d304a31757
• Apply suggested rename
  Bartłomiej Dach · 2025-08-29 09:58:56 +02:00
  526ee32268
• Adjust tests to new beatmap set model usage in carousel
  Bartłomiej Dach · 2025-08-28 13:09:11 +02:00
  6ba72fa481
• Support beatmap sets being split apart by the active group mode in beatmap carousel
  Bartłomiej Dach · 2025-08-28 13:09:08 +02:00
  8dd131f17e
• Fix flaky carousel test due to out of range async filter operation

  See
  https://github.com/ppy/osu/actions/runs/15868654672/job/44740248052?pr=33873#step:5:49.

  Dean Herbert · 2025-06-25 15:45:41 +09:00
  f1e23595e7
• Merge pull request #33773 from peppy/fix-carousel-random-not-respecting-group

  SongSelectV2: Refine random selection to currently open group (and support difficulty split panels better)

  Bartłomiej Dach · 2025-06-24 14:37:09 +02:00
  a797c46d75
• SongSelectV2: Fix random selection not working as expected when displaying individual difficulties

  Previously, random selection would always be done at a *set* level. The
  final operation of a random action would be "select the user's
  recommended difficulty from this randomly selected set".
  
  This makes no sense when sets are not grouped together at song select.
  In fact, it is completely broken with the previous commit which adds
  group-isolated random support – if we're grouping by difficulty and the
  user's recommendation is not in the current group it would throw the
  user into another group unexpectedly.
  
  This fixes the issue by splitting out the random implementation into two
  separate pathways depending on the carousel display mode.

  Dean Herbert · 2025-06-19 17:29:41 +09:00
  f676206331
• Add support for toggling current group expansion using shift-enter

  Closes https://github.com/ppy/osu/issues/33617.

  Dean Herbert · 2025-06-12 20:36:02 +09:00
  52ba22ca1f
• Ensure filtering is always waited on after a sort/filter change in tests
  Dean Herbert · 2025-06-12 19:45:06 +09:00
  d592b984e3
• Add all beatmaps in one go in tests to avoid hundreds of callbacks

  Just makes debugging easier.

  Dean Herbert · 2025-06-12 19:45:06 +09:00
  054544818c
• Give better feedback from test assertion

  There's a flaky test and currently the fail output it not really
  helpful. This makes it slightly more relevant.

  Dean Herbert · 2025-06-12 19:45:06 +09:00
  7dba17f6b8
• Move and rename next/previous "group" selection keybindings to make way for group-specific bindings
  Dean Herbert · 2025-06-11 21:02:52 +09:00
  b9e1b6969e
• Fix missing ConfigureAwait causing Items to potentially be copied on non-update thread
  Dean Herbert · 2025-05-30 19:39:49 +09:00
  7025c2cf2f
• Merge pull request #33332 from peppy/song-select-v2-fix-double-filter

  SongSelectV2: Fix carousel filtering twice on entering song select

  Bartłomiej Dach · 2025-05-30 12:29:32 +02:00
  559ddd1ec9
• Use nullable Criteria instead of ctor flag
  Dean Herbert · 2025-05-30 18:15:27 +09:00
  5bf235f2dc
• Add failing test showing double filter on entering song select
  Dean Herbert · 2025-05-30 16:03:31 +09:00
  666d9b153c
• Add failing tests showing carousel incorrectly requesting start when traversing single items
  Dean Herbert · 2025-05-30 15:50:19 +09:00
  9b77b958e0
• Merge branch 'master' into song-select-v2-fix-loading-overlay
  Bartłomiej Dach · 2025-05-28 13:16:30 +02:00
  bbeb1be295
• Merge branch 'master' into song-select-v2-random
  Dean Herbert · 2025-05-28 20:06:50 +09:00
  0b527ce14b
• SongSelectV2: Fix carousel loading state looking out of place
  Dean Herbert · 2025-05-28 18:31:37 +09:00
  7a4d9c7c9a
• Rename and expose BeatmapCarousel selection handling variables

  For test usage and consistency.

  Dean Herbert · 2025-05-28 18:15:39 +09:00
  ef39b8d9c0
• SongSelectV2: Add back basic random selection support

  This is a minimal implementation in order to keep moving forward.
  
  For simplicity I've copied over the old implementation verbatim. Note
  that this is beatmap*set* based randomisation, which means that when
  panels are split up by difficulty, it is still randomising by set (with
  the difficulty choice being left up to the user recommendation system).
  I think this is what we want, but if it isn't, any changes can come
  later.

  Dean Herbert · 2025-05-28 16:54:11 +09:00
  1b56ce9a39
• Merge pull request #33287 from peppy/fix-selection

  SongSelectV2: Fix carousel not correctly handling traversal when current selection is filtered away

  Bartłomiej Dach · 2025-05-27 12:33:04 +02:00
  e5ba517f9c
• Update test helper methods to use non-reference comparison

  This isn't strictly required, but there should be no gaurantee or
  requirement that the references are equal in these checks, so it's best
  change them as such.

  Dean Herbert · 2025-05-27 18:32:56 +09:00
  8ccd6a4e4a
• Fix panels not updating visually when changing between difficulty sort modes

  I'm going with the simplest approach for this for now. If there's a
  discrepancy, clear all panels and start from scratch.
  
  Closes #33204.

  Dean Herbert · 2025-05-27 17:21:15 +09:00
  907d680188
• Add basic "eager" selection to ensure something is selected at song select after import
  Dean Herbert · 2025-05-26 19:32:32 +09:00
  4a03240ee6
• Hook up carousel to song select to global beatmap
  Dean Herbert · 2025-05-26 19:32:31 +09:00
  c1e1bfde0a
• Code quality fixes
  Dean Herbert · 2025-05-22 22:41:11 +09:00
  41feba120b
• Make class partial
  Bartłomiej Dach · 2025-05-14 12:40:40 +02:00
  c7bfd2a52e
• Add test coverage for beatmap carousel v2 sort support
  Dean Herbert · 2025-05-14 19:21:57 +09:00
  073b1810b3
• Allow tests to accedss CarouselItems post filter operation
  Dean Herbert · 2025-05-14 19:21:57 +09:00
  8e15af2b2d
• Expose a way of knowing when carousel's displayed items are updated
  Dean Herbert · 2025-05-09 14:49:38 +09:00
  a957f41ffc
• Add SortAndGroupBy method to simplify usages
  Salman Alshamrani · 2025-05-07 10:28:09 +03:00
  8775731c24
• Expose matched beatmaps count from BeatmapCarousel
  Salman Alshamrani · 2025-05-07 10:22:20 +03:00
  1c6e998c95
• Improve count check test assertions
  Salman Alshamrani · 2025-05-07 09:09:40 +03:00
  725187245a
• Support mutating existing active filter criteria in carousel tests

  Allows maintaining sorting mode while modifying other filter criterias,
  thus simplifying some tests.

  Salman Alshamrani · 2025-05-05 09:46:42 +03:00
  540cfc92da
• WaitForSorting -> WaitForFiltering
  Salman Alshamrani · 2025-05-05 09:46:06 +03:00
  cc46cbf780
• Rename song select v2 classes and namespaces

  This aims to bring some conformity to naming to make it easier to
  understand component structure for new components.
  
  Renames are pulled out of the song select v2 changes and are more
  relevant there due to many new classes being added.
  
  - `V2` suffix is dropped, with v2 components being moved to a relevant V2 namespace.
  - Related classes have a prefix of the area they are used.
  - Experimenting with using partial/nested classes in the song select v2 implementation.
    Not committing to this yet but want to see how it plays out.
  - Moved base carousel components to a generic namespace to avoid confusion with actual beatmap carousel implementation.

  Dean Herbert · 2025-04-16 18:34:53 +09:00
  0aff50fbf5