120 Commits

• Remove BeatmapCarousel testing backdoor
  Dean Herbert · 2024-12-11 16:28:51 +09:00
  a868c33380
• Add failing test case
  Bartłomiej Dach · 2024-09-08 16:06:35 +02:00
  134bcc85b7
• Add failing test case for difficulty splitting
  Dean Herbert · 2024-09-07 22:14:02 +09:00
  3e3ee3757c
• Tidy up test beatmap loading
  Dean Herbert · 2024-08-28 23:28:44 +09:00
  e04b5bb3f2
• Always debounce external Filter requests (except for tests)

  The only exception to the rule here was "when screen isn't active apply
  without debounce" but I'm not sure we want this. It would cause a
  stutter on returning to song select and I'm not even sure this is a
  common scenario.
  
  I'd rather remove it and see if someone finds an actual case where this
  is an issue.

  Dean Herbert · 2024-08-28 19:13:50 +09:00
  dd4a1104e4
• Allow running initial filter criteria asynchronously

  This reverts a portion of https://github.com/ppy/osu/pull/9539.
  
  The rearrangement in `SongSelect` is required to get the initial filter
  into `BeatmapCarousel` (and avoid the `FilterChanged` event firing,
  causing a delayed/scheduled filter application).

  Dean Herbert · 2024-08-28 19:13:50 +09:00
  336abadbd1
• Add failing test case for desired artist sort behaviour
  Bartłomiej Dach · 2024-03-22 08:41:08 +01:00
  e2df098184
• Adjust test to fail
  Bartłomiej Dach · 2024-02-21 11:42:34 +01:00
  259be976e8
• Fix code quality inspection
  Bartłomiej Dach · 2023-12-26 12:20:17 +01:00
  30b5b36f1d
• Add test coverage
  Nathan Tran · 2023-12-26 00:57:06 -08:00
  4e3bdb2b56
• Assign random statuses to beatmap sets in carousel test

  Just to have visual coverage of the statuses before fixing them not
  propagating to split difficulty mode.

  Bartłomiej Dach · 2023-09-06 08:25:07 +02:00
  b884f1af4a
• Adjust test to actually test diff splitting
  Dean Herbert · 2023-08-25 18:09:51 +09:00
  84f4fab9cf
• Fix typo in test step

  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dean Herbert · 2023-08-24 18:30:59 +09:00
  b471ab07a6
• Fix one more test probably going off-screen
  Dean Herbert · 2023-08-24 13:31:33 +09:00
  ba70d48d2c
• Limit set/diff count in test to better fit on screen
  Dean Herbert · 2023-08-24 03:32:12 +09:00
  4881130cae
• Add coverage of selection retention when difficulties are split out
  Dean Herbert · 2023-08-23 19:44:42 +09:00
  5eac604f8b
• Add test coverage of add/remove when difficulties are split out
  Dean Herbert · 2023-08-23 19:43:08 +09:00
  a64381f855
• Update test to match new behaviour
  Dean Herbert · 2023-08-23 19:38:18 +09:00
  5555f73e97
• Add failing test case
  Salman Ahmed · 2023-06-15 11:21:52 +03:00
  b9543f4fdd
• Ensure TestBeatmapCarousel.Items only returns actually visible items (and in correct order)

  Turns out that items could be in an order that isn't the same as how
  things look on the carousel, so this change ensures that for testing
  purposes they are sorted by Y position.
  
  Also uses the `CarouselItem.Visible` flag to ensure that we don't have
  to wait for drawable fade transitions after a filter operation.

  Dean Herbert · 2023-03-03 17:18:34 +09:00
  a14dede036
• Add better coverage and more comments explaining the structure of test setup
  Dean Herbert · 2023-03-03 17:18:14 +09:00
  7a092ea995
• Don't filter away results with missing data when using "Date Submitted" or "Date Ranked" sort modes

  From a user's perspective, changing a sort / order mode shouldn't filter
  away results, but we were doing this.
  
  In terms of UX expectations, in stable this kind of scenario would
  results in a group being added to the end of son select with "Not
  ranked" or "Unknown". I think we should aim to match this eventually.

  Dean Herbert · 2023-03-03 16:36:18 +09:00
  82293c0c86
• Remove OnlineID sort consideration
  Dean Herbert · 2023-01-18 19:21:02 +09:00
  3b27774561
• Add test coverage of carousel sort expectations

  This covers the fail case of removing and adding items (see
  https://github.com/ppy/osu/issues/21926) but also covers the proposed
  forward implementation, which now considers `DateAdded` and `OnlineID`.

  Dean Herbert · 2023-01-17 16:40:25 +09:00
  92fc439f82
• Fix potential nullref in certain beatmap carousel tests
  Salman Ahmed · 2023-01-13 19:42:09 +03:00
  e6ff262521
• remove unnecessary usages of nullable forgiveness, add asserts for debugging
  mk56-spn · 2023-01-09 18:36:55 +01:00
  69260ca3c3
• Fix errors in test
  mk56-spn · 2023-01-08 19:18:28 +01:00
  a32c4a64e7
• Partial everything
  Dan Balasescu · 2022-11-27 00:00:27 +09:00
  7bc8908ca9
• Add failing test case
  Bartłomiej Dach · 2022-11-20 10:07:32 +01:00
  b3667821eb
• Move test to improve diff readability
  Endrik Tombak · 2022-10-24 22:55:09 +03:00
  b95091fbb0
• Write new tests
  Endrik Tombak · 2022-10-24 22:50:56 +03:00
  9def12c60b
• Add missing null check in BeatmapCarousel tests
  Dean Herbert · 2022-09-07 16:22:11 +09:00
  b50116e9e4
• Add failing test of date submitted search failing
  Dean Herbert · 2022-09-01 19:59:27 +09:00
  148e487c02
• Fix some BeatmapCarousel tests not correctly reinitialising local data per run

  Closes https://github.com/ppy/osu/issues/19949.

  Dean Herbert · 2022-08-25 14:03:26 +09:00
  1032b2a68c
• Add failing test case
  Salman Ahmed · 2022-08-01 18:43:01 +03:00
  682192dbd7
• Improve existing test coverage to cover order changes from other sort modes
  Salman Ahmed · 2022-07-26 10:24:51 +03:00
  91ffa7007f
• Move test to stand-alone class and add full ui testing
  Dean Herbert · 2022-07-19 18:50:27 +09:00
  f6de76e057
• Add beatmap update button
  Dean Herbert · 2022-07-19 18:29:36 +09:00
  eaf4f6dbb7
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Add test coverage checking carousel panel visual state after ruleset filter change
  Dean Herbert · 2022-02-11 15:21:01 +09:00
  f012f64fd1
• Fix TestSelectingFilteredRuleset failing under visual tests due to using local database
  Dean Herbert · 2022-02-03 16:04:05 +09:00
  41aa4b8cca
• Merge branch 'master' into song-select-scroll-position-during-delete
  Bartłomiej Dach · 2022-01-27 20:46:19 +01:00
  04d6ca59a3
• Add failing test coverage showing carousel deletions don't keep scroll position
  Dean Herbert · 2022-01-27 16:52:02 +09:00
  f2cecad83b
• Update all usages of RulesetID and Ruleset.ID to use Ruleset.OnlineID
  Dean Herbert · 2022-01-27 15:38:03 +09:00
  5288eedd31
• Remove all usage of AuthorString
  Dean Herbert · 2022-01-18 23:30:40 +09:00
  67bf95bc91
• Remove outdated comment
  Dean Herbert · 2022-01-14 21:40:35 +09:00
  9900a3f408
• Fix beatmap carousel test failures
  Dean Herbert · 2022-01-12 17:49:10 +09:00
  41d90cd0b5
• Fix multiple tests via null checks and changing ToLive to Detach

  flow

  Dean Herbert · 2022-01-12 17:00:17 +09:00
  e74a5022c9
• "Update" BeatmapCarousel
  Dean Herbert · 2022-01-12 17:00:16 +09:00
  3152d2d8a0
• Miscellaneous fixes that don't fit elsewhere
  Dean Herbert · 2022-01-12 16:39:36 +09:00
  e6fdd0e969