26 Commits

• Add failing test case
  Salman Alshamrani · 2025-08-14 13:47:58 +03:00
  69b6166e58
• Update test coverage
  Salman Alshamrani · 2025-08-12 11:05:53 +03:00
  cd416214f2
• Add test coverage
  Salman Alshamrani · 2025-08-11 10:37:31 +03:00
  b351f0187d
• Merge pull request #33530 from JackArmstrong22/fix-negative-zero-audio-offset

  Fix beatmap offset control potentially reporting negative zero

  Dean Herbert · 2025-07-23 16:54:33 +09:00
  9f6b156d0c
• Add test coverage of incorrect formatting output

  Fix a cosmetic UI issue where -0.0 is displayed when clicking the Calibrate using last play button.
  
  Removed changes to AudioOffsetAdjustControl and added check to ToStandardFormattedString for if floatValue is 0

  Dean Herbert · 2025-07-23 14:47:38 +09:00
  44531794a1
• Adjust tests based on changed behaviour

  Calibration no longer goes away on missing / invalid scores.

  Dean Herbert · 2025-06-11 22:47:47 +09:00
  90877a079c
• Adjust commentary to not suck

  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dean Herbert · 2025-06-11 15:55:08 +09:00
  38ad48bb35
• Allow using previous valid score for offset calibration when subsequent retries are too short

  As proposed in https://github.com/ppy/osu/discussions/33572.
  
  Note that this won't work if you leave to song select. We could make
  that work but it would require further global faffing and I don't think
  it's worth the effort.

  Dean Herbert · 2025-06-11 15:26:02 +09:00
  cdb2f216f2
• Adapt TestNotEnoughTimedHitEvents with new minimum hit amount
  sineplusx · 2025-03-29 20:43:59 +01:00
  403b24ef9b
• Add test covering required behaviour

  See https://github.com/ppy/osu/issues/30885.

  Dean Herbert · 2025-01-02 16:20:09 +09:00
  2d3595f768
• Add failing test case
  Bartłomiej Dach · 2024-11-14 13:07:11 +01:00
  bbe2c87837
• Add test coverage of beatmap offset edge case failure
  Dean Herbert · 2024-09-05 19:04:52 +09:00
  791ce218fc
• Apply NRT to test scene
  Dean Herbert · 2024-06-15 17:26:57 +08:00
  6bd633f8ce
• Add failing test
  Shiumano · 2024-06-14 20:07:27 +09:00
  bfca64a98e
• Migrate BeatmapOffsetControl to use session static directly
  Bartłomiej Dach · 2023-12-27 19:19:27 +01:00
  1b7af989ec
• Fix code quality inspection
  Bartłomiej Dach · 2023-06-06 21:11:24 +02:00
  f51b8a6a05
• Add test coverage
  Bartłomiej Dach · 2023-06-06 20:36:44 +02:00
  7694aa7219
• Partial everything
  Dan Balasescu · 2022-11-27 00:00:27 +09:00
  7bc8908ca9
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Switch step to Until steps due to AddOnce firing logic
  Dean Herbert · 2022-03-06 01:50:25 +09:00
  0e8ad4b143
• Fix calibrating offset from previous non-zero offset not applying adjustment correctly
  Dean Herbert · 2022-03-04 13:25:14 +09:00
  e09dd7d8fe
• Fix calibration button disabled state not checking in corrrect direction
  Dean Herbert · 2022-03-02 14:36:15 +09:00
  3cbcb702f6
• Fix calibration being back-to-front
  Dean Herbert · 2022-03-01 20:41:54 +09:00
  222f50d211
• Don't display calibration options when the previous play was too short to be useful
  Dean Herbert · 2022-03-01 20:12:59 +09:00
  4d9efe771b
• Add full testing flow for BeatmapOffsetControl
  Dean Herbert · 2022-03-01 18:44:15 +09:00
  fab09575ec
• Add basic beatmap offset adjustment control
  Dean Herbert · 2022-03-01 18:44:15 +09:00
  1847f69bf9