39 Commits

• Store pause timestamps (rounded to ms) instead of general count
  Bartłomiej Dach · 2025-07-22 09:26:12 +02:00
  d8900defd3
• Store score pause count to replays
  Bartłomiej Dach · 2025-07-07 11:00:31 +02:00
  2b6dab1e9d
• Move BeatmapVersion from BeatmapInfo to IBeatmap

  Closes https://github.com/ppy/osu/issues/32420.
  
  The failure cause here is that in editor the beatmap version for the
  beatmap affected (or... any beatmap, really), is 0 (ZERO). That is
  probably a regression from https://github.com/ppy/osu/pull/32315, but
  like... can we universally agree that calling that change "a regression"
  in any capacity is dumb? Like what was that code *doing* playing dumb
  reference games and copying stuff into an arbitrary instance that could
  get or not get used later on? And now you have a 50/50 chance of
  accessing the *correct* model's field, depending on whether you go via
  `BeatmapInfo` or `Beatmap.BeatmapInfo`?
  
  Moving the field to `IBeatmap`, i.e. what is by now - by consensus,
  since https://github.com/ppy/osu/pull/28473 - supposed to be the "decoded
  and materialised" beatmap, fixes this issue.
  
  I probably should have done this as part of
  https://github.com/ppy/osu/pull/28473 but it slipped my mind. Probably
  for the better too because this change has rather large chances of
  breaking stuff so maybe better to examine it in isolation (via diffcalc
  runs or whatever).
  
  For added humour points, you'd say that the field on `BeatmapInfo` was
  not `[Ignore]`d, so this is a realm schema change, right? No. As far as
  I can tell, it's not. I opened realm studio and `BeatmapVersion` *is not
  a listed column` on `Beatmap` models.
  
  I'm also not gonna get into the fact that I think `EditorBeatmap` doing
  dumb games with juggling two `BeatmapInfo` references since
  https://github.com/ppy/osu/pull/15075 is bad, because I don't think I
  have the mental capacity to hotfix this by going down that train of
  thought.

  Bartłomiej Dach · 2025-03-17 15:04:48 +01:00
  91f3be5fea
• Fix another test

  The last two PRs didn't interact well together.

  Dan Balasescu · 2024-08-13 17:18:11 +09:00
  58354e3e68
• Update mania replay decode test to include 18K keypress
  clayton · 2024-08-11 09:45:42 -07:00
  2233602184
• Merge branch 'master' into negative-frame-handling
  Dan Balasescu · 2024-05-29 13:14:59 +09:00
  655b0f5343
• Merge branch 'master' into pre-mod-multiplier-score
  Bartłomiej Dach · 2024-05-08 13:39:44 +02:00
  c9414da5d4
• Fix test failure
  Bartłomiej Dach · 2024-05-08 09:45:52 +02:00
  7551cf01d1
• Decode user ID from score if available
  Bartłomiej Dach · 2024-05-06 12:28:13 +02:00
  554ead0d9d
• Fix test failure
  Bartłomiej Dach · 2024-05-02 08:02:55 +02:00
  1eac34667d
• Export and import TotalScoreWithoutMods to replays (or recalculate if it missing)
  Bartłomiej Dach · 2024-04-17 09:08:15 +02:00
  2f1a4cdaa4
• Add failing tests
  Bartłomiej Dach · 2024-03-21 20:57:04 +01:00
  5f7028b574
• Merge branch 'master' into negative-frame-handling
  Bartłomiej Dach · 2024-03-21 16:45:35 +01:00
  c47463ee0e
• Add failing encode test
  Bartłomiej Dach · 2024-03-04 11:48:49 +01:00
  af2b80e030
• Update assertions to match expected behaviour
  Bartłomiej Dach · 2024-01-22 20:52:54 +01:00
  d53fb5a165
• Add another failing tests covering recomputation of ranks
  Bartłomiej Dach · 2024-01-22 20:01:18 +01:00
  3f31593a19
• Adjust existing test to fail
  Bartłomiej Dach · 2024-01-22 20:00:00 +01:00
  81a02665b6
• Update test in line with new rank definitions always being applied
  Dean Herbert · 2024-01-22 21:43:32 +09:00
  bb1eab5844
• Add failing test coverage
  Bartłomiej Dach · 2024-01-16 22:38:52 +01:00
  1075b87fb8
• Add test coverage of ClientVersion serialisation
  Bartłomiej Dach · 2023-12-21 13:06:42 +01:00
  5ff95db02c
• Add test coverage for parsing new online ID
  Bartłomiej Dach · 2023-10-26 12:39:07 +02:00
  dbb69419e6
• Add failing test for legacy online ID decoding
  Bartłomiej Dach · 2023-10-16 11:20:02 +02:00
  bfcb4f4f2d
• fix legacy score decode tests for negative frame
  Liam DeVoe · 2023-07-27 16:34:18 -04:00
  61760f614a
• Add test
  Dan Balasescu · 2022-12-07 15:07:39 +09:00
  49df05dd07
• Decode Geki/Katu from legacy taiko scores into LargeBonus
  Dan Balasescu · 2022-09-07 00:12:34 +09:00
  7c0e99c5a8
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Split out shared code for encode-decode cycle (and remove unrelated culture set)
  Dean Herbert · 2022-03-24 17:00:49 +09:00
  d6fc53579e
• Use a constant for the early version timing offset
  Dean Herbert · 2022-03-24 16:43:41 +09:00
  a7554dcdf7
• Add test coverage of decode specifically
  Dean Herbert · 2022-03-24 16:39:56 +09:00
  2efae031c9
• Add test coverage ensuring offsets are correct before and after legacy replay encode
  Dean Herbert · 2022-03-24 16:34:21 +09:00
  59a7eb5322
• Add test coverage of all mod storages containing classic mod post-import
  Dean Herbert · 2022-01-19 14:34:27 +09:00
  bb6f40d16e
• Remove all usage of BaseDifficulty (and access Difficulty instead)
  Dean Herbert · 2022-01-18 22:57:39 +09:00
  7f65f3a47f
• Remove MD5 comparison also
  Dean Herbert · 2022-01-10 12:17:32 +09:00
  3d14511286
• Fix LegacyScoreDecoderTest incorrectly comparing unset beatmap IDs

  This has been wrong from the outside, but hidden by the fact that the
  default values are equal. I've changed to MD5Hash which actually asserts
  that the correct beatmap has likely arrived.
  
  Found this in my realm changes, where it fails due to the beatmap ID
  being a differing Guid in each case.

  Dean Herbert · 2022-01-08 15:28:13 +09:00
  f6f24220c2
• Move test ScoreInfo creation to TestResources

  The main goal here is to remove the inheritance, since realm doesn't
  like that. Unfortunate that we can't use object initialisers in a few of
  these places, but no real way around that.

  Dean Herbert · 2021-12-13 16:34:50 +09:00
  b0d14526ea
• Add failing test case
  Bartłomiej Dach · 2021-12-04 17:13:43 +01:00
  ea6766d940
• Update all actual usages of RulesetInfo.ID to use OnlineID instead
  Dean Herbert · 2021-11-24 15:50:26 +09:00
  bbd3ea5b77
• Add assertions to existing test to cover bug
  Bartłomiej Dach · 2020-08-27 18:18:30 +02:00
  37387d7741
• Add failing test case
  Bartłomiej Dach · 2020-08-27 18:06:59 +02:00
  9d70b4af09