osu-lazer

Add increase visibility setting for taiko hidden (#34879 )

Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

Krystian Ptach-Żurakowski · 2025-09-02 10:10:58 +09:00

f9e89afe03

Merge pull request #34761 from frenzibyte/fix-flashlight

Fix flashlight not always matching gameplay scaling

Bartłomiej Dach · 2025-08-25 12:03:58 +02:00

6e8246b539

Fix taiko flashlight applying aspect ratio twice

Salman Alshamrani · 2025-08-21 19:03:43 +03:00

f374af7ce7

Add and use new mod icon assets

Bartłomiej Dach · 2025-08-21 09:00:44 +02:00

92016a7d9b

more check refactors to cover the context changes

Hivie · 2025-08-11 16:05:52 +01:00

fb61f00466

initial pass on updated verifier context usage across most checks

Hivie · 2025-08-11 14:57:14 +01:00

fd6cf680b9

mark timing checks as set-level

Hivie · 2025-08-06 11:42:57 +01:00

af8b133019

comment

Hivie · 2025-08-05 10:02:26 +01:00

85a7504ffc

add taiko check for inconsistent barline omission

Hivie · 2025-08-05 09:59:44 +01:00

7c6b2dd230

Adjust some formatting to read better

Dean Herbert · 2025-08-04 18:20:56 +09:00

af290ddc0c

Fix oversight from refactoring

Bartłomiej Dach · 2025-08-01 13:27:58 +02:00

db05adbdc0

Clarify comment further

Bartłomiej Dach · 2025-08-01 12:18:16 +02:00

2f5d89590f

Simplify redundant code

Bartłomiej Dach · 2025-08-01 12:12:20 +02:00

b22ca878ba

Adjust displayed precision to match stable

Bartłomiej Dach · 2025-08-01 12:00:25 +02:00

21ef184ae3

Show effect of beatmap attributes on gameplay metrics in taiko

Bartłomiej Dach · 2025-08-01 11:07:52 +02:00

1f28add95a

Fix code quality

Bartłomiej Dach · 2025-07-30 15:00:55 +02:00

640fe5752d

Refactor beatmap attribute methods

This change refactors `GetAdjustedDisplayDifficulty()` and
`GetBeatmapAttributesToDisplay()` in two ways:

- Both methods now accept `IBeatmapInfo` instead of
  `IBeatmapDifficultyInfo`. This is done in order to make mania key
  count display to work, wherein `IBeatmapDifficultyInfo` is not enough
  to calculate the final key count.

- `GetAdjustedDisplayDifficulty()` now applies all
  `IApplicableToDifficulty` mods itself. I did this after noticing that
  every real consumer of this method had to do that themselves for very
  little reason.

Bartłomiej Dach · 2025-07-30 14:06:34 +02:00

7c4dd812b6

Add new ruleset method responsible for displaying beatmap attributes consistently everywhere

The intention is to use this in every place that wishes to display
beatmap attributes (and also remove a bunch of local hack-arounds for
mania, etc.)

Bartłomiej Dach · 2025-07-30 13:41:19 +02:00

e2a454ae00

Merge pull request #34181 from Hiviexd/verify/check-lowest-diff-drain

Add verify check for lowest diff drain/play time requirements

Bartłomiej Dach · 2025-07-22 08:38:59 +02:00

c408d60fbe

use TimeSpan for defining thresholds

Hivie · 2025-07-21 12:32:45 +01:00

86369ab403

Attempt to properly quantify the impact of mania Hard Rock / Easy mod application on overall difficulty

In stable mania, Hard Rock and Easy mods do not work the same way as
they do on all of the rulesets. The difference is that mania HR and EZ,
rather than apply a multiplier to the map's original Overall Difficulty,
apply multipliers to *the durations of hit windows themselves*.

Prior to the last release, lazer was oblivious to this reality and just
treated mania HR / EZ as it did every other ruleset. Last release, for
the sake for gameplay parity across rulesets, the mods in question were
adjusted to match stable, but in the process, it started looking like HR
/ EZ did not change OD anymore.

The problem is that they do, but applying a multiplier to the map's OD
and applying a multiplier to the hit window duration is not the same
thing. The second thing is actually *much harsher* in magnitude, to the
point where applying HR to any map is almost guaranteed to exceed "the
effective OD" of 10, and applying EZ to any map is almost guaranteed to
result in "negative effective OD".

This change attempts to convey that reality by displaying "effective
OD", similar to what's already done in other rulesets when rate-changing
mods are active. Note that the values this will display *do not match*
stable *and that is correct*, because stable song select *lies* about
the actual impact on OD by just assuming it can treat all rulesets in
the same way.

---

Would close https://github.com/ppy/osu/issues/34150 I guess.

And yes I would like *all of the above* to land on the changelog if
possible if this is merged.

For further convincing that this makes any semblance of sense please see
the following: https://www.desmos.com/calculator/yigt7jycdv

Bartłomiej Dach · 2025-07-15 09:40:55 +02:00

131f828e6a

Add verify check for lowest diff drain time requirement

Hivie · 2025-07-13 02:00:50 +01:00

ccf6d9c173

Fix mania Hard Rock & Easy mods not matching stable

The implementation in `master` was presuming that Hard Rock and Easy
worked the same way across all rulesets, but actually, in stable mania,
the two mods have special treatment as per

	https://github.com/peppy/osu-stable-reference/blob/996648fba06baf4e7d2e0b248959399444017895/osu!/GameplayElements/HitObjectManagerMania.cs#L147-L150

The open question here would be what this means for existing scores set
on lazer using this mod.

Bartłomiej Dach · 2025-07-02 12:26:50 +02:00

8e53f47e78

Merge pull request #33882 from bdach/hitwindow-halves

Apply flooring and half-millisecond-adjustments to hit windows

Dan Balasescu · 2025-07-02 18:09:32 +09:00

9047d27197

Fix taiko Difficulty Adjust scroll speed value getting truncated on extended mod icon information

Bartłomiej Dach · 2025-06-30 12:24:52 +02:00

cae1f8bb88

Fix Difficulty Adjust extended mod icon information not showing with extended limits active

- Closes https://github.com/ppy/osu/issues/33522.
- Alternative to / closes https://github.com/ppy/osu/pull/33561.

Bartłomiej Dach · 2025-06-30 12:20:05 +02:00

28caa03d21

Apply flooring and half-millisecond-adjustments to hit windows

This is a "two-birds-with-one-stone" change, which addresses both
https://github.com/ppy/osu/issues/28744 and
https://github.com/ppy/osu/issues/11311 simultaneously.

- The replay stability issue caused by time instants being rounded to
  nearest integer is fixed by this, because flooring and
  subtracting/adding 0.5 from the hit window threshold makes it
  impossible for a judgement to switch to anything else after replay
  rounding is applied - all hit windows are always a full integer plus
  0.5 milliseconds, which immunizes them to rounding-to-full-ms issues.

- The direction of applying the 0.5 adjustment additionally fixes the
  disparity with stable - in osu! and taiko 0.5 is subtracted as
  hit window ranges in those rulesets are exclusive on stable, while in
  mania 0.5 is added, as the hit window ranges there are *inclusive* on
  stable.

As should be obvious, this materially changes hit windows. To what degree
this is a *significant* change is up for discussion; I would say "no"
since hitting half a millisecond changes would require 2000fps input
recording, and we're still timestamping inputs using the update thread's
clock, that gives a 1ms resolution at best.

In the worst case, in osu! and taiko, this can change a hit window range
by 1.5ms (e.g. 300.9ms -> floored to 300ms -> 299.5ms after subtraction
of the half). It's more than the best-case resolution of input
timestamps, but not by much. Considering how cleanly this resolves the
issues in question, I see it as an acceptable tradeoff.

Bartłomiej Dach · 2025-06-25 11:44:13 +02:00

0f078ee550

Refactor hit windows class structure to reduce rigidity

This change pulls back a significant degree of overspecialisation and
rigidity in the class structure of `HitWindows` to make subsequent
changes to hit windows, whose purpose is to improve replay playback
accuracy, possible to do cleanly.

Notably:

- `HitWindows` is full abstract now. In a few use cases, and as a
  reference for ruleset implementors, `DefaultHitWindows` is provided as
  a separate class instead.

  This fixes the weirdness wherein `HitWindows` always declared 6 fields
  for result types but some of them would never be set to a non-zero
  value or read.

- `HitWindow.GetRanges()` is deleted because it is overspecialised and
  prevents being able to adjust hitwindows by ±0.5ms cleanly which will
  be required later.

  The fallout of this is that the assertion that used `GetRanges()` in
  the `HitWindows` ctor must use something else now, and the closest
  thing to it was `GetAllAvailableWindows()`, which didn't return
  the miss window - so I made it return the miss window and fixed the
  one consumer that didn't want it (bar hit error meter) to skip it.

- Diff also contains some clean-up around `DifficultyRange` to unify
  handling of it.

Bartłomiej Dach · 2025-06-25 08:40:12 +02:00

8b542e5442

Add localisation usage to BeatmapStatistic and revert ShowDetailsMappedBy

diquoks · 2025-06-21 21:01:48 +03:00

cad4382350

Fix simplified rhythm mod not working on some beatmaps

Dan Balasescu · 2025-06-06 19:37:01 +09:00

558aacfed5

Refactor slightly

Dan Balasescu · 2025-06-06 19:37:01 +09:00

03c3cce761

Fix replays being misrecorded if an action is pressed and released in one update frame

Closes https://github.com/ppy/osu/issues/33465 probably.

This reverts the replay frame de-duplication logic to what it was before
https://github.com/ppy/osu/pull/33148#discussion_r2091549388.

I don't have good reproduction steps. I tried to write a test case for
this that isn't just "press and release a key in the same frame",
thinking that maybe there was some loophole in the osu! touch input
mapper that may produce this situation artificially, but I could not in
many configurations. So I have to assume that this just *can happen*
organically.

Bartłomiej Dach · 2025-06-06 09:10:51 +02:00

12cc8e38da

Make CheckConcurrentObject ruleset specific

Derrick Timmermans · 2025-05-25 14:19:23 +02:00

0065696248

Merge pull request #33075 from bdach/do-not-allow-reading-garbage-from-hitwindows

Fix `HitWindows.WindowFor()` returning values for invalid results

Dean Herbert · 2025-05-09 22:24:26 +09:00

afe8ab842d

Merge pull request #32939 from bdach/gameplay-leaderboard-skinnable

Convert gameplay leaderboard to skinnable component

Dean Herbert · 2025-05-09 17:00:14 +09:00

413687e9b7

Fix HitWindows.WindowFor() returning values for invalid results

This fell out of my work on hit window-related replay issues. In my WIP
branch (that is probably going to get PR'd as draft soon) I refactored
`HitWindows` and found a few straggling test failures due to some places
reading hit windows for results that were not actually supported by the
underlying `HitWindows` implementations, leading to returning garbage
(mostly zeroes).

Importantly, there is one actual usage in game code with impact here -
`TaikoModSingleTap` was attempting to read the hit window for MEH, when
MEH was never actually a valid hit result in taiko (OK is). This was a
result of a copy-paste oversight from osu!, specifically from

	https://github.com/ppy/osu/blob/51cf835fb6300aca53b5b98143d606f64d7a4d49/osu.Game.Rulesets.Osu/Mods/InputBlockingMod.cs#L58

Bartłomiej Dach · 2025-05-09 09:40:20 +02:00

ceb58a1141

Merge pull request #30731 from Hiviexd/taiko-mod-simplified-rhythm

Dean Herbert · 2025-05-08 10:37:06 +09:00

f52eab2d22

Fix edge case of last pattern not being processed correctly

Dean Herbert · 2025-05-07 19:26:00 +09:00

b89669e56d

Merge branch 'master' into gameplay-leaderboard-skinnable

Bartłomiej Dach · 2025-05-07 10:45:51 +02:00

5b61761bbd

Simplify code

Dean Herbert · 2025-04-30 14:06:10 +09:00

72f28e5fe4

Don't bother with localised implementation of AdjustedSettingsCount

I was avoiding using reflection to save on overheads, but it's probably
not worth it.

Dean Herbert · 2025-04-30 12:58:40 +09:00

babccca2bb

Merge branch 'master' into taiko-mod-simplified-rhythm

Dean Herbert · 2025-04-28 18:34:05 +09:00

ddaf6e52e0

Show singular difficulty adjust modifications inline in mod icons

Dean Herbert · 2025-04-28 16:58:16 +09:00

c16514274d

Convert gameplay leaderboard to skinnable component

This PR converts the leaderboard into a full-fledged skinnable component
that can be manipulated by users at will.

Notably, this finally allows https://github.com/ppy/osu/issues/20422 to
be fixed - although it's a very mixed bag, for several reasons:

- Because of taiko players' refusal to see reason^W^W^W^Winsistence on
  keeping stable behaviours related to aspect ratio treatment, I have to
  assume the worst case scenario, which means than on typical
  resolutions like 16:9 (or even worse, 4:3), the leaderboard will
  likely not occupy as much vertical space as it probably could.

- Additionally, there's the problem of where to put the spectator list.
  I settled on putting it to the right of the leaderboard, but that's
  kind of janky, because the leaderboard sometimes collapses and
  sometimes fully hides, leading to a very awkward space left behind. If
  we had the capability to anchor elements to other elements, maybe this
  could be resolved, but for now, I'm not sure what to do. I think if
  some users are bothered by it they can move it where they want it. Or
  delete it.

Bartłomiej Dach · 2025-04-24 13:10:30 +02:00

59b826c321

Don't include spinner types in note sums

Dean Herbert · 2025-04-14 19:21:36 +09:00

3d47a2b5b2

Rename new property to better explain visual-only usage

Dean Herbert · 2025-04-14 18:38:04 +09:00

f05a50f4e1

Introduce numeric value in beatmap hit count statistics

Salman Alshamrani · 2025-04-12 00:14:53 +09:00

85556e0c3e

Shorten beatmap hit statistics names