64 Commits

• Calculate hit windows in performance calculator instead of databased difficulty attributes (#31735)

  * Calculate hit windows in performance calculator instead of databased difficulty attributes
  
  * Apply mods to beatmap difficulty in osu! performance calculator
  
  * Remove `GreatHitWindow` difficulty attribute for osu!mania
  
  * Remove use of approach rate and overall difficulty attributes for osu!
  
  * Remove use of hit window difficulty attributes in osu!taiko
  
  * Remove use of approach rate attribute in osu!catch
  
  * Remove unused attribute IDs
  
  * Code quality
  
  * Fix `computeDeviationUpperBound` being called before `greatHitWindow` is set

  James Wilson · 2025-02-07 19:21:12 +09:00
  9f90ebb2f7
• Replace indexed skill access with skills.OfType<...>().Single() (#30034)

  * Replace indexed skill access with `skills.First(s is ...)`
  
  * Fix comment
  
  * Further refactoring to remove casts
  
  ---------
  
  Co-authored-by: Dan Balasescu <smoogipoo@smgi.me>
  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  StanR · 2025-01-20 09:39:35 +00:00
  22e839d62b
• Bump difficulty calculator versions

  In order for the new star difficulty to be shown to users on the next
  release.
  
  catch's difficulty calculator version is not bumped because the only
  catch change pending deploy is https://github.com/ppy/osu/pull/28353 and
  that affects performance points only.

  Bartłomiej Dach · 2024-10-07 15:38:41 +02:00
  1af464d5ae
• merged multipliers
  Givikap120 · 2024-08-05 16:33:42 +03:00
  e6fc4f6766
• Bump databased star rating versions
  Dan Balasescu · 2024-02-06 22:58:11 +09:00
  ee05743921
• Split legacy scoring attributes into a separate object
  Dan Balasescu · 2023-09-07 21:10:38 +09:00
  2334be1987
• ILegacyScoreProcessor -> ILegacyScoreSimulator
  Dean Herbert · 2023-07-04 17:32:54 +09:00
  1629024111
• Apply a few other code reviews
  Dan Balasescu · 2023-06-29 17:28:06 +09:00
  426f11b824
• Refactoring
  Dan Balasescu · 2023-06-28 16:14:32 +09:00
  09bc8e45de
• Initial conversion of scores
  Dan Balasescu · 2023-06-26 22:19:01 +09:00
  a9c65d200a
• Merge branch 'master' into diffcalc-total-scorev1
  Dan Balasescu · 2023-06-26 14:32:14 +09:00
  e1d723a2cc
• Add flag to disable computing legacy scoring values
  Dan Balasescu · 2023-06-24 01:03:18 +09:00
  06565871d6
• Automated pass
  Dean Herbert · 2023-06-24 01:00:03 +09:00
  0ab0c52ad5
• Adjust attribute data
  Dan Balasescu · 2023-06-19 21:38:13 +09:00
  bfa449e47a
• Add ScoreV1 calculation for ManiaRuleset
  Dan Balasescu · 2023-06-13 23:28:45 +09:00
  13d1f9c902
• Bump difficulty calculator versions
  Dan Balasescu · 2022-09-02 16:27:25 +09:00
  9645bfe708
• Add versioning to difficulty calculators
  Dean Herbert · 2022-07-21 18:15:25 +09:00
  aca19a005e
• Remove unneeded attributes
  63411 · 2022-06-17 23:44:10 +08:00
  e238bcc6c6
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Merge branch 'master' into dho
  Dan Balasescu · 2022-06-09 18:29:14 +09:00
  f0ef2e610e
• Calculate true combo value in ManiaDifficultyCalculator
  Dan Balasescu · 2022-06-02 19:16:31 +09:00
  b1ffffc1ac
• Pass object position to the object
  apollo-dw · 2022-05-26 19:26:14 +01:00
  66a6467403
• Use object list size for object position
  apollo-dw · 2022-05-24 16:30:25 +01:00
  30b9e0e7ab
• Store hitobject history in the hitobject
  apollo-dw · 2022-05-22 16:26:22 +01:00
  26985ca8af
• Add explanatory note
  Dan Balasescu · 2022-02-16 20:07:58 +09:00
  0b37efc985
• Fix improperly considering rate adjustment mods
  Dan Balasescu · 2022-02-16 19:51:42 +09:00
  a0ee86ddd2
• Stop persisting Skills in DifficultyAttributes
  Dean Herbert · 2021-11-21 12:15:32 +09:00
  9f688f6291
• Update DifficultyCalculator to take an IRulesetInfo
  Dean Herbert · 2021-11-15 19:16:48 +09:00
  369b4ba789
• Update DifficultyCalculator to take an IWorkingBeatmap
  Dean Herbert · 2021-11-15 19:16:48 +09:00
  62d670a3ca
• Remove int casts in other calculators
  smoogipoo · 2021-10-10 16:23:35 +09:00
  e30e5bd214
• Copy BaseDifficulty to Beatmap<T> and move all write operations across
  Dean Herbert · 2021-10-06 15:10:45 +09:00
  b339c149d8
• Fix mania difficulty calculator crashing
  smoogipoo · 2021-10-01 19:57:45 +09:00
  5820a71652
• Refactor to pass clockrate in constructor rather than deriving from mods
  Samuel Cattini-Schultz · 2021-06-03 16:09:42 +10:00
  f51413ead9
• Add a list of mods to Skill class

  Although this isn't necessary for existing official rulesets and calculators, custom calculators can have use cases for accessing mods in difficulty calculation.
  For example, accounting for the effects of visual mods.

  Samuel Cattini-Schultz · 2021-02-20 20:37:44 +11:00
  66643a97b0
• Replicate hit window calculation
  smoogipoo · 2020-10-14 20:40:39 +09:00
  26dffbfd3b
• Add support for dual stages (keycoop) and score multiplier
  smoogipoo · 2020-10-14 17:53:28 +09:00
  3e6ed6c9ff
• Replicate stable's unstable sort
  smoogipoo · 2020-10-09 21:50:20 +09:00
  306d876d22
• Combine mania skills
  smoogipoo · 2020-10-09 21:47:34 +09:00
  5017c92fe8
• Add mania max combo attribute
  smoogipoo · 2020-08-28 19:16:24 +09:00
  85bda29b71
• Refactor HitWindows for legibility
  Dean Herbert · 2019-09-06 15:24:14 +09:00
  f925e781a9
• Fix potential diffcalc hitwindow nullref
  smoogipoo · 2019-09-02 17:38:58 +09:00
  4c150839c0
• Add Skills to DifficultyAttributes
  HoLLy · 2019-05-29 11:22:51 +02:00
  7e9f5a0939
• Remove excess newline
  Dean Herbert · 2019-02-20 10:29:08 +09:00
  d6a2fe6891
• Add beatmap argument + fix crashes
  smoogipoo · 2019-02-19 17:56:38 +09:00
  4efc03cdf0
• Update with PopulateAttributes() removal
  smoogipoo · 2019-02-19 17:48:00 +09:00
  5457097342
• Fix post-merge errors
  smoogipoo · 2019-02-19 16:30:29 +09:00
  bf17826363
• Consider aggregate peaks
  smoogipoo · 2019-02-18 15:00:32 +09:00
  9cce9ce97c
• Implement new difficulty calculator for Rulesets.Mania
  smoogipoo · 2019-02-18 15:00:20 +09:00
  68725dc005
• Implement new difficulty calculator structure
  smoogipoo · 2019-02-18 14:49:43 +09:00
  a8faa942a6
• Use correct DifficultyAttributes where possible
  HoLLy · 2019-02-06 21:28:42 +01:00
  ae9d5f999c