1
0
mirror of https://github.com/ppy/osu.git synced 2024-09-22 04:47:24 +08:00
Commit Graph

31417 Commits

Author SHA1 Message Date
Dean Herbert
cf9bda6c19 Add coverage of early exit with null and non-null player 2020-08-13 13:05:13 +09:00
Dean Herbert
fd7bf70b7d Remove weird "after load" action
This was pretty pointless anyway and from its usages, doesn't look to
need to exist.
2020-08-13 13:03:18 +09:00
Dean Herbert
5b536aebe7 Add missing null checks and avoid cross-test pollution 2020-08-13 12:53:37 +09:00
Dean Herbert
99bea6b8e9 Add missing null check (player construction is potentially delayed now) 2020-08-13 12:52:35 +09:00
Dean Herbert
27cd9e119a Delay beatmap load until after transition has finished
Previously the beatmap would begin loading at the same time the
`PlayerLoader` class was. This can cause a horribly visible series of
stutters, especially when a storyboard is involved.

Obviously we should be aiming to reduce the stutters via changes to the
beatmap load process (such as incremental storyboard loading,
`DrawableHitObject` pooling, etc.) but this improves user experience
tenfold in the mean time.
2020-08-13 12:04:32 +09:00
Dan Balasescu
1c771471d5
Merge pull request #9837 from peppy/update-framework
Update framework and resources
2020-08-13 00:41:58 +09:00
Dean Herbert
00f8bb7c3e Update resources 2020-08-12 23:28:45 +09:00
Dean Herbert
b10cddf625 Update framework 2020-08-12 23:28:08 +09:00
Dean Herbert
05b06e7451
Merge branch 'master' into fix-skinnable-sound-mute 2020-08-12 22:01:04 +09:00
Andrei Zavatski
f3202fb123 Naming adjustments 2020-08-12 11:24:26 +03:00
Andrei Zavatski
9b112baa88 Merge remote-tracking branch 'refs/remotes/ppy/master' into dashboard-news 2020-08-12 11:15:58 +03:00
Bartłomiej Dach
4f3f95540b Check for zero rate to prevent crashes on unpause 2020-08-11 22:34:46 +02:00
Bartłomiej Dach
bcaaf25278 Fix Spun Out mod being affected by rate-changing mods 2020-08-11 22:04:18 +02:00
Bartłomiej Dach
25f59e0489 Add failing test cases 2020-08-11 21:55:50 +02:00
Bartłomiej Dach
8fe5775ecb Allow testing mod combinations in ModTestScenes 2020-08-11 21:55:20 +02:00
Bartłomiej Dach
b78ccf8a34 Rewrite Spun Out test scene 2020-08-11 21:28:00 +02:00
Dan Balasescu
85182b19fe
Merge pull request #9831 from peppy/fix-informational-overlays
Fix informational overlays not hiding each other correctly
2020-08-12 02:18:34 +09:00
Andrei Zavatski
84655b0798 Change hover colour for news title 2020-08-11 20:17:29 +03:00
Andrei Zavatski
fdfda453c7 Merge remote-tracking branch 'refs/remotes/ppy/master' into dashboard-news 2020-08-11 20:14:52 +03:00
Dean Herbert
8bfe6ba27c Fix informational overlays not hiding each other correctly 2020-08-11 23:15:08 +09:00
Dan Balasescu
c86798f8b2
Merge pull request #9829 from peppy/fix-multiple-assembly-loaded-crash
Fix crash when same ruleset loaded more than once
2020-08-11 12:09:44 +09:00
Dan Balasescu
8b7e715c2b
Merge pull request #9818 from peppy/improve-token-fail-error-messaging
Improve messaging when timeshift token retrieval fails
2020-08-11 11:31:52 +09:00
Dean Herbert
471ed968e3 Fix crash when same ruleset loaded more than once
If the same ruleset assembly was present more than once in the current
AppDomain, the game would crash. We recently saw this in Rider EAP9.
While this behaviour may change going forward, this is a good safety
measure regardless.
2020-08-11 11:09:02 +09:00
Dean Herbert
dd2f677aa4
Merge pull request #9633 from Joehuu/fix-keybind-clearing 2020-08-11 11:01:03 +09:00
Dean Herbert
02084d7636 Merge branch 'master' into improve-token-fail-error-messaging 2020-08-11 10:59:33 +09:00
Dean Herbert
d1b106a3b5 Include mention of old releases in error message 2020-08-11 10:59:28 +09:00
Dean Herbert
ca7fd57ec2
Merge pull request #9826 from bdach/spinner-rotation-clock-rate 2020-08-11 10:43:55 +09:00
Dan Balasescu
088f7f5cc7
Merge pull request #9819 from peppy/fix-overlay-depths
Always show newly presented overlay at front
2020-08-11 10:24:37 +09:00
Dan Balasescu
7dc9888730
Merge pull request #9827 from peppy/update-framework
Update framework
2020-08-11 09:59:44 +09:00
Dean Herbert
6e0d071510 Merge branch 'upstream/dependabot/nuget/Microsoft.NET.Test.Sdk-16.7.0' into update-framework 2020-08-11 06:55:12 +09:00
Dean Herbert
ecb4826e19 Update framework 2020-08-11 06:54:26 +09:00
Bartłomiej Dach
cca78235d5 Replace CumulativeRotation with RateAdjustedRotation 2020-08-10 23:02:06 +02:00
Bartłomiej Dach
5d63b5f6a5 Add failing test cases 2020-08-10 23:02:01 +02:00
Bartłomiej Dach
61f1c4fe62 Extract replay-transforming helper test method 2020-08-10 19:51:00 +02:00
dependabot-preview[bot]
d7de8b2916
Bump Microsoft.NET.Test.Sdk from 16.6.1 to 16.7.0
Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 16.6.1 to 16.7.0.
- [Release notes](https://github.com/microsoft/vstest/releases)
- [Commits](https://github.com/microsoft/vstest/compare/v16.6.1...v16.7.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-08-10 17:17:07 +00:00
Dean Herbert
365aae799e
Merge branch 'master' into fix-skinnable-sound-mute 2020-08-10 23:55:51 +09:00
Dean Herbert
730d13fda6 Always show newly presented overlay at front
This feels much better. Does not change order if the overlay to be shown
is not yet completely hidden.

- Closes #9815.
2020-08-10 20:48:04 +09:00
Dean Herbert
1f84e54151 Improve messaging when timeshift token retrieval fails
Obviously not a final solution, but should better help self-compiling
(or unofficial package) users better understand why this is happening.
2020-08-10 20:16:16 +09:00
Dean Herbert
96c4a30fac
Merge pull request #9788 from smoogipoo/adujustable-skinnablesound
Make SkinnableSound an IAdjustableAudioComponent
2020-08-10 19:39:13 +09:00
Andrei Zavatski
d8f8930691 Remove HomeNewsPanelFooter 2020-08-09 05:28:43 +03:00
Andrei Zavatski
a72a48624d Remove NewsPostDrawableDate 2020-08-09 05:16:08 +03:00
Bartłomiej Dach
a636c7052c Merge branch 'master' into adujustable-skinnablesound 2020-08-08 21:51:47 +02:00
Dean Herbert
ffb2e56a8d Reverse direction of bool to make mental parsing easier 2020-08-08 23:25:52 +09:00
Dean Herbert
0d1f273603 Merge branch 'master' into fix-skinnable-sound-mute 2020-08-08 23:24:03 +09:00
Dean Herbert
1090137da3
Adjust comment to read better
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2020-08-08 23:23:02 +09:00
Andrei Zavatski
cddd4f0a97 Implement HomeShowMoreNewsPanel 2020-08-07 13:18:31 +03:00
Andrei Zavatski
76d35a7667 Implement HomeNewsGroupPanel 2020-08-07 12:59:45 +03:00
Andrei Zavatski
e56671a1f1 Merge remote-tracking branch 'refs/remotes/ppy/master' into dashboard-news 2020-08-07 11:33:04 +03:00
Andrei Zavatski
2e0f567d5d Implement HomeNewsPanel component 2020-08-07 11:33:02 +03:00
Dan Balasescu
d8ffc00f75
Merge pull request #6345 from frenzibyte/expand-number-piece-on-old-skins
Expand number piece for legacy old skins
2020-08-07 17:18:36 +09:00