62 Commits

• Replace calls to defective Humanizer methods with correct version
  Bartłomiej Dach · 2022-07-18 22:34:58 +02:00
  6f37487528
• Add own fixed copy of defective Humanizer methods
  Bartłomiej Dach · 2022-07-18 21:37:31 +02:00
  ffa9a83a4f
• Move the null check in the outside.

  AddCursor() should not accept the null value.

  andy840119 · 2022-06-30 23:29:49 +08:00
  48047f2e58
• mark the string as nullable.
  andy840119 · 2022-06-30 23:23:14 +08:00
  a5b1f1a688
• Remove the nullable disable annotation.
  andy840119 · 2022-06-30 23:20:40 +08:00
  26de34da84
• Update parameter discards
  Dean Herbert · 2022-06-24 21:26:19 +09:00
  31a447fda0
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Update TimeSpan localisation to use ToLocalisableString
  Salman Ahmed · 2022-04-28 11:12:50 +03:00
  c8665dc93b
• Add the ability to add settings to skinnable elements
  Dean Herbert · 2022-03-13 17:03:25 +09:00
  c99397f75a
• Convert to extension method to avoid recursive calls
  Dean Herbert · 2022-03-03 14:15:37 +09:00
  42e07b7308
• Gracefully handle undefined DateTimeOffset values

  Only seems to happen in tests, but best to safeguard against this
  regardless.

  Dean Herbert · 2022-02-21 16:35:40 +09:00
  2f6e65a9a2
• Move to extension method and revert logic to match previous implementation
  Dean Herbert · 2022-02-21 13:42:26 +09:00
  fc1877b6fa
• Fix cursors sent to osu-web being potentially string formatted in incorrect culture

  Fixed as per solution at https://github.com/JamesNK/Newtonsoft.Json/issues/874.
  
  Note that due to the use of `JsonExtensionDataAttribute` it's not
  feasible to change the actual specification to `JValue` in the
  `Dictionary`.
  
  In discussion with the osu-web team, it may be worthwhile to change the cursor
  to a string format where parsing is not required at our end. We could already
  do this in fact, but there are tests that rely on it being a `JToken` so the
  switch to `JValue` seems like the easier path right now.

  Dean Herbert · 2022-01-04 17:20:46 +09:00
  5736b7d978
• Add MatchesOnlineID implementation for IScoreInfo
  Dean Herbert · 2021-12-10 18:34:31 +09:00
  c9f6c5c673
• Move archive filename helper method to extension method
  Dean Herbert · 2021-11-25 16:35:54 +09:00
  416ee2447a
• Make BeatmapSet.Metadata non-null
  Dean Herbert · 2021-11-24 15:03:34 +09:00
  3946a39b65
• Remove usage of Nuget.Packaging extension methods for IList.AddRange
  Dean Herbert · 2021-11-23 15:02:02 +09:00
  6fb2757739
• Move StoragePath implementation to an extension method
  Dean Herbert · 2021-11-19 16:08:38 +09:00
  59e763467f
• Remove usage of key repeat helper method
  Dean Herbert · 2021-11-18 13:13:36 +09:00
  66c307e0ee
• Add missing APIUser comparison method
  Dean Herbert · 2021-11-16 12:44:20 +09:00
  2cbdac91ad
• Add type safety to MatchesOnlineID extension methods
  Dean Herbert · 2021-11-16 12:37:47 +09:00
  fbc46941fa
• Make ModelExtensions nullable enabled
  Dean Herbert · 2021-11-15 14:38:01 +09:00
  18f73b985b
• Use extension method to compare online IDs
  Dean Herbert · 2021-11-15 14:34:50 +09:00
  a4c11e8813
• Add fallback case for GetDisplayString if called on a null reference
  Dean Herbert · 2021-11-12 16:02:51 +09:00
  98dcf487da
• Add GetDisplayString() extension to handle all model interface types globally
  Bartłomiej Dach · 2021-11-09 13:53:07 +01:00
  5ec8288508
• Amend xmldoc of shake extension method
  Bartłomiej Dach · 2021-09-14 22:50:45 +02:00
  baf9961934
• Move shake logic into extension method
  Dean Herbert · 2021-09-14 14:44:23 +09:00
  e17b800470
• Update incorrect xmldoc
  Dean Herbert · 2021-07-31 16:48:45 +09:00
  7a44ddb36b
• Add new extension for formatting time durations
  Dean Herbert · 2021-07-31 16:45:53 +09:00
  472c0137ec
• Merge branch 'master' into skin-editor-closest-anchor
  Dean Herbert · 2021-06-18 18:54:07 +09:00
  c751e087ca
• Fix languages with a sub-language part not working properly
  Bartłomiej Dach · 2021-06-16 11:10:03 +02:00
  cc5145a131
• Rename OverridesClosestAnchor to UsesFixedAnchor
  Robin Avery · 2021-06-08 08:28:42 -04:00
  dc50ae40b9
• Rename UsingClosestAnchor

  It is now "OverridesClosestAnchor". The logic is inverted accordingly.

  Robin Avery · 2021-06-07 00:14:36 -04:00
  133d72a8c0
• Remove all UsingClosestAnchor() extension logic

  It is replaced with ISkinnableDrawable.UsingClosestAnchor.

  Robin Avery · 2021-06-07 00:04:53 -04:00
  f28916e30f
• Uninvert logic of SkinnableInfo.UsingClosestAnchor

  Also rename "IsUsingClosestAnchor" to simply "UsingClosestAnchor".

  Robin Avery · 2021-06-06 10:13:35 -04:00
  da1c38d5a9
• Add serialization support via SkinnableInfo
  Robin Avery · 2021-06-06 07:18:08 -04:00
  11b1b8c633
• Move lookup logic to DrawableExtensions

  This is now a global lookup to be shared by serialization and editor.

  Robin Avery · 2021-06-06 06:58:21 -04:00
  c9f5808bf2
• Mark access to exception if task faulted as safe

  There are seemingly no C#-side compile-time guarantees that it is safe,
  but if the task's state is `Faulted` (as is checked right before), the
  exception cannot be null as per the documentation.

  Bartłomiej Dach · 2021-05-15 00:09:34 +02:00
  43c73f9583
• Standardise naming of methods related to SkinnableInfo
  Dean Herbert · 2021-05-13 13:14:49 +09:00
  3b862798e9
• Merge branch 'master' into skin-serialisation
  Dean Herbert · 2021-05-13 12:35:06 +09:00
  8b9ac86d4b
• Extract invariant instantiation info extension method
  Bartłomiej Dach · 2021-05-12 23:23:51 +02:00
  1b579dd838
• Also serialise Origin out
  Dean Herbert · 2021-05-11 18:39:14 +09:00
  c94df672e5
• Add basic support for child serialisation
  Dean Herbert · 2021-05-11 18:39:14 +09:00
  6a88b8888b
• Remove unused interface class for simplicity
  Dean Herbert · 2021-05-11 18:39:14 +09:00
  95a497e9df
• Add the concept of skinnable target containers and mark a basic one for HUD elements
  Dean Herbert · 2021-05-11 18:39:14 +09:00
  95a8f21ab2
• Setup basics to allow extracting serializable content from skinnable Drawables
  Dean Herbert · 2021-05-11 18:39:14 +09:00
  b9ab9342fa
• Refactor SelectionBlueprint and MoveSelectionEvent to work in screen-space coordinates

  Until now, the implementation of the overrides in `SelectionBlueprint`
  have been confusing to the point where I would just implement by
  trial-and-error (or copying from an existing implementation). This was
  due to a combination of using "object" space coordinates
  (ie. the thing the `Blueprint` is operating on) and screen-space coordinates.
  
  This change switches all event related coordinates to screen-space,
  which is how we already handle rotation/scale operations. With the
  introduction of other editor types where the related objects are
  drawables, this also makes a lot more sense.

  Dean Herbert · 2021-04-29 16:10:42 +09:00
  9c62c90cfc
• Fix volume controls not supporting key repeat
  Dean Herbert · 2021-04-14 13:11:24 +09:00
  8282f38eb7
• Merge branch 'master' into fix-leave-room-race-2
  Bartłomiej Dach · 2021-01-30 13:41:04 +01:00
  9ab1ad25eb
• Remove all usage of CatchUnobservedExceptions

  This should no longer be required with the recent framework side change
  that stops a game from crashing on unobserved exceptions
  (https://github.com/ppy/osu-framework/pull/4171).

  Dean Herbert · 2021-01-29 16:32:29 +09:00
  a61444690e