1
0
mirror of https://github.com/ppy/osu.git synced 2024-11-16 00:37:26 +08:00
Commit Graph

114 Commits

Author SHA1 Message Date
Bartłomiej Dach
e2df098184
Add failing test case for desired artist sort behaviour 2024-03-22 08:41:08 +01:00
Bartłomiej Dach
259be976e8
Adjust test to fail 2024-02-21 11:42:34 +01:00
Bartłomiej Dach
30b5b36f1d
Fix code quality inspection 2023-12-26 12:20:17 +01:00
Nathan Tran
4e3bdb2b56 Add test coverage 2023-12-26 00:57:06 -08:00
Bartłomiej Dach
b884f1af4a
Assign random statuses to beatmap sets in carousel test
Just to have visual coverage of the statuses before fixing them not
propagating to split difficulty mode.
2023-09-06 08:25:07 +02:00
Dean Herbert
84f4fab9cf Adjust test to actually test diff splitting 2023-08-25 18:09:51 +09:00
Dean Herbert
b471ab07a6
Fix typo in test step
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2023-08-24 18:30:59 +09:00
Dean Herbert
ba70d48d2c Fix one more test probably going off-screen 2023-08-24 13:31:33 +09:00
Dean Herbert
4881130cae Limit set/diff count in test to better fit on screen 2023-08-24 03:32:12 +09:00
Dean Herbert
5eac604f8b Add coverage of selection retention when difficulties are split out 2023-08-23 19:44:42 +09:00
Dean Herbert
a64381f855 Add test coverage of add/remove when difficulties are split out 2023-08-23 19:43:08 +09:00
Dean Herbert
5555f73e97 Update test to match new behaviour 2023-08-23 19:38:18 +09:00
Salman Ahmed
b9543f4fdd Add failing test case 2023-06-15 11:21:52 +03:00
Dean Herbert
a14dede036 Ensure TestBeatmapCarousel.Items only returns actually visible items (and in correct order)
Turns out that items could be in an order that isn't the same as how
things look on the carousel, so this change ensures that for testing
purposes they are sorted by Y position.

Also uses the `CarouselItem.Visible` flag to ensure that we don't have
to wait for drawable fade transitions after a filter operation.
2023-03-03 17:18:34 +09:00
Dean Herbert
7a092ea995 Add better coverage and more comments explaining the structure of test setup 2023-03-03 17:18:14 +09:00
Dean Herbert
82293c0c86 Don't filter away results with missing data when using "Date Submitted" or "Date Ranked" sort modes
From a user's perspective, changing a sort / order mode shouldn't filter
away results, but we were doing this.

In terms of UX expectations, in stable this kind of scenario would
results in a group being added to the end of son select with "Not
ranked" or "Unknown". I think we should aim to match this eventually.
2023-03-03 16:36:18 +09:00
Dean Herbert
3b27774561 Remove OnlineID sort consideration 2023-01-18 19:21:02 +09:00
Dean Herbert
92fc439f82 Add test coverage of carousel sort expectations
This covers the fail case of removing and adding items (see
https://github.com/ppy/osu/issues/21926) but also covers the proposed
forward implementation, which now considers `DateAdded` and `OnlineID`.
2023-01-17 16:40:25 +09:00
Salman Ahmed
e6ff262521 Fix potential nullref in certain beatmap carousel tests 2023-01-13 19:42:09 +03:00
mk56-spn
69260ca3c3 remove unnecessary usages of nullable forgiveness, add asserts for debugging 2023-01-09 18:36:55 +01:00
mk56-spn
a32c4a64e7 Fix errors in test 2023-01-08 19:18:28 +01:00
Dan Balasescu
7bc8908ca9 Partial everything 2022-11-27 00:00:27 +09:00
Bartłomiej Dach
b3667821eb
Add failing test case 2022-11-20 10:07:32 +01:00
Endrik Tombak
b95091fbb0 Move test to improve diff readability 2022-10-24 22:55:09 +03:00
Endrik Tombak
9def12c60b Write new tests 2022-10-24 22:50:56 +03:00
Dean Herbert
b50116e9e4 Add missing null check in BeatmapCarousel tests 2022-09-07 16:22:11 +09:00
Dean Herbert
148e487c02 Add failing test of date submitted search failing 2022-09-01 19:59:27 +09:00
Dean Herbert
1032b2a68c Fix some BeatmapCarousel tests not correctly reinitialising local data per run
Closes https://github.com/ppy/osu/issues/19949.
2022-08-25 14:03:26 +09:00
Salman Ahmed
682192dbd7 Add failing test case 2022-08-01 18:43:01 +03:00
Salman Ahmed
91ffa7007f Improve existing test coverage to cover order changes from other sort modes 2022-07-26 10:24:51 +03:00
Dean Herbert
f6de76e057 Move test to stand-alone class and add full ui testing 2022-07-19 18:50:27 +09:00
Dean Herbert
eaf4f6dbb7 Add beatmap update button 2022-07-19 18:29:36 +09:00
Dan Balasescu
f8830c6850 Automated #nullable processing 2022-06-17 16:37:17 +09:00
Dean Herbert
f012f64fd1 Add test coverage checking carousel panel visual state after ruleset filter change 2022-02-11 15:21:01 +09:00
Dean Herbert
41aa4b8cca Fix TestSelectingFilteredRuleset failing under visual tests due to using local database 2022-02-03 16:04:05 +09:00
Bartłomiej Dach
04d6ca59a3
Merge branch 'master' into song-select-scroll-position-during-delete 2022-01-27 20:46:19 +01:00
Dean Herbert
f2cecad83b Add failing test coverage showing carousel deletions don't keep scroll position 2022-01-27 16:52:02 +09:00
Dean Herbert
5288eedd31 Update all usages of RulesetID and Ruleset.ID to use Ruleset.OnlineID 2022-01-27 15:38:03 +09:00
Dean Herbert
67bf95bc91 Remove all usage of AuthorString 2022-01-18 23:30:40 +09:00
Dean Herbert
9900a3f408 Remove outdated comment 2022-01-14 21:40:35 +09:00
Dean Herbert
41d90cd0b5 Fix beatmap carousel test failures 2022-01-12 17:49:10 +09:00
Dean Herbert
e74a5022c9 Fix multiple tests via null checks and changing ToLive to Detach
flow
2022-01-12 17:00:17 +09:00
Dean Herbert
3152d2d8a0 "Update" BeatmapCarousel 2022-01-12 17:00:16 +09:00
Dean Herbert
e6fdd0e969 Miscellaneous fixes that don't fit elsewhere 2022-01-12 16:39:36 +09:00
Dean Herbert
2cb97dd599 Remove unnecessary assigns of EF foreign ID fields in tests 2022-01-12 16:39:36 +09:00
Dean Herbert
37673f4cf8 Update sets of BeatmapSet.Metadata to instead create a Beatmap 2022-01-12 16:39:36 +09:00
Dean Herbert
e6f6558ddf Update mock model usage to set GUIDs instead of ints 2022-01-12 16:39:36 +09:00
Dean Herbert
e6cfe44652 Fix occasional test failure due to default value oversight in TestSceneBeatmapCarousel 2021-11-25 16:29:06 +09:00
Dean Herbert
7603f7eb36 Fix a few incorrectly updated arguments 2021-11-24 18:14:18 +09:00
Dean Herbert
0c819b9cfb Combine all test data BeatmapSetInfo creation into a single method 2021-11-24 18:07:32 +09:00