76043 Commits

This Branch

This Branch

All Branches

• Define delegate for applying classic defaults
  Salman Alshamrani · 2025-12-18 06:17:07 -05:00
  094860bfea
• Remove Value from {Is,Set}ValueDefault
  Salman Alshamrani · 2025-12-18 05:50:35 -05:00
  f5bd888078
• Limit form dropdown height by default
  Salman Alshamrani · 2025-12-18 05:19:54 -05:00
  90d7615432
• Add test coverage
  Salman Alshamrani · 2025-12-18 05:19:54 -05:00
  7a32e0eebf
• Implement new settings item component
  Salman Alshamrani · 2025-12-18 05:19:54 -05:00
  78043fa782
• Expose common interface for form controls
  Salman Alshamrani · 2025-12-18 05:15:01 -05:00
  729cd722bd
• Add osu!-style undo icon
  Salman Alshamrani · 2025-12-18 04:08:16 -05:00
  8da1fde981
• Merge pull request #36025 from smoogipoo/qp-ui-scale

  Remove UI scaling in quick play

  Dean Herbert · 2025-12-18 16:01:39 +09:00
  1de97712f1
• Fix github side inspection
  Dean Herbert · 2025-12-18 16:00:23 +09:00
  83ddcf7b02
• Also apply to queue screen
  Dan Balasescu · 2025-12-18 14:07:58 +09:00
  2e7edf8c1f
• Merry christmas
  Dean Herbert · 2025-12-18 02:20:13 +09:00
  2025.1218.0-lazer 61ecd18d24
• Merge pull request #36043 from peppy/more-stable-editor-seeking

  Adjust editor seeking to be fairer when track is playing

  Bartłomiej Dach · 2025-12-17 13:57:47 +01:00
  9e67cf503b
• Merge pull request #36042 from peppy/remove-beat-sync-break-overlay

  Remove beat sync from skip / break overlay

  Bartłomiej Dach · 2025-12-17 13:34:04 +01:00
  62fd61def4
• Adjust editor seeking to be fairer when track is playing

  The previous multiplier was supposed to account for seeking backwards
  being "slower" because the track is playing forwards, but it really
  didn't work amazingly.
  
  Rather than trying to pull off some magic, let's just ensure that seeks
  in both directions feel correct, even if that means that time gradually
  moves forwards.
  
  Closes https://github.com/ppy/osu/issues/35998 (mostly).
  
  Of note, this still doesn't match stable completely. I attempted to
  implement the full stable seeking algorithm but it's objectively worse
  in other scenarios, so I'd rather just tweak what we have until the
  majority of users are happy.

  Dean Herbert · 2025-12-17 18:50:14 +09:00
  f581f85eb2
• Remove beat sync from skip / break overlay

  This didn't end up feeling as good as I hoped. Will revise at a later
  stage, adding beat sync in another way that isn't jank transforms on the
  progress bars.
  
  Also closes https://github.com/ppy/osu/issues/35972.

  Dean Herbert · 2025-12-17 16:38:46 +09:00
  b07cd2daa4
• Prevent mod track adjustments from modifying BGM speed in queue (#36027)

  * Fix(Matchmaking): Prevent mod track adjustments from applying BGM speed in queue
  
  * replaced modification of MusicController directly with a property change.
  
  * formatted

  AV · 2025-12-17 14:40:08 +09:00
  3b635f6919
• Expose notification main content for external use
  Dean Herbert · 2025-12-17 14:28:08 +09:00
  07817dce70
• Merge pull request #36020 from bdach/fail-indicator-right-sound

  Fix replay fail indicator not using fail sample from beatmap skin

  Dean Herbert · 2025-12-17 01:15:22 +09:00
  734c6f933d
• Merge pull request #36023 from bdach/report-message-pm

  Adjust message on successful report to match bancho

  Dean Herbert · 2025-12-16 23:52:31 +09:00
  ac213c90cb
• Merge pull request #36009 from frenzibyte/fix-skip-button

  Fix skip overlay potentially not allowing skipping

  Bartłomiej Dach · 2025-12-16 14:58:43 +01:00
  74ca87c252
• Remove UI scaling in quick play
  Dan Balasescu · 2025-12-16 21:21:52 +09:00
  190b5535d7
• Adjust message on successful report to match bancho

  Addresses https://github.com/ppy/osu/discussions/36004.
  
  Not adding localisation because the previous implementation was
  `.ToString()`ing anyway.
  
  Would have made the abuse e-mail a link but `mailto:` doesn't work with
  `MessageFormatter` and I don't want to go into that right now.
  
  The message *almost* matches stable. The "almost" is because it doesn't
  mention the `/ignore` chat command. I was just going to implement the
  command, but I went to check what it does, and backed away slowly
  because it has like weird scoping to chat, highlights, and PMs, so
  `nope.avi`.

  Bartłomiej Dach · 2025-12-16 11:20:54 +01:00
  032912e62b
• Fix replay fail indicator not using fail sample from beatmap skin

  Closes https://github.com/ppy/osu/issues/36003.
  
  The duplicated `RulesetSkinProvidingContainer` is unfortunate but it's
  either this or I start doing proxy shenanigans.

  Bartłomiej Dach · 2025-12-16 09:48:10 +01:00
  1e79c56240
• Merge pull request #34807 from mcendu/legacy-pp-counter

  Add "legacy" pp counter

  Dean Herbert · 2025-12-15 20:24:04 +09:00
  82256ae2de
• Update resources
  Dean Herbert · 2025-12-15 19:22:11 +09:00
  1142be45ec
• Adjust constant and documentation slightly
  Dean Herbert · 2025-12-15 19:07:46 +09:00
  dcb6d71287
• Fix skip overlay potentially not allowing skipping
  Salman Alshamrani · 2025-12-15 03:54:09 -05:00
  881a35b382
• Merge branch 'master' into legacy-pp-counter
  Dean Herbert · 2025-12-15 16:55:51 +09:00
  89d8b402af
• Merge pull request #36005 from smoogipoo/update-packages

  Update localisation analyser packages

  Dean Herbert · 2025-12-15 16:15:37 +09:00
  1d351002df
• Merge pull request #35980 from smoogipoo/qp-ux-fixes

  Various minor quick play UX fixes

  Dean Herbert · 2025-12-12 19:20:17 +09:00
  2606f3a0b5
• Automatically accept invitation in queue screen
  Dan Balasescu · 2025-12-12 18:26:52 +09:00
  1c463aa060
• Move to queue screen when clicking notification
  Dan Balasescu · 2025-12-12 18:13:00 +09:00
  7853abe8aa
• Reword waiting text
  Dan Balasescu · 2025-12-12 17:57:50 +09:00
  1aff418981
• Merge pull request #35971 from smoogipoo/fix-mp-screen-leave

  Forcefully leave room on multiplayer exit

  Dean Herbert · 2025-12-12 17:06:20 +09:00
  62e92bb242
• Remove mention of exception that doesn't exist
  Dan Balasescu · 2025-12-12 15:46:00 +09:00
  79151ae5b4
• Forcefully leave room on multiplayer exit
  Dan Balasescu · 2025-12-11 20:07:44 +09:00
  c17db2cdd0
• Always perform leave room sequence
  Dan Balasescu · 2025-12-11 20:07:36 +09:00
  bbdd70c843
• Merge pull request #35969 from peppy/delay-loading-animation

  Slightly delay song select leaderboard's loading placeholder to avoid flashing during local score retrieval

  Bartłomiej Dach · 2025-12-11 11:54:27 +01:00
  4250a54245
• Merge pull request #35966 from peppy/fix-muting-after-gameplay-with-bad-network

  Fix audio track potentially muting after gameplay with bad network

  Bartłomiej Dach · 2025-12-11 10:57:45 +01:00
  40fdb8662e
• Slightly delay song select leaderboard's loading placeholder to avoid flashing during local score retrieval

  Closes #35893.

  Dean Herbert · 2025-12-11 18:54:38 +09:00
  6ce8b0a4bc
• Remove audio adjustments immediately on gameplay hotkey overlays

  Closes #22164.

  Dean Herbert · 2025-12-11 17:57:07 +09:00
  b30047def6
• Merge pull request #35965 from peppy/debounce-seek-only-when-playing

  Fix editor not seeking smoothly when paused

  Bartłomiej Dach · 2025-12-11 08:54:36 +01:00
  0ffb86262f
• Debounce track seeks only when track is playing

  This fixes the editor no longer seeking smoothly when paused.
  
  Closes https://github.com/ppy/osu/issues/35963.

  Dean Herbert · 2025-12-11 16:00:13 +09:00
  f71eb4b980
• Update localisation analyser packages
  Dan Balasescu · 2025-12-11 13:53:09 +09:00
  1faf02e860
• Merge pull request #35843 from SollyBunny/master

  Make tracked leaderboard score yellow again

  Dean Herbert · 2025-12-11 13:50:59 +09:00
  d700375e55
• Fix dragging volume meter to adjust volume closing overlays if mouse is released outside of overlay content (#35940)

  * Add failing test
  
  * Fix dragging volume meter to adjust volume closing overlays if mouse is released outside of overlay content
  
  Fixes https://osu.ppy.sh/community/forums/topics/2159553.

  Bartłomiej Dach · 2025-12-11 13:47:08 +09:00
  095a67c24e
• Disable save replay on fail overlay when spectating (#35942)

  "Closes" https://github.com/ppy/osu/issues/35920.
  
  The button can't easily work anyway since it's not guaranteed that the
  spectating user has all of the frames of the replay (think entering
  spectate midway through a play).
  
  This matches the results screen in spectator too.

  Bartłomiej Dach · 2025-12-11 13:42:15 +09:00
  86054497d0
• Fix skin editor sometimes dropping anchor/origin specification on paste (#35957)

  * Add failing test for copy->paste not being idempotent
  
  * Ensure all elements on default skins use fixed anchors
  
  `UsesFixedAnchor` defaults to false, i.e. closest anchors. Combined with
  manual anchor / origin specs on some drawables, this would get default
  skins into impossible states wherein a drawable would use "closest
  anchor" but also explicitly specify anchor / origin that aren't closest,
  which horribly fails on attempting to copy and paste.
  
  Frankly shocked this has gone unnoticed for this long, and I regret not
  vetoing this "feature" more every time I see its tentacles spread to
  produce breakage of levels yet unseen.
  
  Does this commit contain major levels of suck? For sure. Do I have any
  better ideas that wouldn't consist of a multi-day rewrite or deletion of
  this "feature"? No.
  
  * Fix skin editor always applying closest anchor / origin on paste regardless of whether the component uses fixed anchor
  
  Self-explanatory. Should close https://github.com/ppy/osu/issues/29111
  along with previous commit.

  Bartłomiej Dach · 2025-12-11 13:40:48 +09:00
  c4f7dee82b
• Merge pull request #35958 from bdach/fix-storyboard-samples-not-playing-in-editor

  Fix storyboard samples not playing in editor

  Bartłomiej Dach · 2025-12-10 14:33:30 +01:00
  22825f6509
• Fix storyboard samples not playing in editor

  Closes https://github.com/ppy/osu/issues/35954.

  Bartłomiej Dach · 2025-12-10 11:20:50 +01:00
  691e8bcd05