24 Commits

• Fix local beatmap metadata not being cleared when previously selected beatmap is online (#36632)

  - Closes https://github.com/ppy/osu/issues/36584
  
  The last two commits could be either fixes to the issue above, but in a
  code quality perspective, the scheduler in `setLink()` seems unnecessary
  as the other set methods don't have it (other than making it run last)
  and the other commit is self explanatory.

  Joseph Madamba · 2026-02-09 09:55:36 +09:00
  0a4497db3c
• Fix code quality
  Bartłomiej Dach · 2025-10-13 10:19:19 +02:00
  a73c325235
• Attempt to ensure RealmAccess waits for the async read before disposing itself
  Bartłomiej Dach · 2025-10-13 09:27:21 +02:00
  97739c39e7
• Check for cancellation EVEN MORE aggressively
  Bartłomiej Dach · 2025-10-10 12:06:57 +02:00
  0b00191d71
• Attempt to abort realm accesses on disposal
  Bartłomiej Dach · 2025-10-10 10:30:31 +02:00
  0389da4559
• Remove redundant refresh calls
  Bartłomiej Dach · 2025-10-10 09:20:23 +02:00
  ca4c033b76
• Move realm refetches of beatmap in song select wedges off of update thread

  From local testing on release build (such that online beatmaps are
  accessible) with a large database it seems that maybe this'll help with
  recurrent complaints of 'stutters'.
  
  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Bartłomiej Dach · 2025-10-10 08:51:12 +02:00
  85bbe13aa9
• Pull up online beatmap set lookup to song select level to avoid two components doing the same fetch independently
  Bartłomiej Dach · 2025-08-22 14:25:21 +02:00
  d3ae20dd88
• Refresh realm before performing song select refetches following an online metadata lookup

  Probably closes https://github.com/ppy/osu/issues/34716
  
  Can't see any other cause, can reproduce the issue on master using
  manual db modifications via realm studio and it is not a consistent
  reproduction, so seems like an open-and-shut lack of refresh.

  Bartłomiej Dach · 2025-08-18 09:48:32 +02:00
  a393b3c6b1
• Adjust stereo shift effects for UI sounds to be less extreme
  Dean Herbert · 2025-07-30 19:35:26 +09:00
  0b11953b24
• Add SFX to Beatmap Metadata 'Wedges' popping in and out
  Jamie Taylor · 2025-07-26 00:17:13 +09:00
  f9b3e91349
• Add initial support for filtering by user tags in song select

  The way that this works is that it plugs into the online request to
  retrieve the beatmap set that the client is already performing, and
  stores user tag data to the local realm database.
  
  This means that for now user tags will only populate for beatmaps that
  the user has displayed on song select which is obviously subpar. I plan
  to follow this change up by adding user tag state dumps to `online.db`
  and using that data for initial tag population to make the majority case
  (ranked beatmaps) work.
  
  Note that several decisions were made here that are potential discussion
  points:
  
  - `RealmPopulatingOnlineLookupSource` is set up such that it can be the
    middle man / redirection point for similar flows that we need and we
    are currently missing, such as storing guest difficulty information,
    or storing the user's current best score on a beatmap (handy for rank
    achieved sorting / filtering / etc.)
  
  - The user tags are stored in `BeatmapMetadata` which breaks the
    longstanding assumption that you can arbitrarily pull out a metadata
    instance from any of the beatmaps in a set and get essentially the
    same object back.
  
    I've attempted to constrain this some by not adding user tags to
    the `IBeatmapMetadataInfo` interface through which `BeatmapSetInfo`
    exposes metadata further, but I warn in advance that this is
    a temporary state of affairs and I will make it worse in the future
    when `BeatmapMetadata.Author` becomes `Authors` plural in order to
    support guest mapper display (and direct guest difficulty submission).
  
  - The syntax for searching via user tags is chosen to mostly match web -
    it's `tag=`, with support for all of the string matching modes song
    select already has (bare word for substring, `""` quotes for phrase
    isolated by whitespace, `""!` for exact full match).

  Bartłomiej Dach · 2025-07-15 11:09:40 +02:00
  8cb81974eb
• Fix null reference in metadata wedge when accessing beatmap tags
  Salman Alshamrani · 2025-06-23 00:41:12 +03:00
  ef9fed47a9
• Add new strings to SongSelectStrings.cs
  diquoks · 2025-06-21 18:23:50 +03:00
  4661cb4818
• Use MarginPadding instead of leading space, change incorrect LocalisableString
  diquoks · 2025-06-21 12:35:02 +03:00
  acc4267a2d
• Use localised strings for SSV2
  diquoks · 2025-06-20 18:40:21 +03:00
  fd27d43814
• Fix clicking song select search links not working
  Dean Herbert · 2025-05-31 14:06:56 +09:00
  b650309706
• Show loading spinner underneath user tags during transitions
  Salman Alshamrani · 2025-05-20 23:52:40 +03:00
  135fc47766
• Add user tags support
  Salman Alshamrani · 2025-04-30 17:30:43 +09:00
  4d0925b85d
• Merge pull request #32957 from frenzibyte/metadata-fix-beatmap-local-diff-handling

  Fix incorrect handling of beatmap with local diffs in metadata wedge

  Dean Herbert · 2025-04-30 17:21:49 +09:00
  e03617b4b2
• Fix incorrect handling of beatmap with local diffs in metadata wedge

  Also hides ranking/failtime wedges on locally created difficulties

  Salman Alshamrani · 2025-04-30 16:13:37 +09:00
  959ab11862
• Fix metadata subwedges pop out transition back to front
  Salman Alshamrani · 2025-04-26 17:33:46 +03:00
  230daf7289
• Adjust tests and transitions
  Dean Herbert · 2025-04-23 16:23:37 +09:00
  883df07ff6
• Add beatmap metadata wedge
  Salman Alshamrani · 2025-04-18 06:43:36 -04:00
  856f907c86