h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2025-01-13 14:12:56 +08:00
Code Issues Releases Wiki Activity

Rename SuccessfulHitResult->LowestSuccessfulHitResult

Browse Source
This commit is contained in:
Ivan Pavluk 2018-12-12 13:24:58 +07:00
parent ffb91b4afc
commit e49e2fda9e
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
osu.Game.Rulesets.Taiko/Objects/TaikoHitWindows.cs
View File

@ -17,7 +17,7 @@ namespace osu.Game.Rulesets.Taiko.Objects
{ HitResult.Miss, (270, 190, 140) }, { HitResult.Miss, (270, 190, 140) },
}; };
protected override HitResult SuccessfulHitResult => HitResult.Good; protected override HitResult LowestSuccessfulHitResult => HitResult.Good;
public override bool IsHitResultAllowed(HitResult result) public override bool IsHitResultAllowed(HitResult result)
{ {

4
osu.Game/Rulesets/Objects/HitWindows.cs
View File

@ -53,7 +53,7 @@ namespace osu.Game.Rulesets.Objects
/// <summary> /// <summary>
/// The <see cref="HitResult"/> with the largest hit window that produces a successful hit. /// The <see cref="HitResult"/> with the largest hit window that produces a successful hit.
/// </summary> /// </summary>
protected virtual HitResult SuccessfulHitResult => HitResult.Meh; protected virtual HitResult LowestSuccessfulHitResult => HitResult.Meh;
/// <summary> /// <summary>
/// Check whether it is possible to achieve the provided <see cref="HitResult"/>. /// Check whether it is possible to achieve the provided <see cref="HitResult"/>.
@ -137,6 +137,6 @@ namespace osu.Game.Rulesets.Objects
/// </summary> /// </summary>
/// <param name="timeOffset">The time offset.</param> /// <param name="timeOffset">The time offset.</param>
/// <returns>Whether the <see cref="HitObject"/> can be hit at any point in the future from this time offset.</returns> /// <returns>Whether the <see cref="HitObject"/> can be hit at any point in the future from this time offset.</returns>
public bool CanBeHit(double timeOffset) => timeOffset <= HalfWindowFor(SuccessfulHitResult); public bool CanBeHit(double timeOffset) => timeOffset <= HalfWindowFor(LowestSuccessfulHitResult);
} }
} }