From e49e2fda9e3fdd8488a70010e3bd36e3a2d045c2 Mon Sep 17 00:00:00 2001 From: Ivan Pavluk Date: Wed, 12 Dec 2018 13:24:58 +0700 Subject: [PATCH] Rename SuccessfulHitResult->LowestSuccessfulHitResult --- osu.Game.Rulesets.Taiko/Objects/TaikoHitWindows.cs | 2 +- osu.Game/Rulesets/Objects/HitWindows.cs | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/osu.Game.Rulesets.Taiko/Objects/TaikoHitWindows.cs b/osu.Game.Rulesets.Taiko/Objects/TaikoHitWindows.cs index 2317d4cc90..2c207114da 100644 --- a/osu.Game.Rulesets.Taiko/Objects/TaikoHitWindows.cs +++ b/osu.Game.Rulesets.Taiko/Objects/TaikoHitWindows.cs @@ -17,7 +17,7 @@ namespace osu.Game.Rulesets.Taiko.Objects { HitResult.Miss, (270, 190, 140) }, }; - protected override HitResult SuccessfulHitResult => HitResult.Good; + protected override HitResult LowestSuccessfulHitResult => HitResult.Good; public override bool IsHitResultAllowed(HitResult result) { diff --git a/osu.Game/Rulesets/Objects/HitWindows.cs b/osu.Game/Rulesets/Objects/HitWindows.cs index c75e914d2d..cf8769a105 100644 --- a/osu.Game/Rulesets/Objects/HitWindows.cs +++ b/osu.Game/Rulesets/Objects/HitWindows.cs @@ -53,7 +53,7 @@ namespace osu.Game.Rulesets.Objects /// /// The with the largest hit window that produces a successful hit. /// - protected virtual HitResult SuccessfulHitResult => HitResult.Meh; + protected virtual HitResult LowestSuccessfulHitResult => HitResult.Meh; /// /// Check whether it is possible to achieve the provided . @@ -137,6 +137,6 @@ namespace osu.Game.Rulesets.Objects /// /// The time offset. /// Whether the can be hit at any point in the future from this time offset. - public bool CanBeHit(double timeOffset) => timeOffset <= HalfWindowFor(SuccessfulHitResult); + public bool CanBeHit(double timeOffset) => timeOffset <= HalfWindowFor(LowestSuccessfulHitResult); } }