h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2026-05-27 00:20:50 +08:00
Code Issues Releases Wiki Activity

Expand settings in ReplayPlayer by default (#36308)

Browse Source 
~i recently saw an suggestion to do this, but don't remember where~

- addresses https://github.com/ppy/osu/discussions/36189

i think it's logical, since the settings have been displayed in a
separate overlay for more than six months, and not on top of the
gameplay itself, and for example, it can be difficult to expand section
on phones

| master | pr |
|-|-|
| <img width="1920" height="1080" alt="osu_2026-01-12_09-40-23"
src="https://github.com/user-attachments/assets/35d15ce6-ce12-4a9a-be4e-d72043dfb91a"
/> | <img width="1920" height="1080" alt="osu_2026-01-12_09-39-40"
src="https://github.com/user-attachments/assets/225d75db-1719-48dc-a65f-16272cca8295"
/> |
This commit is contained in:
Denis Titovets
2026-01-12 18:03:20 +03:00
committed by GitHub
Unverified
parent a81a77c60f
commit a8989eb117
2 changed files with 2 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
osu.Game/Screens/Play/HUD/PlayerSettingsOverlay.cs
+1 -7
View File
@@ -21,8 +21,6 @@ namespace osu.Game.Screens.Play.HUD
{
public partial class PlayerSettingsOverlay : ExpandingContainer
{
public VisualSettings VisualSettings { get; private set; }
private const float padding = 10;
public const float EXPANDED_WIDTH = player_settings_width + padding * 2;
@@ -66,11 +64,7 @@ namespace osu.Game.Screens.Play.HUD
Direction = FillDirection.Vertical,
Spacing = new Vector2(0, 20),
Margin = new MarginPadding(padding),
Children = new PlayerSettingsGroup[]
{
VisualSettings = new VisualSettings { Expanded = { Value = false } },
new AudioSettings { Expanded = { Value = false } }
}
Children = new PlayerSettingsGroup[] { new VisualSettings(), new AudioSettings() }
});
// For future consideration, this icon should probably not exist.
osu.Game/Screens/Play/ReplayPlayer.cs
+1 -5
View File
@@ -77,11 +77,7 @@ namespace osu.Game.Screens.Play
/// Add a settings group to the HUD overlay. Intended to be used by rulesets to add replay-specific settings.
/// </summary>
/// <param name="settings">The settings group to be shown.</param>
public void AddSettings(PlayerSettingsGroup settings) => Schedule(() =>
{
settings.Expanded.Value = false;
HUDOverlay.PlayerSettingsOverlay.Add(settings);
});
public void AddSettings(PlayerSettingsGroup settings) => Schedule(() => HUDOverlay.PlayerSettingsOverlay.Add(settings));
[BackgroundDependencyLoader]
private void load(OsuConfigManager config)