h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2024-05-14 22:40:33 +08:00
Code Issues Releases Wiki Activity

Fix code quality issues

Browse Source
This commit is contained in:
Bartłomiej Dach 2024-03-26 10:55:49 +01:00
parent 6fa663c8ca
commit 9b923b1909
No known key found for this signature in database
6 changed files with 10 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
osu.Game.Rulesets.Catch.Tests/Editor/Checks/CheckCatchAbnormalDifficultySettingsTest.cs
View File

@ -17,7 +17,7 @@ namespace osu.Game.Rulesets.Catch.Tests.Editor.Checks
{ {
private CheckCatchAbnormalDifficultySettings check = null!; private CheckCatchAbnormalDifficultySettings check = null!;
private IBeatmap beatmap = new Beatmap<HitObject>(); private readonly IBeatmap beatmap = new Beatmap<HitObject>();
[SetUp] [SetUp]
public void Setup() public void Setup()
@ -25,7 +25,7 @@ namespace osu.Game.Rulesets.Catch.Tests.Editor.Checks
check = new CheckCatchAbnormalDifficultySettings(); check = new CheckCatchAbnormalDifficultySettings();
beatmap.BeatmapInfo.Ruleset = new CatchRuleset().RulesetInfo; beatmap.BeatmapInfo.Ruleset = new CatchRuleset().RulesetInfo;
beatmap.Difficulty = new BeatmapDifficulty() beatmap.Difficulty = new BeatmapDifficulty
{ {
ApproachRate = 5, ApproachRate = 5,
CircleSize = 5, CircleSize = 5,

2
osu.Game.Rulesets.Mania.Tests/Editor/Checks/CheckKeyCountTest.cs
View File

@ -23,7 +23,7 @@ namespace osu.Game.Rulesets.Mania.Tests.Editor.Checks
{ {
check = new CheckKeyCount(); check = new CheckKeyCount();
beatmap = new Beatmap<HitObject>() beatmap = new Beatmap<HitObject>
{ {
BeatmapInfo = new BeatmapInfo BeatmapInfo = new BeatmapInfo
{ {

4
osu.Game.Rulesets.Mania.Tests/Editor/Checks/CheckManiaAbnormalDifficultySettingsTest.cs
View File

@ -17,7 +17,7 @@ namespace osu.Game.Rulesets.Mania.Tests.Editor.Checks
{ {
private CheckManiaAbnormalDifficultySettings check = null!; private CheckManiaAbnormalDifficultySettings check = null!;
private IBeatmap beatmap = new Beatmap<HitObject>(); private readonly IBeatmap beatmap = new Beatmap<HitObject>();
[SetUp] [SetUp]
public void Setup() public void Setup()
@ -25,7 +25,7 @@ namespace osu.Game.Rulesets.Mania.Tests.Editor.Checks
check = new CheckManiaAbnormalDifficultySettings(); check = new CheckManiaAbnormalDifficultySettings();
beatmap.BeatmapInfo.Ruleset = new ManiaRuleset().RulesetInfo; beatmap.BeatmapInfo.Ruleset = new ManiaRuleset().RulesetInfo;
beatmap.Difficulty = new BeatmapDifficulty() beatmap.Difficulty = new BeatmapDifficulty
{ {
OverallDifficulty = 5, OverallDifficulty = 5,
DrainRate = 5, DrainRate = 5,

4
osu.Game.Rulesets.Osu.Tests/Editor/Checks/CheckOsuAbnormalDifficultySettingsTest.cs
View File

@ -17,14 +17,14 @@ namespace osu.Game.Rulesets.Osu.Tests.Editor.Checks
{ {
private CheckOsuAbnormalDifficultySettings check = null!; private CheckOsuAbnormalDifficultySettings check = null!;
private IBeatmap beatmap = new Beatmap<HitObject>(); private readonly IBeatmap beatmap = new Beatmap<HitObject>();
[SetUp] [SetUp]
public void Setup() public void Setup()
{ {
check = new CheckOsuAbnormalDifficultySettings(); check = new CheckOsuAbnormalDifficultySettings();
beatmap.Difficulty = new BeatmapDifficulty() beatmap.Difficulty = new BeatmapDifficulty
{ {
ApproachRate = 5, ApproachRate = 5,
CircleSize = 5, CircleSize = 5,

1
osu.Game.Rulesets.Osu/Edit/Checks/CheckOsuAbnormalDifficultySettings.cs
View File

@ -11,6 +11,7 @@ namespace osu.Game.Rulesets.Osu.Edit.Checks
public class CheckOsuAbnormalDifficultySettings : CheckAbnormalDifficultySettings public class CheckOsuAbnormalDifficultySettings : CheckAbnormalDifficultySettings
{ {
public override CheckMetadata Metadata => new CheckMetadata(CheckCategory.Settings, "Checks osu relevant settings"); public override CheckMetadata Metadata => new CheckMetadata(CheckCategory.Settings, "Checks osu relevant settings");
public override IEnumerable<Issue> Run(BeatmapVerifierContext context) public override IEnumerable<Issue> Run(BeatmapVerifierContext context)
{ {
var diff = context.Beatmap.Difficulty; var diff = context.Beatmap.Difficulty;

4
osu.Game.Rulesets.Taiko.Tests/Editor/Checks/CheckTaikoAbnormalDifficultySettingsTest.cs
View File

@ -17,7 +17,7 @@ namespace osu.Game.Rulesets.Taiko.Tests.Editor.Checks
{ {
private CheckTaikoAbnormalDifficultySettings check = null!; private CheckTaikoAbnormalDifficultySettings check = null!;
private IBeatmap beatmap = new Beatmap<HitObject>(); private readonly IBeatmap beatmap = new Beatmap<HitObject>();
[SetUp] [SetUp]
public void Setup() public void Setup()
@ -25,7 +25,7 @@ namespace osu.Game.Rulesets.Taiko.Tests.Editor.Checks
check = new CheckTaikoAbnormalDifficultySettings(); check = new CheckTaikoAbnormalDifficultySettings();
beatmap.BeatmapInfo.Ruleset = new TaikoRuleset().RulesetInfo; beatmap.BeatmapInfo.Ruleset = new TaikoRuleset().RulesetInfo;
beatmap.Difficulty = new BeatmapDifficulty() beatmap.Difficulty = new BeatmapDifficulty
{ {
OverallDifficulty = 5, OverallDifficulty = 5,
}; };