h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2026-06-06 13:54:26 +08:00
Code Issues Releases Wiki Activity

Merge pull request #28905 from mcendu/no-release-hold-light-fix

Browse Source 
Fix hold note light lingering with No Release
This commit is contained in:
Dan Balasescu
2024-07-18 18:42:16 +09:00
committed by GitHub
Unverified
parent 3a1c05337d 00ed7a7a2f
commit 6be9ce548d
1 changed files with 7 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
osu.Game.Rulesets.Mania/Objects/Drawables/DrawableHoldNote.cs
+7 -4
View File
@@ -268,11 +268,14 @@ namespace osu.Game.Rulesets.Mania.Objects.Drawables
ApplyMaxResult();
else
MissForcefully();
}
// Make sure that the hold note is fully judged by giving the body a judgement.
if (Tail.AllJudged && !Body.AllJudged)
Body.TriggerResult(Tail.IsHit);
// Make sure that the hold note is fully judged by giving the body a judgement.
if (!Body.AllJudged)
Body.TriggerResult(Tail.IsHit);
// Important that this is always called when a result is applied.
endHold();
}
}
public override void MissForcefully()