1
0
mirror of https://github.com/ppy/osu.git synced 2024-12-21 15:33:22 +08:00
osu-lazer/osu.Game.Rulesets.Osu/Edit/Checks/CheckOffscreenObjects.cs

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

118 lines
4.3 KiB
C#
Raw Normal View History

2021-04-10 19:03:16 +08:00
// Copyright (c) ppy Pty Ltd <contact@ppy.sh>. Licensed under the MIT Licence.
// See the LICENCE file in the repository root for full licence text.
2022-06-17 15:37:17 +08:00
#nullable disable
2021-04-10 19:03:16 +08:00
using System.Collections.Generic;
using osu.Game.Rulesets.Edit;
2021-04-10 19:03:16 +08:00
using osu.Game.Rulesets.Edit.Checks.Components;
using osu.Game.Rulesets.Osu.Objects;
using osuTK;
namespace osu.Game.Rulesets.Osu.Edit.Checks
{
public class CheckOffscreenObjects : ICheck
2021-04-10 19:03:16 +08:00
{
// A close approximation for the bounding box of the screen in gameplay on 4:3 aspect ratio.
// Uses gameplay space coordinates (512 x 384 playfield / 640 x 480 screen area).
// See https://github.com/ppy/osu/pull/12361#discussion_r612199777 for reference.
2021-04-10 19:03:16 +08:00
private const int min_x = -67;
private const int min_y = -60;
private const int max_x = 579;
private const int max_y = 428;
// The amount of milliseconds to step through a slider path at a time
// (higher = more performant, but higher false-negative chance).
private const int path_step_size = 5;
2021-04-12 22:37:47 +08:00
public CheckMetadata Metadata { get; } = new CheckMetadata(CheckCategory.Compose, "Offscreen hitobjects");
2021-04-10 19:03:16 +08:00
2021-04-12 23:12:37 +08:00
public IEnumerable<IssueTemplate> PossibleTemplates => new IssueTemplate[]
{
new IssueTemplateOffscreenCircle(this),
new IssueTemplateOffscreenSlider(this)
};
2021-05-13 17:24:22 +08:00
public IEnumerable<Issue> Run(BeatmapVerifierContext context)
2021-04-10 19:03:16 +08:00
{
2021-05-13 17:24:22 +08:00
foreach (var hitobject in context.Beatmap.HitObjects)
2021-04-10 19:03:16 +08:00
{
switch (hitobject)
{
case Slider slider:
{
foreach (var issue in sliderIssues(slider))
yield return issue;
break;
}
case HitCircle circle:
{
if (isOffscreen(circle.StackedPosition, circle.Radius))
2021-04-12 23:12:37 +08:00
yield return new IssueTemplateOffscreenCircle(this).Create(circle);
2021-04-10 19:03:16 +08:00
break;
}
}
}
}
/// <summary>
/// Steps through points on the slider to ensure the entire path is on-screen.
/// Returns at most one issue.
/// </summary>
/// <param name="slider">The slider whose path to check.</param>
/// <returns></returns>
private IEnumerable<Issue> sliderIssues(Slider slider)
{
for (int i = 0; i < slider.Distance; i += path_step_size)
{
double progress = i / slider.Distance;
Vector2 position = slider.StackedPositionAt(progress);
if (!isOffscreen(position, slider.Radius))
continue;
// `SpanDuration` ensures we don't include reverses.
double time = slider.StartTime + progress * slider.SpanDuration;
2021-04-12 23:12:37 +08:00
yield return new IssueTemplateOffscreenSlider(this).Create(slider, time);
2021-04-10 19:03:16 +08:00
yield break;
}
// Above loop may skip the last position in the slider due to step size.
if (!isOffscreen(slider.StackedEndPosition, slider.Radius))
yield break;
2021-04-12 23:12:37 +08:00
yield return new IssueTemplateOffscreenSlider(this).Create(slider, slider.EndTime);
2021-04-10 19:03:16 +08:00
}
private bool isOffscreen(Vector2 position, double radius)
{
return position.X - radius < min_x || position.X + radius > max_x ||
position.Y - radius < min_y || position.Y + radius > max_y;
}
2021-04-12 22:36:10 +08:00
public class IssueTemplateOffscreenCircle : IssueTemplate
2021-04-12 22:36:10 +08:00
{
public IssueTemplateOffscreenCircle(ICheck check)
: base(check, IssueType.Problem, "This circle goes offscreen on a 4:3 aspect ratio.")
2021-04-12 22:36:10 +08:00
{
}
public Issue Create(HitCircle circle) => new Issue(circle, this);
}
public class IssueTemplateOffscreenSlider : IssueTemplate
2021-04-12 22:36:10 +08:00
{
public IssueTemplateOffscreenSlider(ICheck check)
: base(check, IssueType.Problem, "This slider goes offscreen here on a 4:3 aspect ratio.")
2021-04-12 22:36:10 +08:00
{
}
public Issue Create(Slider slider, double offscreenTime) => new Issue(slider, this) { Time = offscreenTime };
}
2021-04-10 19:03:16 +08:00
}
}