1
0
mirror of https://github.com/ppy/osu.git synced 2026-05-13 20:33:35 +08:00
Files
osu-lazer/osu.Game.Tests
T
Bartłomiej Dach f1a9be4a19 Refactor audio preview logic in ranked play cards to match expectations while hopefully not looking buggy anymore (#37463)
RFC.

See https://github.com/ppy/osu/pull/37453#issuecomment-4289403735 for
why.

Of note:

- To facilitate mutual exclusivity of playback `PlayerHandOfCards`
maintains a bindable pointing at the currently playing song preview.
- Because of how card drawables are passed between multiple parenting
drawables, some of which are and some of which are not
`PlayerHandOfCards` instances, DI fails horribly at working with this
bindable unless it is manually managed. See relevant overrides in
`PlayerHandOfCards`.
- I renamed one of the overloads of `HandOfCards.RemoveCard()` to
`DetachCard()` because I found the fact that there are two overloads of
one method that do WILDLY DIFFERENT THINGS utterly *asinine*. (One
overload scrapes the `RankedPlayCard` out for you to plop elsewhere. One
*drops it on the floor entirely*.)

This took way too long to write.
f1a9be4a19 · 2026-04-22 12:48:45 +09:00
History
..
2026-03-17 03:58:02 +09:00
2023-06-24 01:00:03 +09:00
2026-03-17 03:58:02 +09:00
2026-03-19 00:05:52 +09:00
2026-03-17 03:58:02 +09:00
2026-04-17 17:06:24 +09:00
2026-03-17 03:58:02 +09:00
2025-03-18 16:24:01 +09:00
2026-03-17 03:58:02 +09:00
2026-03-17 03:58:02 +09:00
2023-05-02 11:55:05 +03:00
2026-03-17 03:58:02 +09:00
2026-03-17 03:58:02 +09:00