osu-lazer

mirror of https://github.com/ppy/osu.git synced 2026-05-22 20:20:25 +08:00

Files

T

Bartłomiej Dach 7e557152fb Fix relax mod not considering full follow area radius when automatically holding sliders

Closes https://github.com/ppy/osu/issues/25947.

Regressed in https://github.com/ppy/osu/pull/25776 with the changes to
`DrawableSliderBall`.

I would have liked to include tests, but relax mod is a bit untestable,
because it disengages completely in the presence of a replay:

	https://github.com/ppy/osu/blob/7e09164d7084265536570ac7036d7244934b651c/osu.Game.Rulesets.Osu/Mods/OsuModRelax.cs#L49-L58

Additionally, `RulesetInputManager` disengages completely from parent
inputs when there is a replay active:

	https://github.com/ppy/osu/blob/7e09164d7084265536570ac7036d7244934b651c/osu.Game/Rulesets/UI/RulesetInputManager.cs#L116

which means there is really no easy way to control positional input
while still having relax logic work. So I'm hoping the fix could be
considered obvious enough to not require test coverage.

7e557152fb · 2023-12-22 12:50:42 +01:00

History

Connections

Automated pass

2023-06-24 01:00:03 +09:00

DrawableHitCircle.cs

Refactor all slider input into SliderInputManager

2023-12-15 16:13:32 +09:00

DrawableOsuHitObject.cs

Refactor all slider input into SliderInputManager

2023-12-15 16:13:32 +09:00

DrawableOsuJudgement.cs