mirror of
https://github.com/ppy/osu.git
synced 2026-06-13 05:13:49 +08:00
Kenny Lorin
e484cf4553
<details> <summary> Greetings </summary> Hello! This is my first PR for `osu!`, I hope you'll welcome me with as much enthusiasm as I have opening this! The following PR comes from some frustration on my end when using song select. I have not found issues or opened/closed PRs that address this topic, so I thought I'd shoot my shot! To give some more context, I've been pretty inactive on `osu!` and playing almost exclusively songs I imported from stable. From what I understand, this makes all my beatmapsets have the same `DateAdded`. This triggers the `ID` fallback comparison, which, as noted in the code comments, is essentially random. Writing this, I realize that I haven't checked if this addresses a behavior that changes from stable to lazer, or something that was always here! </details> This PR aims at making a small part of song-select sorting more intuitive by using the song's title as a fallback sorting method. My feeling is that `DateAdded` "looks more random" than the title, especially in cases like mine where the `DateAdded` fallback-comparison outputs `0`. The implementation is the same as `Artist` with `Title` fallback. <details> <summary> Screenshots </summary> On my installed osu version: sorting by `BPM` puts "Asymetry" in the middle of two mapsets of "Snow halation" <img width="1053" height="841" alt="image" src="https://github.com/user-attachments/assets/00a89251-5695-43b5-a388-248404c24f02" /> After the patch, mapsets with the same BPM will also be sorted by song title, for example at 173 BPM: <img width="1033" height="1177" alt="image" src="https://github.com/user-attachments/assets/de7de0b9-f2aa-4e81-80f8-459bfcf6dc95" /> And further below: <img width="1050" height="929" alt="image" src="https://github.com/user-attachments/assets/dfdee7ad-7b5b-45c7-abfe-22ce3c561dd1" /> </details> --------- Co-authored-by: Kenny Lorin <kenny.lorin@enioka.com> Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
e484cf4553
·
2026-06-11 13:21:42 +02:00
History