1
0
mirror of https://github.com/ppy/osu.git synced 2024-12-17 23:42:55 +08:00
osu-lazer/osu.Game/Screens/OnlinePlay/Components
Bartłomiej Dach 0d2a47167c
Fix crash on calculating playlist duration when rate-changing mods are present
Regressed in https://github.com/ppy/osu/pull/28399.

To reproduce, enter a playlist that has an item with a rate-changing mod
(rather than create it yourself).

This is happening because `APIRuleset` has `CreateInstance()`
unimplemented:

    b4cefe0cc2/osu.Game/Online/API/Requests/Responses/APIBeatmap.cs (L159)

and only triggers when the playlist items in question originate from
web.

This is why it is bad to have interface implementations throw outside of
maybe mock implementations for tests. `CreateInstance()` is a scourge
elsewhere in general, we need way less of it in the codebase (because
while convenient, it's also problematic to implement in online contexts,
and also expensive because reflection).
2024-06-25 11:28:10 +02:00
..
BeatmapDetailAreaPlaylistTabItem.cs Automated pass 2023-06-24 01:00:03 +09:00
BeatmapTitle.cs Automated pass 2023-06-24 01:00:03 +09:00
DisableableTabControl.cs Automated pass 2023-06-24 01:00:03 +09:00
DrawableGameType.cs Automated pass 2023-06-24 01:00:03 +09:00
ListingPollingComponent.cs Hide daily challenge from playlists listing 2024-06-10 13:12:21 +02:00
MatchBeatmapDetailArea.cs Apply padding to GridContainers directly 2024-02-20 23:18:37 +03:00
OnlinePlayBackgroundScreen.cs Partial everything 2022-11-27 00:00:27 +09:00
OnlinePlayBackgroundSprite.cs Partial everything 2022-11-27 00:00:27 +09:00
OverlinedHeader.cs Automated pass 2023-06-24 01:00:03 +09:00
OverlinedPlaylistHeader.cs Fix crash on calculating playlist duration when rate-changing mods are present 2024-06-25 11:28:10 +02:00
ParticipantCountDisplay.cs Partial everything 2022-11-27 00:00:27 +09:00
ParticipantsDisplay.cs Increase the minimum size of the scroll bar 2023-07-02 00:04:56 +09:00
ParticipantsList.cs Rename variables and mak seconary tooltip type work again 2023-11-10 11:52:34 +09:00
PlaylistItemBackground.cs Refactor IWorkingBeatmap.Background to GetBackground() 2023-06-08 16:19:32 +09:00
ReadyButton.cs Automated pass 2023-06-24 01:00:03 +09:00
RoomLocalUserInfo.cs Partial everything 2022-11-27 00:00:27 +09:00
RoomManager.cs Update R# + fix inspections 2024-02-02 21:00:28 +09:00
RoomPollingComponent.cs Automated pass 2023-06-24 01:00:03 +09:00
SelectionPollingComponent.cs Partial everything 2022-11-27 00:00:27 +09:00
StarRatingRangeDisplay.cs Fix display update condition 2023-05-14 12:09:15 +02:00
StatusColouredContainer.cs Partial everything 2022-11-27 00:00:27 +09:00