mirror of
https://github.com/ppy/osu.git
synced 2026-05-27 01:21:31 +08:00
Bartłomiej Dach
d89d6ed13f
- Closes https://github.com/ppy/osu/issues/37884 - Closes https://github.com/ppy/osu/pull/37890 Due to lack of population of `Storyboard.Beatmap` and `Storyboard.BeatmapInfo` post-decoding, `LegacyBeatmapExporter` would completely drop background specifications on exported beatmap packages. This affects both direct legacy export to file (`.osz`) as well as beatmap submission. I will not pretend that the API here is optimal but I do not see very easy opportunities to curtail misuse. Storyboards can be treated as either parts of a beatmap or standalone entities, and if a requirement is added to forcibly provide a beatmap and its info when encoding out a storyboard, I also foresee a requirement to bypass this later when design mode is implemented, which would be a return to square one. There is likely room for cleanup around `Storyboard` to maybe make this nicer (remove passing of both `Beatmap` and `BeatmapInfo` and just pass `Beatmap` instead, maybe shuffle some properties from `Beatmap` to `Storyboard` to remove the requirement of having to bolt the beatmap on to begin with). I leave voicing opinions on that, and how soon that should be done, to reviewers. My primary intent at this time is to hotfix a major issue in a released build. The external editing feature is not involved in this bug and any attempts to claim so are misdirections.
d89d6ed13f
·
2026-05-24 20:55:53 +09:00
History