1
0
mirror of https://github.com/ppy/osu.git synced 2024-12-16 03:02:53 +08:00
osu-lazer/osu.Game/Screens/Select/Carousel
Dean Herbert cd31cff8cd Fix event subscriptions not being cleaned up in DrawableCarouselBeatmap
The handling of cleanup is performed only the `Item_Set` method. This
was already correctly called for `DrawableCarouselBeatmapSet`, but not
for the class in question here.

This would cause runaway memory usage at song select when opening many
beatmaps to show their difficulties. For simplicity, we don't yet pool
these (and generate the drawables each time a set is opened) which isn't
great but likely will be improved upon when we update the visual /
filtering of the carousel. But this simplicity caused the memory usage
to blow out until exiting back to the main menu when cleanup would
finally occur.
2023-05-03 18:41:30 +09:00
..
CarouselBeatmap.cs Move filter matching code into own method to simplify early returns 2023-03-07 17:24:17 +09:00
CarouselBeatmapSet.cs Use nullable comparison helper method instead of manual implementation 2023-03-06 15:16:32 +09:00
CarouselGroup.cs remove unnecessary usages of nullable forgiveness, add asserts for debugging 2023-01-09 18:36:55 +01:00
CarouselGroupEagerSelect.cs Remove nullable disabling in carousel 2023-01-08 19:02:48 +01:00
CarouselHeader.cs Refactor HoverSampleDebounceComponent to inherit Component 2023-02-03 00:29:25 -08:00
CarouselItem.cs Remove boxing overhead in CarouselItem comparator 2023-01-10 18:35:06 +01:00
DrawableCarouselBeatmap.cs Fix event subscriptions not being cleaned up in DrawableCarouselBeatmap 2023-05-03 18:41:30 +09:00
DrawableCarouselBeatmapSet.cs Fix whitespace around Debug.Assert 2023-01-10 18:03:17 +09:00
DrawableCarouselItem.cs Revert Debug.Assert 2023-01-10 17:52:28 +09:00
FilterableDifficultyIcon.cs Remove nullable disabling in carousel 2023-01-08 19:02:48 +01:00
GroupedDifficultyIcon.cs Remove nullable disabling in carousel 2023-01-08 19:02:48 +01:00
SetPanelBackground.cs Remove nullable disabling in carousel 2023-01-08 19:02:48 +01:00
SetPanelContent.cs Fix intermittent failure in certain beatmap carousel tests 2023-01-13 19:41:44 +03:00
TopLocalRank.cs Update reference 2023-02-07 11:52:47 +03:00
UpdateBeatmapSetButton.cs Partial everything 2022-11-27 00:00:27 +09:00
UpdateLocalConfirmationDialog.cs make ResetConfirmDialog properly utilise its parent's logic 2023-03-05 20:57:26 +01:00