1
0
mirror of https://github.com/ppy/osu.git synced 2025-01-19 07:43:01 +08:00
osu-lazer/osu.Game/Overlays/BeatmapSet/Scores
Bartłomiej Dach 1febed66cf
Fix top score statistics section total score display being terminally broken
Closes https://github.com/ppy/osu/issues/31038.

If you don't realise why this does anything, realise this: the drawable
creation callback runs for every created sprite text in the text flow.
ANd the created sprite texts are split by whitespace. And Russian /
Ukrainian / Polish etc. use spaces as thousands separators.
So on those languages the first encountered part of the score would
duplicate itself to the remaining parts.

I'm actively convinced it was _more difficult_ to produce what was in
place in `master` than to do it properly. Why did `TextColumn` even have
`LocalisableString Text` and `Bindable<string> Current` next to each
other?????
2024-12-09 23:51:57 +09:00
..
DrawableTopScore.cs Partial everything 2022-11-27 00:00:27 +09:00
NoScoresPlaceholder.cs Automated pass 2023-06-24 01:00:03 +09:00
NotSupporterPlaceholder.cs Automated pass 2023-06-24 01:00:03 +09:00
ScoreboardTime.cs Automated pass 2023-06-24 01:00:03 +09:00
ScoresContainer.cs Use ChildrenOfType<> to get ScoreTable to test 2024-10-14 16:11:58 +02:00
ScoreTable.cs Only keep track of the names of hit results to display in a ScoreTable 2024-10-14 16:55:07 +02:00
ScoreTableRowBackground.cs Automated pass 2023-06-24 01:00:03 +09:00
TopScoreStatisticsSection.cs Fix top score statistics section total score display being terminally broken 2024-12-09 23:51:57 +09:00
TopScoreUserSection.cs Always show placeholder on unknown / missing country 2024-05-10 22:45:59 +08:00