mirror of
https://github.com/ppy/osu.git
synced 2025-01-18 05:42:56 +08:00
cbb6930f76
CreateCircle() lends itself to a few issues: - It can't be used for drum roll ticks unless it returned a Container instead, at which point the method loses its meaning, and I would rather that constructed in the ctor. - Writing `return Accented ? new AccentedCirclePiece() : new CirclePiece()` in two places as the body of this method feels wrong - it's something I would expect to be taken care of in the base DrawableTaikoHitObject, but that leads back to #1. - Swells don't have an AccentedCirclePiece, so #2 becomes more problematic. |
||
---|---|---|
.. | ||
Pieces | ||
DrawableSwell.cs | ||
DrawableTaikoHitObject.cs |