mirror of
https://github.com/ppy/osu.git
synced 2025-02-07 18:13:21 +08:00
c93b87583a
No issue thread for this again. Reported internally on discord: https://discord.com/channels/90072389919997952/1259818301517725707/1320420768814727229 Placing this logic in the beatmap processor, as a post-processing step, means that the new combo force won't be visible until a placement has been committed. That can be seen as subpar, but I tried putting this logic in the placement and it sucked anyway: - While the combo number was correct, the colour looked off, because it would use the same combo colour as the already-placed objects after said break, which would only cycle to the next, correct one on placement - Not all scenarios can be handled in the placement. Refer to one of the test cases added in the preceding commit, wherein two objects are placed far apart from each other, and an automated break is inserted between them - the placement has no practical way of knowing whether it's going to have a break inserted automatically before it or not. |
||
|---|---|---|
| .. | ||
| Components | ||
| Compose | ||
| Design | ||
| GameplayTest | ||
| Setup | ||
| Timing | ||
| Verify | ||
| BackgroundDimMenuItem.cs | ||
| BeatmapEditorChangeHandler.cs | ||
| BindableBeatDivisor.cs | ||
| BottomBar.cs | ||
| ClipboardContent.cs | ||
| CreateNewDifficultyDialog.cs | ||
| DeleteDifficultyConfirmationDialog.cs | ||
| Editor.cs | ||
| EditorBeatmap.cs | ||
| EditorBeatmapProcessor.cs | ||
| EditorBeatmapSkin.cs | ||
| EditorChangeHandler.cs | ||
| EditorClipboard.cs | ||
| EditorClock.cs | ||
| EditorLoader.cs | ||
| EditorRoundedScreenSettings.cs | ||
| EditorRoundedScreenSettingsSection.cs | ||
| EditorScreen.cs | ||
| EditorScreenMode.cs | ||
| EditorScreenWithTimeline.cs | ||
| EditorSkinProvidingContainer.cs | ||
| EditorState.cs | ||
| ExternalEditScreen.cs | ||
| HitAnimationsMenuItem.cs | ||
| IEditorChangeHandler.cs | ||
| LegacyEditorBeatmapPatcher.cs | ||
| ManualBreakPeriod.cs | ||
| PromptForSaveDialog.cs | ||
| ReloadEditorDialog.cs | ||
| SaveRequiredPopupDialog.cs | ||
| TableHeaderText.cs | ||
| TransactionalCommitComponent.cs | ||
| WaveformOpacityMenuItem.cs | ||