1
0
mirror of https://github.com/ppy/osu.git synced 2026-05-18 05:39:53 +08:00
Files
osu-lazer/osu.Game.Tests/Visual/SongSelect
T
Dean Herbert 08c02e29b9 Fix song select scrolling performance when user has many beatmaps loaded (#37666)
Also fixes wrong rank showing briefly in some scenarios.

---

I'm quite confused why the overhead is in the post-async-filter
collection access, but it is. It occurs when using `MaxBy` (realm
snapshot creation), but also when calling `.Count` on the collection, or
even just accessing `sender[0]`. I tried everything, and ended up
settling on simplifying the realm part enough that we can do
post-filtering without much sweat or mess.

Before:


https://github.com/user-attachments/assets/59aed895-03ed-4923-9515-9a5426156f7e

After:


https://github.com/user-attachments/assets/9a37f34a-c955-45bf-877f-89f248d8ea72

Tested using [this realm](https://screvillshot.s-ul.eu/YJUJ4SR1).

- Closes https://github.com/ppy/osu/issues/37574.
- Closes https://github.com/ppy/osu/issues/37661.
08c02e29b9 · 2026-05-08 13:25:55 +02:00
History
..