1
0
mirror of https://github.com/ppy/osu.git synced 2024-09-22 18:07:24 +08:00
osu-lazer/osu.Game/Overlays/FirstRunSetup
Bartłomiej Dach 46d3220c07
Isolate sample screens from global mods bindable
Fixes scenario wherein entering the first run setup overlay, exiting at
the "UI scale" step (which shows a song select), then moving to actua
song select and trying to select a mod would lead to a crash.

The crash was caused by two active mod screen instances attempting to
swap the global mod bindable's mod instances for ones they owned. This
logic - while generally problematic and hard to maintain - was fixing
several issues with mod reference management and setting copying, so I'm
letting it live another day.

This change will mean that the song select preview on the "UI scale"
step will not receive the same mods that the actual game has enabled.
That said, it already doesn't use the same beatmap or ruleset, so this
looks fine to break.
2022-05-07 21:44:58 +02:00
..
FirstRunSetupScreen.cs Merge branch 'master' into add-tutorial 2022-04-29 11:25:17 +09:00
ScreenBeatmaps.cs Fix rider failures in nullable 2022-04-28 20:15:40 +09:00
ScreenBehaviour.cs Merge branch 'master' into first-run-behaviour-screen 2022-04-29 00:55:30 +02:00
ScreenUIScale.cs Isolate sample screens from global mods bindable 2022-05-07 21:44:58 +02:00
ScreenWelcome.cs Add header text to first run setup screens 2022-04-26 16:22:41 +09:00