mirror of
https://github.com/ppy/osu.git
synced 2026-05-16 01:22:52 +08:00
b76a7e1bb6
This commit rearranges the contents of `ShearedButtons` to be more independent of each other in regards to sizing. Thanks to that, the custom logic related to enabling autosizing is no longer necessary. Witdh and height are no longer set via the constructor, and can be freely configured using the initializer syntax. Additionally, this allows the button to use relative sizing without having to resort to any hackery with `Size` (this will come in handy for me when implementing the new footer on multiplayer screens). Given that most of the `ShearedButton`s currently in use set their width explicitly, I did not set `AutoSizeAxes = Axes.X` like it would be by default previously. Instead it is set on the only two such buttons (show converts/selected mods on ssv2). I suppose it might be a good idea to have it set that by default if no `Width` is specified, as right now it'll just not show anything. Also I've set the margin on the text field by default in all cases instead of only when autosizing like how it was previously, since otherwise it would be a pain to set that on each button instance when needed. I've checked all affected components and could not find any text overflowing issues that this could cause. --------- Co-authored-by: Dean Herbert <pe@ppy.sh>
131 lines
5.8 KiB
C#
131 lines
5.8 KiB
C#
// Copyright (c) ppy Pty Ltd <contact@ppy.sh>. Licensed under the MIT Licence.
|
|
// See the LICENCE file in the repository root for full licence text.
|
|
|
|
using osu.Framework.Graphics.Containers;
|
|
using osu.Framework.Graphics;
|
|
using osu.Game.Overlays.Settings;
|
|
using NUnit.Framework;
|
|
using osuTK;
|
|
using osu.Game.Overlays;
|
|
using osu.Game.Graphics.UserInterfaceV2;
|
|
using osu.Game.Graphics.UserInterface;
|
|
using osu.Framework.Allocation;
|
|
using osu.Game.Graphics.Containers;
|
|
using osu.Framework.Graphics.Shapes;
|
|
using osuTK.Graphics;
|
|
using osu.Game.Graphics.Sprites;
|
|
|
|
namespace osu.Game.Tests.Visual.UserInterface
|
|
{
|
|
public partial class TestSceneButtonsInput : OsuManualInputManagerTestScene
|
|
{
|
|
private const int width = 500;
|
|
|
|
[Cached]
|
|
private OverlayColourProvider colourProvider = new OverlayColourProvider(OverlayColourScheme.Green);
|
|
|
|
private readonly SettingsButton settingsButton;
|
|
private readonly OsuClickableContainer clickableContainer;
|
|
private readonly RoundedButton roundedButton;
|
|
private readonly ShearedButton shearedButton;
|
|
|
|
public TestSceneButtonsInput()
|
|
{
|
|
Add(new FillFlowContainer
|
|
{
|
|
AutoSizeAxes = Axes.Y,
|
|
Width = 500,
|
|
Spacing = new Vector2(0, 5),
|
|
Direction = FillDirection.Vertical,
|
|
Children = new Drawable[]
|
|
{
|
|
clickableContainer = new OsuClickableContainer
|
|
{
|
|
RelativeSizeAxes = Axes.X,
|
|
Height = 40,
|
|
Enabled = { Value = true },
|
|
Masking = true,
|
|
CornerRadius = 20,
|
|
Children = new Drawable[]
|
|
{
|
|
new Box
|
|
{
|
|
RelativeSizeAxes = Axes.Both,
|
|
Colour = Color4.Red
|
|
},
|
|
new OsuSpriteText
|
|
{
|
|
Anchor = Anchor.Centre,
|
|
Origin = Anchor.Centre,
|
|
Text = "Rounded clickable container"
|
|
}
|
|
}
|
|
},
|
|
settingsButton = new SettingsButton
|
|
{
|
|
Enabled = { Value = true },
|
|
Text = "Settings button"
|
|
},
|
|
roundedButton = new RoundedButton
|
|
{
|
|
RelativeSizeAxes = Axes.X,
|
|
Enabled = { Value = true },
|
|
Text = "Rounded button"
|
|
},
|
|
shearedButton = new ShearedButton
|
|
{
|
|
Text = "Sheared button",
|
|
LighterColour = Colour4.FromHex("#FFFFFF"),
|
|
DarkerColour = Colour4.FromHex("#FFCC22"),
|
|
TextColour = Colour4.Black,
|
|
Width = width,
|
|
Height = 40,
|
|
Enabled = { Value = true },
|
|
Padding = new MarginPadding(0)
|
|
}
|
|
}
|
|
});
|
|
}
|
|
|
|
[Test]
|
|
public void TestSettingsButtonInput()
|
|
{
|
|
AddStep("Move cursor to button", () => InputManager.MoveMouseTo(settingsButton));
|
|
AddAssert("Button is hovered", () => settingsButton.IsHovered);
|
|
AddStep("Move cursor to padded area", () => InputManager.MoveMouseTo(settingsButton.ScreenSpaceDrawQuad.TopLeft + new Vector2(SettingsPanel.CONTENT_PADDING.Left / 2f, 10)));
|
|
AddAssert("Cursor within a button", () => settingsButton.ScreenSpaceDrawQuad.Contains(InputManager.CurrentState.Mouse.Position));
|
|
AddAssert("Button is not hovered", () => !settingsButton.IsHovered);
|
|
}
|
|
|
|
[Test]
|
|
public void TestRoundedButtonInput()
|
|
{
|
|
AddStep("Move cursor to button", () => InputManager.MoveMouseTo(roundedButton));
|
|
AddAssert("Button is hovered", () => roundedButton.IsHovered);
|
|
AddStep("Move cursor to corner", () => InputManager.MoveMouseTo(roundedButton.ScreenSpaceDrawQuad.TopLeft + Vector2.One));
|
|
AddAssert("Cursor within a button", () => roundedButton.ScreenSpaceDrawQuad.Contains(InputManager.CurrentState.Mouse.Position));
|
|
AddAssert("Button is not hovered", () => !roundedButton.IsHovered);
|
|
}
|
|
|
|
[Test]
|
|
public void TestShearedButtonInput()
|
|
{
|
|
AddStep("Move cursor to button", () => InputManager.MoveMouseTo(shearedButton));
|
|
AddAssert("Button is hovered", () => shearedButton.IsHovered);
|
|
AddStep("Move cursor to corner", () => InputManager.MoveMouseTo(shearedButton.ScreenSpaceDrawQuad.TopLeft + Vector2.One));
|
|
AddAssert("Cursor within a button", () => shearedButton.ScreenSpaceDrawQuad.Contains(InputManager.CurrentState.Mouse.Position));
|
|
AddAssert("Button is not hovered", () => !shearedButton.IsHovered);
|
|
}
|
|
|
|
[Test]
|
|
public void TestRoundedClickableContainerInput()
|
|
{
|
|
AddStep("Move cursor to button", () => InputManager.MoveMouseTo(clickableContainer));
|
|
AddAssert("Button is hovered", () => clickableContainer.IsHovered);
|
|
AddStep("Move cursor to corner", () => InputManager.MoveMouseTo(clickableContainer.ScreenSpaceDrawQuad.TopLeft + Vector2.One));
|
|
AddAssert("Cursor within a button", () => clickableContainer.ScreenSpaceDrawQuad.Contains(InputManager.CurrentState.Mouse.Position));
|
|
AddAssert("Button is not hovered", () => !clickableContainer.IsHovered);
|
|
}
|
|
}
|
|
}
|