1
0
mirror of https://github.com/ppy/osu.git synced 2024-12-15 15:12:57 +08:00
osu-lazer/osu.Game/Online
Bartłomiej Dach a71496bc4e Sanity check received user joined messages
While test failures fixed in 9843da5 were a shortcoming of the test,
they exposed a potential vulnerable point of the multiplayer client
logic. In case of unreliable message delivery it is not unreasonable
that duplicate messages might arrive, in which case the same scenario
that failed in the tests could crash the game.

To ensure that is not the case, explicitly screen each new joined user
against the room user list, to ensure that duplicates do not show up.
`UserLeft` is already tolerant in that respect (if a user is requested
to be removed twice by the server, the second removal just won't do
anything).
2020-12-23 21:00:49 +01:00
..
API Merge branch 'master' into present-recommended 2020-12-22 13:52:29 +09:00
Chat Make TimeBetweenPolls into a bindable 2020-12-20 18:34:54 +09:00
Leaderboards Extract shared rank-formatting helper 2020-12-19 15:04:22 +01:00
Multiplayer Merge branch 'master' into realtime-multiplayer-2 2020-12-21 18:44:03 +09:00
Placeholders Create ClickablePlaceholder and make of use it where applicable. 2020-04-23 14:01:47 +02:00
RealtimeMultiplayer Sanity check received user joined messages 2020-12-23 21:00:49 +01:00
Spectator Add received timestamp and basic xmldoc for header class 2020-12-16 16:19:53 +09:00
DownloadState.cs Make beatmap download buttons inherit BeatmapDownloadTrackingComposite 2019-06-11 23:01:01 +05:30
DownloadTrackingComposite.cs Add null checks to unguarded resolved-as-null fields 2020-11-14 14:52:58 +01:00
OnlineViewContainer.cs Fix cases of multiple bdl methods 2020-10-22 14:30:49 +09:00
PollingComponent.cs Make TimeBetweenPolls into a bindable 2020-12-20 18:34:54 +09:00