1
0
mirror of https://github.com/ppy/osu.git synced 2024-12-16 05:02:56 +08:00
osu-lazer/osu.Game/Overlays/Settings/Sections/Input
Bartłomiej Dach 9f5a280bc2
Fix key binding row fire-and-forgetting writes
Intends to fix test failures as seen in https://github.com/ppy/osu/actions/runs/6692350567/job/18181352642#step:5:129

This is what happens if you carelessly fire and forget.

The working theory (that I'm not sure I have the tools to conclusively
confirm) is that the async write from the key binding changing could
fire _after_ the section is reset.

I briefly considered having the test wait for the change, but given that
the entirety of the surrounding flow is using sync operations, this just
looks like a bug to me. And there's no real sane way to inject async
into that flow due to dependence on `OsuButton.Action`.
2023-10-31 12:25:09 +01:00
..
BindingSettings.cs Automated pass 2023-06-24 01:00:03 +09:00
GlobalKeyBindingsSection.cs Refactor key binding panel leveraging new helper methods 2023-10-12 15:03:29 +02:00
GlobalKeyBindingsSubsection.cs Refactor key binding panel leveraging new helper methods 2023-10-12 15:03:29 +02:00
JoystickSettings.cs Partial everything 2022-11-27 00:00:27 +09:00
KeyBindingConflictPopover.cs Merge branch 'master' into generic-error-sfx 2023-10-14 03:56:41 +09:00
KeyBindingPanel.cs Refactor key binding panel leveraging new helper methods 2023-10-12 15:03:29 +02:00
KeyBindingRow_ConflictResolution.cs Rename KeyBindingRow parts to appease CodeFileSanity 2023-10-13 12:06:25 +02:00
KeyBindingRow_KeyButton.cs Use dimmed placeholder text instead of empty box on cleared bindings 2023-10-13 13:10:04 +02:00
KeyBindingRow.cs Fix key binding row fire-and-forgetting writes 2023-10-31 12:25:09 +01:00
KeyBindingsSubsection.cs Refactor conflict handling flow to be less back-and-forth 2023-10-12 20:25:59 +02:00
MouseSettings.cs Rename NormalSliderBar.cs to RoundedSliderBar.cs 2023-02-02 17:24:45 +01:00
RotationPresetButtons.cs Partial everything 2022-11-27 00:00:27 +09:00
RulesetBindingsSection.cs Refactor key binding panel leveraging new helper methods 2023-10-12 15:03:29 +02:00
TabletAreaSelection.cs Bypass Parent nullability checks for now 2023-10-17 17:48:45 +09:00
TabletSettings.cs Fix some tablet settings being hidden when searching using "area" keyword 2023-05-12 14:57:56 +09:00
TouchSettings.cs Fix touch input handler settings not matching search for "touchscreen" 2023-01-24 13:37:12 +09:00
VariantBindingsSubsection.cs Prepare KeyBindingRow for accepting external changes 2023-10-12 16:00:20 +02:00