mirror of
https://github.com/ppy/osu.git
synced 2024-12-15 15:12:57 +08:00
80c2b1449b
Specifically, `Cancel()` calls were not thread safe. Due to a series of events, `ListPollingComponent` could call `Cancel` from a non-update thread, leading to a race condition where both a `Success` and `Fail` event can be fired. This is intended to be the simplest fix possible, locking and guarding specifically on the callbacks. Further work could be done in the future to improve the flow surrounding `pendingFailure`, potentially reducing redundant work and cleaning up the code, but that's not happening here. Closes https://github.com/ppy/osu/issues/13632. |
||
---|---|---|
.. | ||
API | ||
Chat | ||
Leaderboards | ||
Multiplayer | ||
Placeholders | ||
Rooms | ||
Solo | ||
Spectator | ||
DevelopmentEndpointConfiguration.cs | ||
DownloadState.cs | ||
DownloadTrackingComposite.cs | ||
EndpointConfiguration.cs | ||
HubClientConnector.cs | ||
IHubClientConnector.cs | ||
OnlineViewContainer.cs | ||
PollingComponent.cs | ||
ProductionEndpointConfiguration.cs |