1
0
mirror of https://github.com/ppy/osu.git synced 2024-12-16 08:22:56 +08:00
osu-lazer/osu.Game/Screens/OnlinePlay/Multiplayer
Dean Herbert dea7f2308c Fix participant panels potentially keeping a reference to an old user
If a user leave and then rejoins a multiplayer match while another user
is not at the lobby screen, there is a potential the `ParticipantPanel`
tracking the user will not correctly be recreated to reference the new
instance of the `MultiplayerUser`.

This happens because the `OnRoomUpdated` call is scheduled, which means
it is not running in the background, coupled with the local logic that
relies on `IEquatable(MultiplayerRoomUser)` (which in turn falls back to
a UserID comparison).

Changing this to a reference comparison is the easiest way to resolve
this. Whether we change the `IEquatable` implementation is up for
discussion.

Closes https://github.com/ppy/osu/issues/15970.
2021-12-07 17:24:04 +09:00
..
Match Merge branch 'master' into new-multiplayer-playlist 2021-12-04 13:16:09 +09:00
Participants Fix participant panels potentially keeping a reference to an old user 2021-12-07 17:24:04 +09:00
Spectate Clean up unused resolved properties 2021-12-03 18:49:49 +09:00
CreateMultiplayerMatchButton.cs Move font sizing to base class 2021-08-09 16:17:51 +09:00
GameplayChatDisplay.cs Remove unused using statement 2021-10-26 16:08:21 +09:00
GameplayMatchScoreDisplay.cs Add gameplay-specific team score display which can expand and contract 2021-08-09 19:17:51 +09:00
Multiplayer.cs Move listing polling component to LoungeSubScreen 2021-08-13 17:39:09 +09:00
MultiplayerLoungeSubScreen.cs Don't poll while in room 2021-11-23 16:14:01 +09:00
MultiplayerMatchSongSelect.cs Merge branch 'master' into multi-queueing-modes 2021-11-19 18:58:15 +09:00
MultiplayerMatchSubScreen.cs Add test coverage of incorrect beatmap being used in multiplayer when match started from song select 2021-12-06 14:03:33 +09:00
MultiplayerPlayer.cs Merge branch 'master' into activity-on-multiplayer-screens 2021-08-24 18:50:55 +02:00
MultiplayerResultsScreen.cs Split off multiplayer team results screen to separate class 2021-08-12 20:01:31 +02:00
MultiplayerRoomComposite.cs Don't debounce MultiplayerRoomComposite events 2021-12-05 01:38:39 +09:00
MultiplayerRoomManager.cs Fix password in a better way 2021-08-17 09:40:25 +09:00
MultiplayerTeamResultsScreen.cs Fix vertical offset not being handled correctly during score panel detach process 2021-08-13 16:14:23 +09:00