mirror of
https://github.com/ppy/osu.git
synced 2024-09-22 16:07:25 +08:00
520d2d6cfa
This is an issue as carousel panels manage their own animated state. If
they are marked as not-visible (done at a higher level, from filtering
or update pathways) but clicked while fading out, they will animate back
to a visible state but not be marked as visible.
No tests for this one as it's probably not worthwhile to test (and hard
to do so). Manual testing can be done with the following patch:
```diff
diff --git a/osu.Game/Screens/Select/BeatmapCarousel.cs
b/osu.Game/Screens/Select/BeatmapCarousel.cs
index c3d340ac61..3372242acc 100644
--- a/osu.Game/Screens/Select/BeatmapCarousel.cs
+++ b/osu.Game/Screens/Select/BeatmapCarousel.cs
@@ -255,7 +255,7 @@ private void
beatmapSetsChanged(IRealmCollection<BeatmapSetInfo> sender, ChangeS
}
foreach (int i in changes.NewModifiedIndices)
- UpdateBeatmapSet(sender[i].Detach());
+ Scheduler.AddDelayed(() =>
UpdateBeatmapSet(sender[i].Detach()), 100, true);
foreach (int i in changes.InsertedIndices)
UpdateBeatmapSet(sender[i].Detach());
```
- Enter gameplay and adjust beatmap offset then return to song select
and click the flashing panel.
OR
- Enter editor and save then return to song select and click the
flashing panel.
Closes https://github.com/ppy/osu/discussions/17171.
|
||
|---|---|---|
| .. | ||
| CarouselBeatmap.cs | ||
| CarouselBeatmapSet.cs | ||
| CarouselGroup.cs | ||
| CarouselGroupEagerSelect.cs | ||
| CarouselHeader.cs | ||
| CarouselItem.cs | ||
| DrawableCarouselBeatmap.cs | ||
| DrawableCarouselBeatmapSet.cs | ||
| DrawableCarouselItem.cs | ||
| FilterableDifficultyIcon.cs | ||
| FilterableGroupedDifficultyIcon.cs | ||
| SetPanelBackground.cs | ||
| SetPanelContent.cs | ||
| TopLocalRank.cs | ||