1
0
mirror of https://github.com/ppy/osu.git synced 2026-05-20 04:39:57 +08:00
Files
osu-lazer/osu.Game.Rulesets.Osu/Difficulty
T
Bartłomiej Dach 4e66536ae8 Fix failed scores with no hits on beatmaps with ridiculous mod combinations showing hundreds of pp points awarded (#31741)
See
https://discord.com/channels/188630481301012481/1097318920991559880/1334716356582572074.

On `master` this is actually worse and shows thousands of pp points, so
I guess `pp-dev` is a comparable improvement, but still flagrantly
wrong. The reason why `pp-dev` is better is the `speedDeviation == null`
guard at the start of `computeSpeedValue()` which turns off the rest of
the calculation, therefore not exposing the bug where
`relevantTotalDiff` can go negative. I still guarded it in this commit
just for safety's sake given it is clear it can do very wrong stuff.
4e66536ae8 · 2025-02-14 14:52:05 +00:00
History
..
2024-11-07 21:23:26 +05:00