mirror of
https://github.com/ppy/osu.git
synced 2026-06-09 06:13:43 +08:00
Bartłomiej Dach
3d5dc60cfe
Closes https://github.com/ppy/osu/issues/34062. The root cause of the issue is that `OnEntering()` calls `onArrivingAtScreen()`, which calls `ensureGlobalBeatmapValid()`, which would call `checkBeatmapValidForSelection()` with a `FilterCriteria` instance retrieved from the `FilterControl`. The problem with that is at the time that this call chain is happening, `FilterControl` is not yet loaded, which means in particular that it has not bound itself to the config bindable, as that happens on `LoadComplete()`: https://github.com/ppy/osu/blob/bff07010d1f9874125baf2918f02c5cf61a5ea60/osu.Game/Screens/SelectV2/FilterControl.cs#L198 To resolve this, retrieve the bindable in `SongSelect` itself, which ensures it is valid for reading at the time the above call chain happens.
3d5dc60cfe
·
2025-10-02 13:27:43 +02:00
History