h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2026-06-03 15:04:26 +08:00
Code Issues Releases Wiki Activity

Adjust panel flashing to feel more in time

Browse Source 
Especially on higher BPM tracks.

Rather than delaying time wise, higher level panels will now just flash
less often.

Addresses https://github.com/ppy/osu/discussions/34396 maybe.
This commit is contained in:
Dean Herbert
2025-07-28 15:40:22 +09:00
Unverified
parent 0fab480f3c
commit c83ebe3a25
1 changed files with 7 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files
osu.Game/Screens/SelectV2/Panel.cs
+7 -13
View File
@@ -1,6 +1,7 @@
// Copyright (c) ppy Pty Ltd <contact@ppy.sh>. Licensed under the MIT Licence.
// See the LICENCE file in the repository root for full licence text.
using System;
using osu.Framework.Allocation;
using osu.Framework.Audio.Track;
using osu.Framework.Bindables;
@@ -169,13 +170,13 @@ namespace osu.Game.Screens.SelectV2
public partial class PulsatingBox : BeatSyncedContainer
{
public double FlashOffset;
public int FlashOffset;
private readonly Box box;
public PulsatingBox()
{
EarlyActivationMilliseconds = 50;
EarlyActivationMilliseconds = 40;
InternalChildren = new Drawable[]
{
@@ -186,27 +187,20 @@ namespace osu.Game.Screens.SelectV2
};
}
private int separation = 1;
protected override void OnNewBeat(int beatIndex, TimingControlPoint timingPoint, EffectControlPoint effectPoint, ChannelAmplitudes amplitudes)
{
base.OnNewBeat(beatIndex, timingPoint, effectPoint, amplitudes);
if (beatIndex % separation != 0)
if (beatIndex % Math.Pow(2, FlashOffset) != 0)
return;
double length = timingPoint.BeatLength;
separation = 1;
while (length < 500)
{
while (length < 250)
length *= 2;
separation *= 2;
}
box
.Delay(FlashOffset)
.FadeTo(0.8f, length / 6, Easing.Out)
.FadeTo(0.8f, 40, Easing.Out)
.Then()
.FadeTo(0.4f, length, Easing.Out);
}
@@ -249,7 +243,7 @@ namespace osu.Game.Screens.SelectV2
// Slightly offset the flash animation based on the panel depth.
// This assumes a minimum depth of -2 (groups).
selectionLayer.FlashOffset = (2 + Item!.DepthLayer) * 50;
selectionLayer.FlashOffset = -Item!.DepthLayer;
updateAccentColour();