mirror of
https://github.com/ppy/osu.git
synced 2024-11-17 21:53:21 +08:00
15feb17da8
The recent changes related to adding support for working beatmap load cancellation exposed a flaw in the beatmap difficulty cache. With the way the difficulty computation logic was written, any error in the calculation process (including beatmap load timeout, or cancellation) would result in a 0.00 star rating being permanently cached in memory for the given beatmap. To resolve, change the difficulty cache's return type to nullable. In failure scenarios, `null` is returned, rather than `default(StarDifficulty)` as done previously. |
||
---|---|---|
.. | ||
AdvancedStats.cs | ||
FailRetryGraph.cs | ||
UserRatings.cs |