1
0
mirror of https://github.com/ppy/osu.git synced 2024-11-06 06:57:39 +08:00
osu-lazer/osu.Game.Rulesets.Catch
Samuel Cattini-Schultz 323e4ac26b Refactor catch Movement skill to not require explicit clockrate usage
In catch, rate adjustment mods do not only affect the timings of hitobjects, but also the speed of the player's catcher.

This catcher speed change has an impact on difficulty which is currently accounted for by using the clockrate directly in calculations.

Semantically this is a bad idea because clockrate adjustments are supposed to be fully accounted for in DifficultyHitObjects, but passing clockrate here for the purpose of being used as catcher speed doesn't make much sense, especially since it is copied in every DifficultyHitObject despite being the same value.

It makes more sense to account for this catch specific impact by handling rate adjustment mods in a catch specific way, or more specifically in a Movement skill specific way.
2021-02-21 18:24:30 +11:00
..
Beatmaps Revert "Remove X setter from CatchHitObject" 2020-12-14 13:18:14 +09:00
Difficulty Refactor catch Movement skill to not require explicit clockrate usage 2021-02-21 18:24:30 +11:00
Judgements Restore hyper dash state on revert judgement result 2020-12-08 15:21:47 +09:00
MathUtils Fix some weird private field names 2019-12-11 14:10:35 +09:00
Mods Merge branch 'master' into autoplay-rate-independence 2021-02-11 17:39:45 +09:00
Objects Move shared implementation to a named function 2020-12-14 13:56:46 +09:00
Properties Merge remote-tracking branch 'upstream/master' into android 2019-01-29 18:13:43 -06:00
Replays Formatting 2021-01-29 03:03:23 +01:00
Resources/Testing/Beatmaps Fix right bound not being applied correctly 2020-08-20 20:25:40 +09:00
Scoring Make osu/taiko/catch use Ok+Great 2020-09-29 17:16:55 +09:00
Skinning Fix codefactor style issues 2021-02-04 13:28:35 -08:00
UI Pass a score to the replay recorder to allow reading more general scoring data 2020-12-14 16:52:14 +09:00
CatchInputManager.cs Fix remaining issues 2019-02-28 13:31:40 +09:00
CatchRuleset.cs Adjust namespace 2020-12-07 12:35:24 +09:00
CatchSkinComponent.cs Revert SkinnableSprite lookups to old behaviour 2019-09-03 14:21:54 +09:00
CatchSkinComponents.cs Don't recreate pieces when catch DHO is reused 2020-12-07 12:59:03 +09:00
osu.Game.Rulesets.Catch.csproj Adjust package titles 2021-01-18 11:08:03 +09:00