1
0
mirror of https://github.com/ppy/osu.git synced 2024-12-16 02:22:59 +08:00
osu-lazer/osu.Game/Screens/Edit
Bartłomiej Dach 2e63c2ce20 Fix selection box operation hotkeys not registering in change handler
Could lead to crashes after reversing a note cluster and playing it
back.

The root cause of the crash was that the hotkey operations were not ran
inside of an editor change handler operation. This, in turn, caused the
autoplay replay to not be regenerated after flipping an object cluster,
therefore finally manifesting as a hard crash due to negative time
offsets appearing in judgement results, which interfered with the
default implementation of note lock.

Note that this incidentally also fixes the fact that selection box
hotkey operations (reverse and flip) did not handle undo/redo.
2021-03-17 22:17:42 +01:00
..
Components Fix TimelineParts not using correct beatmap 2021-01-25 18:44:36 +09:00
Compose Fix selection box operation hotkeys not registering in change handler 2021-03-17 22:17:42 +01:00
Design Avoid destroying editor screens when changing between modes 2020-09-24 17:03:54 +09:00
Setup Put back the label 2021-03-17 17:14:04 +09:00
Timing Small refactoring to use .Trim() instead 2021-02-09 12:00:03 +09:00
BindableBeatDivisor.cs Use foreach 2020-01-28 16:04:13 +09:00
ClipboardContent.cs Add initial implementation of editor clipboard 2020-09-11 19:54:20 +09:00
Editor.cs Remove non-accessed field 2021-03-17 17:02:11 +09:00
EditorBeatmap.cs Centralise cases of performing actions on the current selection 2021-02-26 14:15:13 +09:00
EditorChangeHandler.cs Fix state application always checking newest state for early abort, rather than current 2020-11-27 16:57:11 +09:00
EditorClock.cs Expose and consume boolean covering whether an ongoing smooth seek is running 2021-01-15 16:14:38 +09:00
EditorScreen.cs Move resolved usage of WorkingBeatmap in editor components as local as possible to avoid misuse 2021-01-04 16:56:37 +09:00
EditorScreenMode.cs Fix remaining issues 2019-02-28 13:31:40 +09:00
EditorScreenWithTimeline.cs Fix dependency not always available due to nested LoadComponentAsync call 2021-01-05 13:27:45 +09:00
IEditorChangeHandler.cs Merge branch 'master' into editor-timing-screen-change-handling 2020-10-05 15:40:43 +09:00
LegacyEditorBeatmapPatcher.cs Add asserts of HitObjects indices 2020-11-08 00:18:38 +09:00
PromptForSaveDialog.cs Add cancel exit button 2020-09-09 20:04:25 +09:00
TransactionalCommitComponent.cs Make component and add hooking events 2020-10-08 18:04:07 +09:00
WaveformOpacityMenu.cs Add editor waveform opacity selection to menu 2020-11-03 16:01:14 +09:00