1
0
mirror of https://github.com/ppy/osu.git synced 2026-05-19 15:40:14 +08:00
Files
osu-lazer/osu.Game/Screens/Edit/Compose/Components/Timeline
T
Bartłomiej Dach f5aeedc7e1 Fix timeline not updating ticks correctly after arbitrary timing control point changes (again)
Closes https://github.com/ppy/osu/issues/33393.

This is admittedly a half-assed diff. This was apparently "fixed" once
before, eons ago, in https://github.com/ppy/osu/pull/11032, but I'm not
sure whether it regressed, or where, because I don't want to bisect four
years back. (At that time `ControlPointInfo.ControlPointsChanged`
did not exist yet.)

Also there's the part where changes to control points do not undo or
redo (see https://github.com/ppy/osu/issues/31942), but I'm not touching
that *either*, because if I start touching that, then I will get yelled
at for not reviewing the 2.5k line PR that rewrites the entirety of
change handling in editor instead
(https://github.com/ppy/osu/pull/30314). I will attempt to get through
that mental block sometime within the year. Please do not rush me.

The cheap cop-out argument is that hooking this up to `ControlPointInfo`
specifically is probably "more efficient" anyway.
f5aeedc7e1 · 2025-06-10 14:44:23 +02:00
History
..
2023-06-24 01:00:03 +09:00
2023-06-24 01:00:03 +09:00
2022-11-27 00:00:27 +09:00